video: imx: Select VIDEOMODE_HELPERS
Subsystems (2)
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode'
make: *** [vmlinux] Error 1
NOTE: I think this patch is almost absolutely not correct.
--- drivers/staging/imx-drm/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/staging/imx-drm/Kconfig +1 -0
@@ -1,6 +1,7 @@ config DRM_IMX tristate "DRM Support for Freescale i.MX" select DRM_KMS_HELPER + select VIDEOMODE_HELPERS select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM)
Signature · 1 line
1.7.10.4
Fabio Estevam
reviewerRFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Hi Marek,
Quoted 6 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode'
make: *** [vmlinux] Error 1
Quoted 6 lines
NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>
Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
Regards,
Fabio Estevam
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Dear Fabio Estevam,
Quoted 11 lines
Hi Marek,
Quoted 8 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
Best regards,
Marek Vasut
Sascha Hauer
maintainerRFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Quoted 18 lines · Marek Vasut
Dear Fabio Estevam,
Quoted 16 lines
Hi Marek,
Quoted 12 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 4 lines
Quoted 2 lines
Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
No it's not. The parallel display driver needs it, not the i.MX drm support in general.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Dear Sascha Hauer,
Quoted 19 lines · Marek Vasut
Quoted 18 lines
Dear Fabio Estevam,
Quoted 16 lines
Hi Marek,
Quoted 12 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
No it's not. The parallel display driver needs it, not the i.MX drm support in general.
Yep, I expected this coming, thus RFC. I'll roll out new patch and move this to parallel display, ok?
Best regards,
Marek Vasut
Sascha Hauer
maintainerRFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Quoted 24 lines · Marek Vasut
Dear Sascha Hauer,
Quoted 22 lines · Marek Vasut
Quoted 21 lines
Dear Fabio Estevam,
Quoted 18 lines
Hi Marek,
Quoted 6 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1Quoted 6 lines
NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
I'm not sure if the select is at correct symbol, I dont think it is.
No it's not. The parallel display driver needs it, not the i.MX drm support in general.
Yep, I expected this coming, thus RFC. I'll roll out new patch and move this to parallel display, ok?
ok
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
In reply to Marek VasutHi Marek,
Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
Quoted 18 lines
Dear Fabio Estevam,
Quoted 16 lines
Hi Marek,
Quoted 12 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 4 lines
Quoted 2 lines
Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
OF_VIDEOMODE is the correct one. The implementation of of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
regards
Philipp
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Hi Philipp,
Quoted 21 lines
Hi Marek,
Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
Quoted 18 lines
Dear Fabio Estevam,
Quoted 16 lines
Hi Marek,
Quoted 12 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
OF_VIDEOMODEis the correct one. The implementation ofof_get_drm_display_modeindrivers/gpu/drm/drm_modes.cdepends on it.
I really need VIDEOMODE_HELPERS, not OF_VIDEOMODE. If I select only OF_VIDEOMODE, I still get the issue above.
Check drivers/gpu/drm/drm_modes.c , it's protected by CONFIG_VIDEOMODE_HELPERS
Best regards,
Marek Vasut
RFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
Hi Marek,
Am Mittwoch, den 24.04.2013, 02:31 +0200 schrieb Marek Vasut:
Quoted 28 lines
Hi Philipp,
Quoted 26 lines
Hi Marek,
Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
Quoted 22 lines
Dear Fabio Estevam,
Quoted 11 lines
Hi Marek,
Quoted 8 lines · Marek Vasut
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1NOTE: I think this patch is almost absolutely not correct.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Marek Vasut <[email protected]>Cc Sascha Hauer <[email protected]>Cc Philipp Zabel <[email protected]>Cc Fabio Estevam <[email protected]>Patch looks good, but you should have copied Greg Kroah-Hartman, as he is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
Quoted 7 lines
Quoted 2 lines
OF_VIDEOMODEis the correct one. The implementation ofof_get_drm_display_modeindrivers/gpu/drm/drm_modes.cdepends on it.I really need
VIDEOMODE_HELPERS, notOF_VIDEOMODE. If I select onlyOF_VIDEOMODE, I still get the issue above.Check
drivers/gpu/drm/drm_modes.c, it's protected byCONFIG_VIDEOMODE_HELPERS
Indeed, I was looking at the wrong checkout. Sorry for the noise.
regards
Philipp
Fabio Estevam
reviewerRFC PATCH 1/1 video: imx: Select VIDEOMODE_HELPERS
In reply to Philipp ZabelHi Philipp,
Quoted 2 lines · Philipp Zabel
OF_VIDEOMODEis the correct one. The implementation ofof_get_drm_display_modeindrivers/gpu/drm/drm_modes.cdepends on it.
The symbol OF_VIDEOMODE has been deprecated.
Regards,
Fabio Estevam