Skip to contentSkip to conversation

appletalk: info leak in ->getname()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 23, 2013 – Apr 25, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 appletalk: info leak in ->getname()

There is a one byte hole between ->sat_port and ->sat_addr.

net/appletalk/ddp.c +1 -1
index 4a141e3..ef12839 100644
@@ -1253,7 +1253,7 @@ static int atalk_getname(struct socket *sock, struct sockaddr *uaddr,
 			goto out;
 
 	*uaddr_len = sizeof(struct sockaddr_at);
-	memset(&sat.sat_zero, 0, sizeof(sat.sat_zero));
+	memset(&sat, 0, sizeof(sat));
 
 	if (peer) {
 		err = -ENOTCONN;