Skip to contentSkip to conversation

init-mainc-convert-to-pr_foo.patch is IMHO broken

DISCUSSION Uwe Kleine-König 2 participants 2 messages Apr 23, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel parameter. Before the patch I could add

initcall_debug ignore_loglevel

to the kernel command line and got some additional output about initcalls. Now that init/main.c uses pr_debug instead of printk(KERN_DEBUG ...) the interesting statements are not compiled in any more.

Best regards
Uwe

PS: sorry for not doing a proper reply but I didn't find something suitable to reply to.

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#1 lore raw
Quoted 5 lines · On Tue, 23 Apr 2013 21:18:39 +0200 Uwe Kleine-K__nig…

Hello,

init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel parameter. Before the patch I could add

Quoted 7 lines

initcall_debug ignore_loglevel

to the kernel command line and got some additional output about initcalls. Now that init/main.c uses pr_debug instead of printk(KERN_DEBUG ...) the interesting statements are not compiled in any more.

huh. pr_debug() is different from all the other pr_foo()s. I never noticed that.

This?

init/main.c renamed from init/main.c~init-mainc-convert-to-pr_foo-fix +2 -0
@@ -9,6 +9,8 @@
  *  Simplified starting of init:  Michael A. Griffith <[email protected]> 
  */
 
+#define DEBUG
+
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/proc_fs.h>

_