Skip to contentSkip to conversation

fix initconst in lib/decompress.c

PATCH In review Andi Kleen 3 participants 3 messages Apr 21, 2013 – Apr 23, 2013 Library code

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 fix initconst in lib/decompress.c

From: Andi Kleen <[email protected]>

lib/decompress.c +1 -1
index 31a8042..f8fdeda 100644
@@ -38,7 +38,7 @@ struct compress_format {
 	decompress_fn decompressor;
 };
 
-static const struct compress_format compressed_formats[] __initdata = {
+static const struct compress_format compressed_formats[] __initconst = {
 	{ {037, 0213}, "gzip", gunzip },
 	{ {037, 0236}, "gzip", gunzip },
 	{ {0x42, 0x5a}, "bzip2", bunzip2 },
maintainer
#1 lore raw
Quoted 8 lines · On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <[email protected]> wrote:

From: Andi Kleen <[email protected]>

lib/decompress.c +0 -0
index 31a8042..f8fdeda 100644

lib/decompress.c struct compress_format { · line 44

Quoted 8 lines
lib/decompress.c +1 -1
@@ -38,7 +38,7 @@ struct compress_format {
 	decompress_fn decompressor;
 };
 
-static const struct compress_format compressed_formats[] __initdata = {
+static const struct compress_format compressed_formats[] __initconst = {
 	{ {037, 0213}, "gzip", gunzip },
 	{ {037, 0236}, "gzip", gunzip },
 	{ {0x42, 0x5a}, "bzip2", bunzip2 },

That's missing both a changelog and the signed-off-by. Did your scripts break?

#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 11 lines · On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <[email protected]> wrote:

From: Andi Kleen <[email protected]>

lib/decompress.c +0 -0
index 31a8042..f8fdeda 100644
@@ -38,7 +38,7 @@ struct compress_format {
 	decompress_fn decompressor;
 };
 
Quoted 8 lines

lib/decompress.c struct compress_format { · line 44

Quoted 5 lines
lib/decompress.c +1 -1
-static const struct compress_format compressed_formats[] __initdata = {
+static const struct compress_format compressed_formats[] __initconst = {
 	{ {037, 0213}, "gzip", gunzip },
 	{ {037, 0236}, "gzip", gunzip },
 	{ {0x42, 0x5a}, "bzip2", bunzip2 },

That's missing both a changelog and the signed-off-by. Did your scripts break?

I normally don't write a description for initconst patches, as they should be obvious.

Sorry for the missing Signed-off-by. Hereby added:

Please let me know if I should resend.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only