Bluetooth: hci_get_cmd_complete() can be static
Subsystems (2)
PATCH 1/1 Bluetooth: hci_get_cmd_complete() can be static
From: Fengguang Wu <[email protected]>
There are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master head: a0b644b0385fa58ca578f6dce4473e8a8e6f6c38 commit: 75e84b7c522c6e07964cd1f5bf28535768a1e9fa Bluetooth: Add __hci_cmd_sync() helper function date: 13 days ago
Quoted 1 line
Quoted 1 line
net/bluetooth/hci_core.c:82:16: sparse: symbol 'hci_get_cmd_complete' was not declared. Should it be static?
Signed-off-by Fengguang Wu <[email protected]>
Acked-by Johan Hedberg <[email protected]>
--- net/bluetooth/hci_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/bluetooth/hci_core.c +2 -1
@@ -79,7 +79,8 @@ static void hci_req_cancel(struct hci_dev *hdev, int err) } } -struct sk_buff *hci_get_cmd_complete (struct hci_dev *hdev,u16 opcode,u8 event) +static struct sk_buff *hci_get_cmd_complete (struct hci_dev *hdev,u16 opcode, +u8 event) {struct hci_ev_cmd_complete *ev;struct hci_event_hdr *hdr;
Signature · 1 line
1.7.10.4
Hi Johan,
Quoted 9 lines · Johan Hedberg
From: Fengguang Wu <[email protected]>
There are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master head: a0b644b0385fa58ca578f6dce4473e8a8e6f6c38 commit: 75e84b7c522c6e07964cd1f5bf28535768a1e9fa Bluetooth: Add __hci_cmd_sync() helper function date: 13 days ago
Quoted 7 lines
Quoted 1 line
Quoted 1 line
net/bluetooth/hci_core.c:82:16: sparse: symbol 'hci_get_cmd_complete' was not declared. Should it be static?Signed-off-by Fengguang Wu <[email protected]>Acked-by Johan Hedberg <[email protected]>--- net/bluetooth/hci_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo