Skip to contentSkip to conversation

netfilter: nf_nat: missing condition in nf_xfrm_me_harder()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 24, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: nf_nat: missing condition in nf_xfrm_me_harder()

This if statement was accidentally dropped in a merge commit so now it returns unconditionally.

net/netfilter/nf_nat_core.c +1 -0
index 2e469ca..d4c9a31 100644
@@ -90,6 +90,7 @@ int nf_xfrm_me_harder(struct sk_buff *skb, unsigned int family)
 	int err;
 
 	err = xfrm_decode_session(skb, &fl, family);
+	if (err)
 		return err;
 
 	dst = skb_dst(skb);
maintainer Applied
#1 lore raw
Quoted 2 lines · Dan Carpenter

This if statement was accidentally dropped in a merge commit so now it returns unconditionally.

Applied, thanks Dan.