Skip to contentSkip to conversation

nfsd4: better error return to indicate SSV non-support

PATCH New J. Bruce Fields 1 participant 1 message Apr 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd4: better error return to indicate SSV non-support

From: "J. Bruce Fields" <[email protected]>

As 4.1 becomes less experimental and SSV still isn't implemented, we have to admit it's not going to be, and return some sensible error rather than just saying "our server's broken". Discussion in the ietf group hasn't turned up any objections to using NFS4ERR_ENC_ALG_UNSUPP for that purpose.

---
 fs/nfsd/nfs4state.c |    1 +
 1 file changed, 1 insertion(+)

Committing for 3.10.--b.

fs/nfsd/nfs4state.c +1 -0
index e39bf53..a964a17 100644
@@ -1651,6 +1651,7 @@ nfsd4_exchange_id(struct svc_rqst *rqstp,
 	default:				/* checked by xdr code */
 		WARN_ON_ONCE(1);
 	case SP4_SSV:
+		return nfserr_encr_alg_unsupp;
 	case SP4_MACH_CRED:
 		return nfserr_serverfault;	/* no excuse :-/ */
 	}
Signature · 1 line
1.7.9.5