glibmm: new package
PATCH 1/2 glibmm: new package
---
v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
--- package/Config.in | 1 + package/glibmm/Config.in | 13 +++++++++++++ package/glibmm/glibmm.mk | 13 +++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 package/glibmm/Config.in create mode 100644 package/glibmm/glibmm.mk
package/Config.in +1 -0
@@ -558,6 +558,7 @@ source "package/fftw/Config.in" source "package/libargtable2/Config.in" source "package/argp-standalone/Config.in" source "package/boost/Config.in" +source "package/glibmm/Config.in" source "package/gmp/Config.in" source "package/gsl/Config.in" source "package/gtest/Config.in"
package/glibmm/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_GLIBMM + bool "glibmm" + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBSIGC + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_USE_WCHAR + help + The GLibmm package is a set of C++ bindings for GLib. + + http://www.gtkmm.org/ + +comment "glibmm requires a toolchain with C++ & WCHAR support enabled" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
package/glibmm/glibmm.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# Glibmm +# +############################################################# +GLIBMM_VERSION = 2.30.1 +GLIBMM_LICENSE = LGPLv2.1 +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2 +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30 +GLIBMM_INSTALL_STAGING = YES +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf + +$(eval $(autotools-package))
Signature · 1 line
1.8.1.2
PATCH 2/2 libxml++: new package
---
v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR libxml++ is a C++ wrapper for libxml2 it has glibmm as dependency
--- package/Config.in | 1 + package/libxmlpp/Config.in | 13 +++++++++++++ package/libxmlpp/libxmlpp.mk | 15 +++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 package/libxmlpp/Config.in create mode 100644 package/libxmlpp/libxmlpp.mk
package/Config.in +1 -0
@@ -620,6 +620,7 @@ source "package/json-glib/Config.in" source "package/libroxml/Config.in" source "package/libxml-parser-perl/Config.in" source "package/libxml2/Config.in" +source "package/libxmlpp/Config.in" source "package/libxslt/Config.in" source "package/libyaml/Config.in" source "package/mxml/Config.in"
package/libxmlpp/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_LIBXMLPP + bool "libxmlpp" + select BR2_PACKAGE_LIBXML2 + select BR2_PACKAGE_GLIBMM + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_USE_WCHAR + help + libxml++ is a C++ wrapper for the libxml XML parser library. + + http://libxmlplusplus.sourceforge.net/ + +comment "LibXML++ requires a toolchain with C++ & WCHAR support enabled" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
package/libxmlpp/libxmlpp.mk new file +15 -0
@@ -0,0 +1,15 @@ +############################################################# +# +# LibXML++ +# +############################################################# +LIBXMLPP_VERSION_MAJOR = 2.34 +LIBXMLPP_VERSION_MINOR = 2 +LIBXMLPP_VERSION = $(LIBXMLPP_VERSION_MAJOR).$(LIBXMLPP_VERSION_MINOR) +LIBXMLPP_LICENSE = LGPLv2+ +LIBXMLPP_SOURCE = libxml++-$(LIBXMLPP_VERSION).tar.bz2 +LIBXMLPP_SITE = http://ftp.gnome.org/pub/GNOME/sources/libxml++/$(LIBXMLPP_VERSION_MAJOR) +LIBXMLPP_INSTALL_STAGING = YES +LIBXMLPP_DEPENDENCIES = libxml2 glibmm host-pkgconf + +$(eval $(autotools-package))
Signature · 1 line
1.8.1.2
PATCH 2/2 libxml++: new package
Dear nmenegale,
package/libxmlpp/libxmlpp.mk line 5
Quoted 5 lines · nmenegale
package/libxmlpp/libxmlpp.mk new file +5
-0+############################################################# +# +# LibXML++ +# +#############################################################
One empty line between headers and variables.
package/libxmlpp/libxmlpp.mk line 9
Quoted 4 lines
package/libxmlpp/libxmlpp.mk new file +4
-0+LIBXMLPP_VERSION_MAJOR = 2.34 +LIBXMLPP_VERSION_MINOR = 2 +LIBXMLPP_VERSION = $(LIBXMLPP_VERSION_MAJOR).$(LIBXMLPP_VERSION_MINOR) +LIBXMLPP_LICENSE = LGPLv2+
License wise, this package is funky. The COPYING file contains the text of LGPLv2.1. The source files of the library in the libxml++/ directory just say "are covered by the GNU Lesser General Public License, which should be included with libxml++ as the file COPYING." without specifying the version, and whether is 'or later' or not.
And the examples in the examples/ directory are under "GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.".
So this looks a package for which the licensing question was not really handled properly. If we want to express what I found, it should probably be something like:
LIBXMLPP_LICENSE = LGPLv2.1 (library), LGPLv2+ (examples) LIBXMLPP_LICENSE_FILES = COPYING
But I am not sure this is actually the intention of the libxml++ authors.
Quoted 1 line
+LIBXMLPP_SOURCE = libxml++-$(LIBXMLPP_VERSION).tar.bz2
Use .tar.xz instead?
package/libxmlpp/libxmlpp.mk line 15
Quoted 5 lines
package/libxmlpp/libxmlpp.mk new file +5
-0+LIBXMLPP_SITE = http://ftp.gnome.org/pub/GNOME/sources/libxml++/$(LIBXMLPP_VERSION_MAJOR) +LIBXMLPP_INSTALL_STAGING = YES +LIBXMLPP_DEPENDENCIES = libxml2 glibmm host-pkgconf + +$(eval $(autotools-package))
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 glibmm: new package
In reply to nmenegaleDear nmenegale,
Quoted 9 lines · nmenegale
package/glibmm/glibmm.mk new file +3
-0@@ -0,0 +1,13 @@ +############################################################# +# +# Glibmm
package/glibmm/glibmm.mk line 13
Quoted 10 lines
package/glibmm/glibmm.mk new file +10
-0+# +############################################################# +GLIBMM_VERSION = 2.30.1 +GLIBMM_LICENSE = LGPLv2.1 +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2 +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30 +GLIBMM_INSTALL_STAGING = YES +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf + +$(eval $(autotools-package))
A few minor comments:
* Please add an empty new line between the header and the the first variable.
* Maybe you should split the version number in two variables in order to re-use it for the site:
GLIBMM_VERSION_MAJOR = 2.30GLIBMM_VERSION_MINOR = 1GLIBMM_VERSION = $(GLIBMM_VERSION_MAJOR).$(GLIBMM_VERSION_MINOR) GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/$(GLIBMM_VERSION_MAJOR)
* The licensing informations is not entirely correct. I think it should be:
GLIBMM_LICENSE = LGPLv2.1+ (library), GPLv2+ (tools) GLIBMM_LICENSE_FILES = COPYING COPYING.tools
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 glibmm: new package
In reply to nmenegaleDear nmenegale,
Quoted 1 line · nmenegale
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
I believe you could use the .tar.xz tarball instead, it's a bit smaller to download.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 glibmm: new package
In reply to nmenegaleQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"nmenegale" == nmenegale <[email protected]> writes:
nmenegale> Signed-off-by: Nicolas M?n?gale <[email protected]> nmenegale> ---
nmenegale> v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR nmenegale> glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper) nmenegale> Signed-off-by: nmenegale <[email protected]> nmenegale> ---
nmenegale> package/Config.in | 1 + nmenegale> package/glibmm/Config.in | 13 +++++++++++++ nmenegale> package/glibmm/glibmm.mk | 13 +++++++++++++ nmenegale> 3 files changed, 27 insertions(+) nmenegale> create mode 100644 package/glibmm/Config.in nmenegale> create mode 100644 package/glibmm/glibmm.mk
nmenegale> diff --git a/package/Config.in b/package/Config.in nmenegale> index 06bcdef..c75c3ec 100644
nmenegale> --- a/package/Config.in
nmenegale> +++ b/package/Config.in
nmenegale> @@ -558,6 +558,7 @@ source "package/fftw/Config.in"
nmenegale> source "package/libargtable2/Config.in" nmenegale> source "package/argp-standalone/Config.in" nmenegale> source "package/boost/Config.in" nmenegale> +source "package/glibmm/Config.in" nmenegale> source "package/gmp/Config.in" nmenegale> source "package/gsl/Config.in" nmenegale> source "package/gtest/Config.in"
nmenegale> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in nmenegale> new file mode 100644
nmenegale> index 0000000..012b681
nmenegale> --- /dev/null
nmenegale> +++ b/package/glibmm/Config.in
nmenegale> @@ -0,0 +1,13 @@
nmenegale> +config BR2_PACKAGE_GLIBMM
nmenegale> + bool "glibmm"
nmenegale> + select BR2_PACKAGE_LIBGLIB2
nmenegale> + select BR2_PACKAGE_LIBSIGC
nmenegale> + depends on BR2_INSTALL_LIBSTDCPP
nmenegale> + depends on BR2_USE_WCHAR
nmenegale> + help
nmenegale> + The GLibmm package is a set of C++ bindings for GLib.
nmenegale> +
There's some stray trailing spaces here. Committed with that fixed, thanks.
Signature · 1 line
Bye, Peter Korsgaard