Skip to contentSkip to conversation

xfsprogs: metadata CRC support V2

PATCH In review Dave Chinner 4 participants 17 messages Apr 12, 2013 – May 9, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfsprogs: metadata CRC support V2

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

Dave Chinner (26):
xfsprogs: sync code to current kernel code
xfsprogs: update libxfs to 3.9-rc1 + xfsdev
xfsprogs: add CRC32c infrastructure
xfsprogs: updata libxlog to current kernel code
libxfs: add crc format changes to generic btrees
xfsprogs: add crc format chagnes to ag headers
libxfs: change quota buffer formats
libxfs: add version 3 inode support
libxfs: add support for crc headers on remote symlinks
xfs: add CRC checks to block format directory blocks
xfs: add CRC checking to dir2 free blocks
xfs: add CRC checking to dir2 data blocks
xfs: add CRC checking to dir2 leaf blocks
xfs: shortform directory offsets change for dir3 format
xfs: add CRCs to dir2/da node blocks
xfs: add CRCs to attr leaf blocks
xfs: split remote attribute code out
xfs: add CRC protection to remote attributes
xfs: add buffer types to directory and attribute buffers
xfs: buffer type overruns blf_flags field
xfs: add CRC checks to the superblock
xfs: implement extended feature masks
xfsprogs: introduce CRC support into mkfs.xfs
xfsprogs: add crc format support to repair
xfsprogs: add crc format support to db
xfs_repair: update for dir/attr crc format changes.

Diffstat is below [1].

The changes are roughly:

- sync to current kernel code
- apply userspace converted version of kernel patches
- update xfsprogs utilities to be aware of CRCs

Much of the last 4 patches needs to be split up and redirected back to the patches that introduce the bugs that are fixed or conversions that are missed.

Repair needs support for remote attribute and symlink block CRC support, as well as verifying the new feature masks. mkfs needs to handle thenew feature masks correctly, too. xfs_db needs to be able to display all crc enabled formats, and needs to ensure all read-only functions work properly on CRC enabled filesystems. I think that metadump will also need some attention. So there's plenty of work yet to do, though it is already usable.

For non-CRC filesystems, the utilities appear to work without regressions in xfstests. Most of the testing I have done is on non-CRC filesytsems.

For CRC enabled filesystems, xfstests will run for a short while before the kernel bugs out with an attribute corruption. Over the next week I hope to get the kernel code to the point where it will run most of xfstests with CRCs enabled:

$ sudo MKFS_OPTIONS="-m crc=1" ./check -g auto
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test-4 3.9.0-rc4-dgc+
MKFS_OPTIONS  -- -f -m crc=1 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scr
generic/001      4s
generic/002      0s
generic/005      0s
generic/006      1s
generic/007      1s
generic/010      [not run] dbtest was not built for this platform
generic/011      1s
generic/013      12s
generic/014      3s
generic/015      0s

generic/020
Message from syslogd@test-4 at Apr 13 00:35:45 ...
kernel:[ 451.268820] XFS: Assertion failed: ichdr->firstused >= ichdr->count * sizeof(xfs_attr_leaf_entry_t) + xfs_attr3_leaf_hdr_size(leaf), file: fs/xfs/xfs_attr_leaf.c, line: 1427
$

Finally, I'm sending this update out as a quilt series style tarball rather than email patches as some of the patches are too large for the list and will get blocked. Hence you get patches and a series file that I've just exported from my current guilt tree.

Obligatory warning: If you enable CRCs, the code will eat your data. Use this only only for testing with data you don't care about.

Comments, flames and testing results all welcome.

Cheers,

Dave.

[1] diffstat:

 copy/xfs_copy.c            |    5 +-
 db/agf.c                   |    3 +
 db/agfl.c                  |   16 +
 db/agfl.h                  |    2 +
 db/agi.c                   |    3 +
 db/attr.c                  |   20 +-
 db/btblock.c               |  145 +
 db/btblock.h               |   10 +
 db/check.c                 |   55 +-
 db/dir.c                   |    8 +-
 db/dir.h                   |    6 +
 db/dir2.c                  |   16 +-
 db/dir2.h                  |   32 +
 db/dir2sf.c                |   24 +-
 db/dirshort.c              |    1 +
 db/field.c                 |   16 +
 db/field.h                 |    8 +
 db/freesp.c                |   11 +-
 db/init.c                  |    4 +
 db/inode.c                 |   27 +
 db/inode.h                 |    3 +
 db/metadump.c              |   27 +-
 db/sb.c                    |   40 +-
 db/type.c                  |   35 +-
 db/type.h                  |    3 +-
 estimate/xfs_estimate.c    |    3 +
 fsr/xfs_fsr.c              |    2 +-
 include/Makefile           |   13 +-
 include/libxfs.h           |  222 +-
 include/libxlog.h          |   34 +-
 include/linux.h            |    1 +
 include/platform_defs.h.in |    5 +
 include/swab.h             |   38 +
 include/xfs.h              |    1 +
 include/xfs_ag.h           |   81 +-
 include/xfs_alloc.h        |   57 +-
 include/xfs_alloc_btree.h  |   29 +-
 include/xfs_arch.h         |   16 +
 include/xfs_attr_leaf.h    |  135 +-
 include/xfs_attr_remote.h  |   52 +
 include/xfs_bmap.h         |  325 +-
 include/xfs_bmap_btree.h   |   21 +-
 include/xfs_btree.h        |   87 +-
 include/xfs_buf_item.h     |  117 +-
 include/xfs_cksum.h        |   63 +
 include/xfs_da_btree.h     |  185 +-
 include/xfs_dinode.h       |   47 +-
 include/xfs_dir1.h         |   13 +
 include/xfs_dir2.h         |   95 +-
 include/xfs_dir2_block.h   |   92 -
 include/xfs_dir2_data.h    |  184 -
 include/xfs_dir2_format.h  |  836 +++++
 include/xfs_dir2_leaf.h    |  253 --
 include/xfs_dir2_node.h    |  100 -
 include/xfs_dir2_sf.h      |  171 -
 include/xfs_fs.h           |   38 +-
 include/xfs_ialloc.h       |   17 +-
 include/xfs_ialloc_btree.h |   12 +-
 include/xfs_inode.h        |  263 +-
 include/xfs_inode_item.h   |   22 +-
 include/xfs_inum.h         |   16 -
 include/xfs_log.h          |   31 +-
 include/xfs_log_priv.h     |  101 +-
 include/xfs_mount.h        |   48 +-
 include/xfs_quota.h        |   58 +-
 include/xfs_rtalloc.h      |    4 +-
 include/xfs_sb.h           |  172 +-
 include/xfs_symlink.h      |   45 +
 include/xfs_trace.h        |   69 +-
 include/xfs_trans.h        |   88 +-
 include/xfs_types.h        |   25 +-
 libxfs/Makefile            |   26 +-
 libxfs/crc32.c             | 1036 ++++++
 libxfs/crc32defs.h         |   72 +
 libxfs/gen_crc32table.c    |  144 +
 libxfs/init.c              |   26 +-
 libxfs/logitem.c           |   20 +-
 libxfs/rdwr.c              |  522 ++-
 libxfs/trans.c             |   55 +-
 libxfs/util.c              |  230 +-
 libxfs/xfs.h               |  147 +-
 libxfs/xfs_alloc.c         |  694 ++--
 libxfs/xfs_alloc_btree.c   |  140 +-
 libxfs/xfs_attr.c          |  546 +--
 libxfs/xfs_attr_leaf.c     | 1858 ++++++----
 libxfs/xfs_attr_remote.c   |  527 +++
 libxfs/xfs_bmap.c          | 8950 ++++++++++++++++++++++++----------------------
 libxfs/xfs_bmap_btree.c    |  124 +-
 libxfs/xfs_btree.c         |  415 ++-
 libxfs/xfs_da_btree.c      | 2598 ++++++++------
 libxfs/xfs_dir2.c          |  149 +-
 libxfs/xfs_dir2_block.c    |  806 +++--
 libxfs/xfs_dir2_data.c     |  604 ++--
 libxfs/xfs_dir2_leaf.c     | 1342 ++++---
 libxfs/xfs_dir2_node.c     | 1455 ++++----
 libxfs/xfs_dir2_priv.h     |  160 +
 libxfs/xfs_dir2_sf.c       |  326 +-
 libxfs/xfs_ialloc.c        |  632 ++--
 libxfs/xfs_ialloc_btree.c  |   87 +-
 libxfs/xfs_inode.c         |  505 ++-
 libxfs/xfs_mount.c         |  259 +-
 libxfs/xfs_rtalloc.c       |   77 +-
 libxfs/xfs_symlink.c       |  154 +
 libxfs/xfs_trans.c         |    9 +-
 libxlog/xfs_log_recover.c  |  299 +-
 logprint/log_copy.c        |    2 +-
 logprint/log_dump.c        |    2 +-
 logprint/log_misc.c        |    9 +-
 logprint/log_print_all.c   |    7 +-
 logprint/log_print_trans.c |   22 +-
 logprint/logprint.c        |    8 +-
 logprint/logprint.h        |   10 +-
 mdrestore/Makefile         |    2 +-
 mkfs/maxtrres.c            |    4 +-
 mkfs/proto.c               |   14 +-
 mkfs/xfs_mkfs.c            |  162 +-
 mkfs/xfs_mkfs.h            |   12 +-
 repair/agheader.c          |   36 +-
 repair/attr_repair.c       |   63 +-
 repair/dino_chunks.c       |   13 +-
 repair/dinode.c            |  208 +-
 repair/dir.c               |   96 +-
 repair/dir2.c              |  497 +--
 repair/dir2.h              |   28 +-
 repair/phase2.c            |   13 +-
 repair/phase3.c            |    2 +-
 repair/phase5.c            |  157 +-
 repair/phase6.c            |  327 +-
 repair/prefetch.c          |   11 +-
 repair/rt.c                |    4 +-
 repair/scan.c              |  166 +-
 repair/scan.h              |   12 +-
 repair/versions.c          |    2 +-
 repair/xfs_repair.c        |    9 +-
 134 files changed, 19036 insertions(+), 12663 deletions(-)
 create mode 100644 include/xfs_attr_remote.h
 create mode 100644 include/xfs_cksum.h
 create mode 100644 include/xfs_dir1.h
 delete mode 100644 include/xfs_dir2_block.h
 delete mode 100644 include/xfs_dir2_data.h
 create mode 100644 include/xfs_dir2_format.h
 delete mode 100644 include/xfs_dir2_leaf.h
 delete mode 100644 include/xfs_dir2_node.h
 delete mode 100644 include/xfs_dir2_sf.h
 create mode 100644 include/xfs_symlink.h
 create mode 100644 libxfs/crc32.c
 create mode 100644 libxfs/crc32defs.h
 create mode 100644 libxfs/gen_crc32table.c
 create mode 100644 libxfs/xfs_attr_remote.c
 create mode 100644 libxfs/xfs_dir2_priv.h
 create mode 100644 libxfs/xfs_symlink.c
Signature · 2 lines
Dave Chinner
[email protected]

xfsprogs-crc-patchset-v2/0000755000175000017500000000000012132011610014237 5ustar davedavexfsprogs-crc-patchset-v2/series0000644000175000017500000000143612132011546015470 0ustar davedaverepair-fix-extent-count logprint-agi-dump
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update
xfsprogs-crc-infrastructure
xfsprogs-libxlog-kernel-sync
btree-format-changes
ag-hdr-format-changes
quota-format-changes
inode-v3
remote-symlink-crc
xfs-add-crc-to-dir2-block-2
xfs-add-crc-to-dir2-free-2
xfs-add-crc-to-dir2-data-2
xfs-add-crc-to-dir2-leaf-3
dir2-sf
xfs-add-crc-to-da-node
xfs-add-crc-to-attr-leaf
xfs-attr-rmt-move
xfs-add-crc-to-remote-attr
xfs-da-blf-types
xfs-trans-type-blf-change
xfs__add_crc_checks_to_the_superblock-2
xfs-sb-v5-feature-masks
xfsprogs-mkfs-crc-support
xfsprogs-repair-crc-support
xfsprogs-db-crc-support
xfsprogs-repair-dir-crc-support
debug
bpm-progs-deb
xfsprogs-freespace
spaceman-trim
spaceman-prealloc-flush
spaceman-ag-control
xfsprogs-freespace-2
xfsprogs-crc-patchset-v2/repair-fix-extent-count0000600000175000017500000000432012132011546020662 0ustar davedavexfs_repair: validate on-disk extent count better

From: Dave Chinner <[email protected]>

When scanning a btree format inode, we trust the extent count to be in range. However, values of the range 2^31 <= cnt < 2^32 are invalid and can cause problems with signed range checks. This results in assert failures which validating the extent count such as:

xfs_repair: dinode.c:768: process_bmbt_reclist_int: Assertion `i < *numrecs' failed.

Validate the extent count is at least within the positive range of a singed 32 bit integer before using it.

---
 repair/dinode.c |   25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)
repair/dinode.c +23 -2
index 5a2da39..239bb7b 100644
@@ -1293,7 +1293,7 @@ process_exinode(
 	xfs_bmbt_rec_t		*rp;
 	xfs_dfiloff_t		first_key;
 	xfs_dfiloff_t		last_key;
-	int			numrecs;
+	int32_t			numrecs;
 	int			ret;
 
 	lino = XFS_AGINO_TO_INO(mp, agno, ino);
@@ -1302,6 +1302,15 @@ process_exinode(
 	numrecs = XFS_DFORK_NEXTENTS(dip, whichfork);
 
 	/*
+	 * We've already decided on the maximum number of extents on the inode,
+	 * and numrecs may be corrupt. Hence make sure we only allow numrecs to
+	 * be in the range of valid on-disk numbers, which is:
+	 *	0 < numrecs < 2^31 - 1
+	 */
+	if (numrecs < 0)
+		numrecs = *nex;
+
+	/*
 	 * XXX - if we were going to fix up the btree record,
 	 * we'd do it right here.  For now, if there's a problem,
 	 * we'll bail out and presumably clear the inode.
@@ -2038,11 +2047,23 @@ process_inode_data_fork(
 {
 	xfs_ino_t	lino = XFS_AGINO_TO_INO(mp, agno, ino);
 	int		err = 0;
+	int		nex;
+
+	/*
+	 * extent count on disk is only valid for positive values. The kernel
+	 * uses negative values in memory. hence if we see negative numbers
+	 * here, trash it!
+	 */
+	nex = be32_to_cpu(dino->di_nextents);
+	if (nex < 0)
+		*nextents = 1;
+	else
+		*nextents = nex;
 
-	*nextents = be32_to_cpu(dino->di_nextents);
 	if (*nextents > be64_to_cpu(dino->di_nblocks))
 		*nextents = 1;
 
+
 	if (dino->di_format != XFS_DINODE_FMT_LOCAL && type != XR_INO_RTDATA)
 		*dblkmap = blkmap_alloc(*nextents, XFS_DATA_FORK);
 	*nextents = 0;

xfsprogs-crc-patchset-v2/logprint-agi-dump0000600000175000017500000000241212132011546017520 0ustar davedave---

 logprint/log_print_all.c |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
logprint/log_print_all.c +19 -0
index 5b2d942..70b0905 100644
@@ -122,6 +122,7 @@ xlog_recover_print_buffer(
 			       be32_to_cpu(*(__be32 *)(p+56)),
 			       be32_to_cpu(*(__be32 *)(p+60)));
 		} else if (be32_to_cpu(*(__be32 *)p) == XFS_AGI_MAGIC) {
+			int bucket, buckets;
 			agi = (xfs_agi_t *)p;
 			printf(_("	AGI Buffer: (XAGI)\n"));
 			if (!print_buffer) 
@@ -137,6 +138,24 @@ xlog_recover_print_buffer(
 				be32_to_cpu(agi->agi_level),
 				be32_to_cpu(agi->agi_freecount),
 				be32_to_cpu(agi->agi_newino));
+			if (len == 128) {
+				buckets = 17;
+			} else if (len == 256) {
+				buckets = 32 + 17;
+			} else {
+				buckets = XFS_AGI_UNLINKED_BUCKETS;
+			}
+			for (bucket = 0; bucket < buckets;) {
+				int col;
+				printf(_("bucket[%d - %d]: "), bucket, bucket+3);
+				for (col = 0; col < 4; col++, bucket++) {
+					if (bucket < buckets) {
+						printf("0x%x ",
+			be32_to_cpu(agi->agi_unlinked[bucket]));
+					}
+				}
+				printf("\n");
+			}
 		} else if (be32_to_cpu(*(__be32 *)p) == XFS_AGF_MAGIC) {
 			agf = (xfs_agf_t *)p;
 			printf(_("	AGF Buffer: (XAGF)\n"));

xfsprogs-crc-patchset-v2/xfsprogs-kernel-3.8-update0000600000175000017500000312445612132011546021120 0ustar davedavexfsprogs: sync code to current kernel code

From: Dave Chinner <[email protected]>

Update code base to match kernel 3.8-rc2 code base.

db/check.c +11 -9
index e601e0a..5921779 100644
@@ -31,6 +31,8 @@
 #include "output.h"
 #include "init.h"
 #include "malloc.h"
+#include "dir.h"
+#include "dir2.h"
 
 typedef enum {
 	IS_USER_QUOTA, IS_PROJECT_QUOTA, IS_GROUP_QUOTA,
@@ -2223,7 +2225,7 @@ process_data_dir_v2(
 	bf = data->hdr.bestfree;
 	ptr = (char *)data->u;
 	if (be32_to_cpu(block->hdr.magic) == XFS_DIR2_BLOCK_MAGIC) {
-		btp = xfs_dir2_block_tail_p(mp, block);
+		btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 		lep = xfs_dir2_block_leaf_p(btp);
 		endptr = (char *)lep;
 		if (endptr <= ptr || endptr > (char *)btp) {
@@ -2840,7 +2842,7 @@ process_inode(
 			break;
 		}
 		if (ic) {
-			dqprid = xfs_get_projid(idic);	/* dquot ID is u32 */
+			dqprid = xfs_get_projid(&idic);	/* dquot ID is u32 */
 			quota_add(&dqprid, &idic.di_gid, &idic.di_uid,
 				  0, bc, ic, rc);
 		}
@@ -3166,7 +3168,7 @@ process_leaf_node_dir_v2_free(
 		error++;
 		return;
 	}
-	maxent = XFS_DIR2_MAX_FREE_BESTS(mp);
+	maxent = xfs_dir2_free_max_bests(mp);
 	if (be32_to_cpu(free->hdr.firstdb) != xfs_dir2_da_to_db(mp, 
 					dabno - mp->m_dirfreeblk) * maxent) {
 		if (!sflag || v)
@@ -3643,10 +3645,10 @@ process_sf_dir_v2(
 	if (v)
 		dbprintf(_("dir %lld entry . %lld\n"), id->ino, id->ino);
 	(*dot)++;
-	sfe = xfs_dir2_sf_firstentry(sf);
+	sfe = xfs_dir2_sf_firstentry(&sf->hdr);
 	offset = XFS_DIR2_DATA_FIRST_OFFSET;
 	for (i = sf->hdr.count - 1, i8 = 0; i >= 0; i--) {
-		if ((__psint_t)sfe + xfs_dir2_sf_entsize_byentry(sf, sfe) -
+		if ((__psint_t)sfe + xfs_dir2_sf_entsize(&sf->hdr,sfe->namelen) -
 		    (__psint_t)sf > be64_to_cpu(dip->di_size)) {
 			if (!sflag)
 				dbprintf(_("dir %llu bad size in entry at %d\n"),
@@ -3655,7 +3657,7 @@ process_sf_dir_v2(
 			error++;
 			break;
 		}
-		lino = xfs_dir2_sf_get_inumber(sf, xfs_dir2_sf_inumberp(sfe));
+		lino = xfs_dir2_sfe_get_ino(&sf->hdr, sfe);
 		if (lino > XFS_DIR2_MAX_SHORT_INUM)
 			i8++;
 		cid = find_inode(lino, 1);
@@ -3685,8 +3687,8 @@ process_sf_dir_v2(
 		}
 		offset =
 			xfs_dir2_sf_get_offset(sfe) +
-			xfs_dir2_data_entsize(sfe->namelen);
-		sfe = xfs_dir2_sf_nextentry(sf, sfe);
+			xfs_dir2_sf_entsize(&sf->hdr, sfe->namelen);
+		sfe = xfs_dir2_sf_nextentry(&sf->hdr, sfe);
 	}
 	if (i < 0 && (__psint_t)sfe - (__psint_t)sf != 
 					be64_to_cpu(dip->di_size)) {
@@ -3702,7 +3704,7 @@ process_sf_dir_v2(
 			dbprintf(_("dir %llu offsets too high\n"), id->ino);
 		error++;
 	}
-	lino = xfs_dir2_sf_get_inumber(sf, &sf->hdr.parent);
+	lino = xfs_dir2_sf_get_parent_ino(&sf->hdr);
 	if (lino > XFS_DIR2_MAX_SHORT_INUM)
 		i8++;
 	cid = find_inode(lino, 1);
db/dir.h +6 -0
index 67e6689..5be82bf 100644
@@ -16,6 +16,12 @@
  * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
+/*
+ * only db understands v1 directory format, so include them
+ * directly here
+ */
+#include <xfs_dir1.h>
+
 extern const field_t	dir_flds[];
 extern const field_t	dir_hfld[];
 extern const field_t	dir_blkinfo_flds[];
db/dir2.c +5 -5
index 51c598b..be58639 100644
@@ -192,7 +192,7 @@ dir2_block_leaf_count(
 	block = obj;
 	if (be32_to_cpu(block->hdr.magic) != XFS_DIR2_BLOCK_MAGIC)
 		return 0;
-	btp = xfs_dir2_block_tail_p(mp, block);
+	btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 	return be32_to_cpu(btp->count);
 }
 
@@ -210,7 +210,7 @@ dir2_block_leaf_offset(
 	ASSERT(startoff == 0);
 	block = obj;
 	ASSERT(be32_to_cpu(block->hdr.magic) == XFS_DIR2_BLOCK_MAGIC);
-	btp = xfs_dir2_block_tail_p(mp, block);
+	btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 	lep = xfs_dir2_block_leaf_p(btp) + idx;
 	return bitize((int)((char *)lep - (char *)block));
 }
@@ -242,7 +242,7 @@ dir2_block_tail_offset(
 	ASSERT(idx == 0);
 	block = obj;
 	ASSERT(be32_to_cpu(block->hdr.magic) == XFS_DIR2_BLOCK_MAGIC);
-	btp = xfs_dir2_block_tail_p(mp, block);
+	btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 	return bitize((int)((char *)btp - (char *)block));
 }
 
@@ -264,7 +264,7 @@ dir2_block_u_count(
 	block = obj;
 	if (be32_to_cpu(block->hdr.magic) != XFS_DIR2_BLOCK_MAGIC)
 		return 0;
-	btp = xfs_dir2_block_tail_p(mp, block);
+	btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 	ptr = (char *)block->u;
 	endptr = (char *)xfs_dir2_block_leaf_p(btp);
 	for (i = 0; ptr < endptr; i++) {
@@ -297,7 +297,7 @@ dir2_block_u_offset(
 	ASSERT(startoff == 0);
 	block = obj;
 	ASSERT(be32_to_cpu(block->hdr.magic) == XFS_DIR2_BLOCK_MAGIC);
-	btp = xfs_dir2_block_tail_p(mp, block);
+	btp = xfs_dir2_block_tail_p(mp, &block->hdr);
 	ptr = (char *)block->u;
 	endptr = (char *)xfs_dir2_block_leaf_p(btp);
 	for (i = 0; i < idx; i++) {
db/dir2.h +32 -0
index dcf4787..4c2847b 100644
@@ -27,5 +27,37 @@ extern const field_t	dir2_leaf_entry_flds[];
 extern const field_t	dir2_leaf_hdr_flds[];
 extern const field_t	dir2_leaf_tail_flds[];
 
+/*
+ * generic dir2 structures used by xfs_db
+ */
+typedef union {
+	xfs_dir2_data_entry_t	entry;
+	xfs_dir2_data_unused_t	unused;
+} xfs_dir2_data_union_t;
+
+typedef struct xfs_dir2_data {
+	xfs_dir2_data_hdr_t	hdr;		/* magic XFS_DIR2_DATA_MAGIC */
+	xfs_dir2_data_union_t	u[1];
+} xfs_dir2_data_t;
+
+typedef struct xfs_dir2_block {
+	xfs_dir2_data_hdr_t	hdr;		/* magic XFS_DIR2_BLOCK_MAGIC */
+	xfs_dir2_data_union_t	u[1];
+	xfs_dir2_leaf_entry_t	leaf[1];
+	xfs_dir2_block_tail_t	tail;
+} xfs_dir2_block_t;
+
+typedef struct xfs_dir2_sf {
+	xfs_dir2_sf_hdr_t	hdr;		/* shortform header */
+	xfs_dir2_sf_entry_t	list[1];	/* shortform entries */
+} xfs_dir2_sf_t;
+
+static inline xfs_dir2_inou_t *xfs_dir2_sf_inumberp(xfs_dir2_sf_entry_t *sfep)
+{
+	return (xfs_dir2_inou_t *)&(sfep)->name[(sfep)->namelen];
+}
+
 extern int	dir2_data_union_size(void *obj, int startoff, int idx);
 extern int	dir2_size(void *obj, int startoff, int idx);
+
+
db/dir2sf.c +8 -7
index b2db088..92f8a66 100644
@@ -22,6 +22,7 @@
 #include "fprint.h"
 #include "field.h"
 #include "bit.h"
+#include "dir2.h"
 #include "dir2sf.h"
 
 static int	dir2_inou_i4_count(void *obj, int startoff);
@@ -149,10 +150,10 @@ dir2_sf_entry_size(
 
 	ASSERT(bitoffs(startoff) == 0);
 	sf = (xfs_dir2_sf_t *)((char *)obj + byteize(startoff));
-	e = xfs_dir2_sf_firstentry(sf);
+	e = xfs_dir2_sf_firstentry(&sf->hdr);
 	for (i = 0; i < idx; i++)
-		e = xfs_dir2_sf_nextentry(sf, e);
-	return bitize((int)xfs_dir2_sf_entsize_byentry(sf, e));
+		e = xfs_dir2_sf_nextentry(&sf->hdr, e);
+	return bitize((int)xfs_dir2_sf_entsize(&sf->hdr, e->namelen));
 }
 
 /*ARGSUSED*/
@@ -194,9 +195,9 @@ dir2_sf_list_offset(
 
 	ASSERT(bitoffs(startoff) == 0);
 	sf = (xfs_dir2_sf_t *)((char *)obj + byteize(startoff));
-	e = xfs_dir2_sf_firstentry(sf);
+	e = xfs_dir2_sf_firstentry(&sf->hdr);
 	for (i = 0; i < idx; i++)
-		e = xfs_dir2_sf_nextentry(sf, e);
+		e = xfs_dir2_sf_nextentry(&sf->hdr, e);
 	return bitize((int)((char *)e - (char *)sf));
 }
 
@@ -214,8 +215,8 @@ dir2sf_size(
 	ASSERT(bitoffs(startoff) == 0);
 	ASSERT(idx == 0);
 	sf = (xfs_dir2_sf_t *)((char *)obj + byteize(startoff));
-	e = xfs_dir2_sf_firstentry(sf);
+	e = xfs_dir2_sf_firstentry(&sf->hdr);
 	for (i = 0; i < sf->hdr.count; i++)
-		e = xfs_dir2_sf_nextentry(sf, e);
+		e = xfs_dir2_sf_nextentry(&sf->hdr, e);
 	return bitize((int)((char *)e - (char *)sf));
 }
db/dirshort.c +1 -0
index b0d3b6b..2b23c28 100644
@@ -22,6 +22,7 @@
 #include "fprint.h"
 #include "field.h"
 #include "bit.h"
+#include "dir.h"
 #include "dirshort.h"
 
 static int	dir_sf_entry_name_count(void *obj, int startoff);
db/metadump.c +12 -8
index 9f15d9e..5739f86 100644
@@ -26,6 +26,10 @@
 #include "init.h"
 #include "sig.h"
 #include "xfs_metadump.h"
+#include "fprint.h"
+#include "faddr.h"
+#include "field.h"
+#include "dir2.h"
 
 #define DEFAULT_MAX_EXT_SIZE	1000
 
@@ -916,7 +920,7 @@ obfuscate_sf_dir(
 					(long long)cur_ino);
 	}
 
-	sfep = xfs_dir2_sf_firstentry(sfp);
+	sfep = xfs_dir2_sf_firstentry(&sfp->hdr);
 	for (i = 0; (i < sfp->hdr.count) &&
 			((char *)sfep - (char *)sfp < ino_dir_size); i++) {
 
@@ -935,7 +939,7 @@ obfuscate_sf_dir(
 			namelen = ino_dir_size - ((char *)&sfep->name[0] -
 					 (char *)sfp);
 		} else if ((char *)sfep - (char *)sfp +
-				xfs_dir2_sf_entsize_byentry(sfp, sfep) >
+				xfs_dir2_sf_entsize(&sfp->hdr, sfep->namelen) >
 				ino_dir_size) {
 			if (show_warnings)
 				print_warning("entry length in dir inode %llu "
@@ -946,12 +950,11 @@ obfuscate_sf_dir(
 					 (char *)sfp);
 		}
 
-		generate_obfuscated_name(xfs_dir2_sf_get_inumber(sfp,
-				xfs_dir2_sf_inumberp(sfep)), namelen,
-				&sfep->name[0]);
+		generate_obfuscated_name(xfs_dir2_sfe_get_ino(&sfp->hdr, sfep),
+					 namelen, &sfep->name[0]);
 
 		sfep = (xfs_dir2_sf_entry_t *)((char *)sfep +
-				xfs_dir2_sf_entsize_byname(sfp, namelen));
+				xfs_dir2_sf_entsize(&sfp->hdr, namelen));
 	}
 }
 
@@ -1107,9 +1110,10 @@ obfuscate_dir_data_blocks(
 			if (is_block_format) {
 				xfs_dir2_leaf_entry_t	*blp;
 				xfs_dir2_block_tail_t	*btp;
+				xfs_dir2_block_t	*blk;
 
-				btp = xfs_dir2_block_tail_p(mp,
-						(xfs_dir2_block_t *)block);
+				blk = (xfs_dir2_block_t *)block;
+				btp = xfs_dir2_block_tail_p(mp, &blk->hdr);
 				blp = xfs_dir2_block_leaf_p(btp);
 				if ((char *)blp > (char *)btp)
 					blp = (xfs_dir2_leaf_entry_t *)btp;
estimate/xfs_estimate.c +3 -0
index 54a72e9..a8a3b99 100644
@@ -18,8 +18,11 @@
 
 /*
  * Estimate space of an XFS filesystem
+ *
+ * XXX: assumes dirv1 format.
  */
 #include <xfs/libxfs.h>
+#include <xfs_dir1.h>
 #include <sys/stat.h>
 #include <ftw.h>
 
fsr/xfs_fsr.c +1 -1
index 3d017ca..0471c55 100644
@@ -16,8 +16,8 @@
  * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
-#include <xfs/xfs.h>
 #include <libxfs.h>
+#include <xfs/xfs.h>
 #include <xfs/xfs_types.h>
 #include <xfs/jdm.h>
 #include <xfs/xfs_dfrag.h>
include/Makefile +3 -4
index 7ad6ddb..b94d305 100644
@@ -24,15 +24,14 @@ QAHFILES = libxfs.h libxlog.h \
 	xfs_ag.h xfs_alloc.h xfs_alloc_btree.h xfs_arch.h xfs_attr_leaf.h \
 	xfs_attr_sf.h xfs_bit.h xfs_bmap.h xfs_bmap_btree.h xfs_btree.h \
 	xfs_btree_trace.h xfs_buf_item.h xfs_da_btree.h xfs_dinode.h \
-	xfs_dir2.h xfs_dir2_block.h xfs_dir2_data.h xfs_dir2_leaf.h \
-	xfs_dir2_node.h xfs_dir2_sf.h xfs_dir_leaf.h xfs_dir_sf.h \
+	xfs_dir2.h xfs_dir2_format.h xfs_dir1.h xfs_dir_leaf.h xfs_dir_sf.h \
 	xfs_extfree_item.h xfs_ialloc.h xfs_ialloc_btree.h \
 	xfs_inode.h xfs_inode_item.h xfs_inum.h \
 	xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
 	xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h xfs_trace.h \
-	xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
+	xfs_trans.h xfs_trans_space.h xfs_dfrag.h
 
-HFILES = handle.h jdm.h xqm.h xfs.h xfs_fs.h
+HFILES = handle.h jdm.h xqm.h xfs.h xfs_fs.h xfs_types.h
 HFILES += $(PKG_PLATFORM).h
 PHFILES = darwin.h freebsd.h irix.h linux.h gnukfreebsd.h
 DKHFILES = volume.h fstyp.h dvh.h
include/libxfs.h +117 -26

287 lines not on this page · raw message

include/linux.h +1 -0
index e0bcba2..5bb91cd 100644
@@ -27,6 +27,7 @@
 #include <malloc.h>
 #include <getopt.h>
 #include <endian.h>
+#include <stdbool.h>
 
 static __inline__ int xfsctl(const char *path, int fd, int cmd, void *p)
 {
include/platform_defs.h.in +5 -0
index 4e1e0c4..217d6c0 100644
@@ -34,6 +34,7 @@
 #include <ctype.h>
 #include <sys/types.h>
 #include <limits.h>
+#include <stdbool.h>
 
 #undef HAVE___U32
 #ifdef HAVE___U32
@@ -57,6 +58,10 @@ typedef signed long long int	__s64;
 #define __force
 #endif
 
+typedef __u16	__bitwise	__le16;
+typedef __u32	__bitwise	__le32;
+typedef __u64	__bitwise	__le64;
+
 typedef __u16	__bitwise	__be16;
 typedef __u32	__bitwise	__be32;
 typedef __u64	__bitwise	__be64;
include/swab.h +38 -0
index 2684aa7..3de44d8 100644
@@ -153,4 +153,42 @@ static __inline__ void __swab64s(__u64 *addr)
 	(__extension__ ({__arch__swab64s(addr);}));
 }
 
+static inline __uint16_t get_unaligned_be16(void *p)
+{
+	__uint8_t *__p = p;
+	return __p[0] << 8 | __p[1];
+}
+
+static inline __uint32_t get_unaligned_be32(void *p)
+{
+	__uint8_t *__p = p;
+        return __p[0] << 24 | __p[1] << 16 | __p[2] << 8 | __p[3];
+}
+
+static inline __uint64_t get_unaligned_be64(void *p)
+{
+	return (__uint64_t)get_unaligned_be32(p) << 32 |
+			   get_unaligned_be32(p + 4);
+}
+
+static inline void put_unaligned_be16(__uint16_t val, void *p)
+{
+	__uint8_t *__p = p;
+	*__p++ = val >> 8;
+	*__p++ = val;
+}
+
+static inline void put_unaligned_be32(__uint32_t val, void *p)
+{
+	__uint8_t *__p = p;
+	put_unaligned_be16(val >> 16, __p);
+	put_unaligned_be16(val, __p + 2);
+}
+
+static inline void put_unaligned_be64(__uint64_t val, void *p)
+{
+	put_unaligned_be32(val >> 32, p);
+	put_unaligned_be32(val, p + 4);
+}
+
 #endif /* SWAB_H */
include/xfs.h +1 -0
index 147a5a0..e32c4a8 100644
@@ -34,6 +34,7 @@
 #define __XFS_H__
 
 #include <xfs/platform_defs.h>
+#include <xfs/xfs_types.h>
 #include <xfs/xfs_fs.h>
 
 #endif	/* __XFS_H__ */
include/xfs_ag.h +8 -21
index 5adce91..f2aeedb 100644
@@ -103,11 +103,13 @@ typedef struct xfs_agf {
 /* disk block (xfs_daddr_t) in the AG */
 #define XFS_AGF_DADDR(mp)	((xfs_daddr_t)(1 << (mp)->m_sectbb_log))
 #define	XFS_AGF_BLOCK(mp)	XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))
-#define	XFS_BUF_TO_AGF(bp)	((xfs_agf_t *)XFS_BUF_PTR(bp))
+#define	XFS_BUF_TO_AGF(bp)	((xfs_agf_t *)((bp)->b_addr))
 
 extern int xfs_read_agf(struct xfs_mount *mp, struct xfs_trans *tp,
 			xfs_agnumber_t agno, int flags, struct xfs_buf **bpp);
 
+extern const struct xfs_buf_ops xfs_agf_buf_ops;
+
 /*
  * Size of the unlinked inode hash table in the agi.
  */
@@ -156,11 +158,13 @@ typedef struct xfs_agi {
 /* disk block (xfs_daddr_t) in the AG */
 #define XFS_AGI_DADDR(mp)	((xfs_daddr_t)(2 << (mp)->m_sectbb_log))
 #define	XFS_AGI_BLOCK(mp)	XFS_HDR_BLOCK(mp, XFS_AGI_DADDR(mp))
-#define	XFS_BUF_TO_AGI(bp)	((xfs_agi_t *)XFS_BUF_PTR(bp))
+#define	XFS_BUF_TO_AGI(bp)	((xfs_agi_t *)((bp)->b_addr))
 
 extern int xfs_read_agi(struct xfs_mount *mp, struct xfs_trans *tp,
 				xfs_agnumber_t agno, struct xfs_buf **bpp);
 
+extern const struct xfs_buf_ops xfs_agi_buf_ops;
+
 /*
  * The third a.g. block contains the a.g. freelist, an array
  * of block pointers to blocks owned by the allocation btree code.
@@ -168,31 +172,13 @@ extern int xfs_read_agi(struct xfs_mount *mp, struct xfs_trans *tp,
 #define XFS_AGFL_DADDR(mp)	((xfs_daddr_t)(3 << (mp)->m_sectbb_log))
 #define	XFS_AGFL_BLOCK(mp)	XFS_HDR_BLOCK(mp, XFS_AGFL_DADDR(mp))
 #define XFS_AGFL_SIZE(mp)	((mp)->m_sb.sb_sectsize / sizeof(xfs_agblock_t))
-#define	XFS_BUF_TO_AGFL(bp)	((xfs_agfl_t *)XFS_BUF_PTR(bp))
+#define	XFS_BUF_TO_AGFL(bp)	((xfs_agfl_t *)((bp)->b_addr))
 
 typedef struct xfs_agfl {
 	__be32		agfl_bno[1];	/* actually XFS_AGFL_SIZE(mp) */
 } xfs_agfl_t;
 
 /*
- * Busy block/extent entry.  Indexed by a rbtree in perag to mark blocks that
- * have been freed but whose transactions aren't committed to disk yet.
- *
- * Note that we use the transaction ID to record the transaction, not the
- * transaction structure itself. See xfs_alloc_busy_insert() for details.
- */
-struct xfs_busy_extent {
-#ifdef __KERNEL__
-	struct rb_node	rb_node;	/* ag by-bno indexed search tree */
-#endif
-	struct list_head list;		/* transaction busy extent list */
-	xfs_agnumber_t	agno;
-	xfs_agblock_t	bno;
-	xfs_extlen_t	length;
-	xlog_tid_t	tid;		/* transaction that created this */
-};
-
-/*
  * Per-ag incore structure, copies of information in agf and agi,
  * to improve the performance of allocation group selection.
  */
@@ -251,6 +237,7 @@ typedef struct xfs_perag {
 #define XFS_ICI_NO_TAG		(-1)	/* special flag for an untagged lookup
 					   in xfs_inode_ag_iterator */
 #define XFS_ICI_RECLAIM_TAG	0	/* inode is to be reclaimed */
+#define XFS_ICI_EOFBLOCKS_TAG	1	/* inode has blocks beyond EOF */
 
 #define	XFS_AG_MAXLEVELS(mp)		((mp)->m_ag_maxlevels)
 #define	XFS_MIN_FREELIST_RAW(bl,cl,mp)	\
include/xfs_alloc.h +43 -14

82 lines not on this page · raw message

include/xfs_alloc_btree.h +2 -14
index a6caa00..7e89a2b 100644
@@ -51,20 +51,6 @@ typedef struct xfs_alloc_rec_incore {
 typedef __be32 xfs_alloc_ptr_t;
 
 /*
- * Minimum and maximum blocksize and sectorsize.
- * The blocksize upper limit is pretty much arbitrary.
- * The sectorsize upper limit is due to sizeof(sb_sectsize).
- */
-#define XFS_MIN_BLOCKSIZE_LOG	9	/* i.e. 512 bytes */
-#define XFS_MAX_BLOCKSIZE_LOG	16	/* i.e. 65536 bytes */
-#define XFS_MIN_BLOCKSIZE	(1 << XFS_MIN_BLOCKSIZE_LOG)
-#define XFS_MAX_BLOCKSIZE	(1 << XFS_MAX_BLOCKSIZE_LOG)
-#define XFS_MIN_SECTORSIZE_LOG	9	/* i.e. 512 bytes */
-#define XFS_MAX_SECTORSIZE_LOG	15	/* i.e. 32768 bytes */
-#define XFS_MIN_SECTORSIZE	(1 << XFS_MIN_SECTORSIZE_LOG)
-#define XFS_MAX_SECTORSIZE	(1 << XFS_MAX_SECTORSIZE_LOG)
-
-/*
  * Block numbers in the AG:
  * SB is sector 0, AGF is sector 1, AGI is sector 2, AGFL is sector 3.
  */
@@ -107,4 +93,6 @@ extern struct xfs_btree_cur *xfs_allocbt_init_cursor(struct xfs_mount *,
 		xfs_agnumber_t, xfs_btnum_t);
 extern int xfs_allocbt_maxrecs(struct xfs_mount *, int, int);
 
+extern const struct xfs_buf_ops xfs_allocbt_buf_ops;
+
 #endif	/* __XFS_ALLOC_BTREE_H__ */
include/xfs_attr_leaf.h +16 -11
index 9c7d22f..77de139 100644
@@ -31,7 +31,6 @@
 struct attrlist;
 struct attrlist_cursor_kern;
 struct xfs_attr_list_context;
-struct xfs_dabuf;
 struct xfs_da_args;
 struct xfs_da_state;
 struct xfs_da_state_blk;
@@ -215,7 +214,7 @@ int	xfs_attr_shortform_getvalue(struct xfs_da_args *args);
 int	xfs_attr_shortform_to_leaf(struct xfs_da_args *args);
 int	xfs_attr_shortform_remove(struct xfs_da_args *args);
 int	xfs_attr_shortform_list(struct xfs_attr_list_context *context);
-int	xfs_attr_shortform_allfit(struct xfs_dabuf *bp, struct xfs_inode *dp);
+int	xfs_attr_shortform_allfit(struct xfs_buf *bp, struct xfs_inode *dp);
 int	xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes);
 
 
@@ -223,7 +222,7 @@ int	xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes);
  * Internal routines when attribute fork size == XFS_LBSIZE(mp).
  */
 int	xfs_attr_leaf_to_node(struct xfs_da_args *args);
-int	xfs_attr_leaf_to_shortform(struct xfs_dabuf *bp,
+int	xfs_attr_leaf_to_shortform(struct xfs_buf *bp,
 				   struct xfs_da_args *args, int forkoff);
 int	xfs_attr_leaf_clearflag(struct xfs_da_args *args);
 int	xfs_attr_leaf_setflag(struct xfs_da_args *args);
@@ -235,14 +234,14 @@ int	xfs_attr_leaf_flipflags(xfs_da_args_t *args);
 int	xfs_attr_leaf_split(struct xfs_da_state *state,
 				   struct xfs_da_state_blk *oldblk,
 				   struct xfs_da_state_blk *newblk);
-int	xfs_attr_leaf_lookup_int(struct xfs_dabuf *leaf,
+int	xfs_attr_leaf_lookup_int(struct xfs_buf *leaf,
 					struct xfs_da_args *args);
-int	xfs_attr_leaf_getvalue(struct xfs_dabuf *bp, struct xfs_da_args *args);
-int	xfs_attr_leaf_add(struct xfs_dabuf *leaf_buffer,
+int	xfs_attr_leaf_getvalue(struct xfs_buf *bp, struct xfs_da_args *args);
+int	xfs_attr_leaf_add(struct xfs_buf *leaf_buffer,
 				 struct xfs_da_args *args);
-int	xfs_attr_leaf_remove(struct xfs_dabuf *leaf_buffer,
+int	xfs_attr_leaf_remove(struct xfs_buf *leaf_buffer,
 				    struct xfs_da_args *args);
-int	xfs_attr_leaf_list_int(struct xfs_dabuf *bp,
+int	xfs_attr_leaf_list_int(struct xfs_buf *bp,
 				      struct xfs_attr_list_context *context);
 
 /*
@@ -257,9 +256,15 @@ int	xfs_attr_root_inactive(struct xfs_trans **trans, struct xfs_inode *dp);
 /*
  * Utility routines.
  */
-xfs_dahash_t	xfs_attr_leaf_lasthash(struct xfs_dabuf *bp, int *count);
-int	xfs_attr_leaf_order(struct xfs_dabuf *leaf1_bp,
-				   struct xfs_dabuf *leaf2_bp);
+xfs_dahash_t	xfs_attr_leaf_lasthash(struct xfs_buf *bp, int *count);
+int	xfs_attr_leaf_order(struct xfs_buf *leaf1_bp,
+				   struct xfs_buf *leaf2_bp);
 int	xfs_attr_leaf_newentsize(int namelen, int valuelen, int blocksize,
 					int *local);
+int	xfs_attr_leaf_read(struct xfs_trans *tp, struct xfs_inode *dp,
+			xfs_dablk_t bno, xfs_daddr_t mappedbno,
+			struct xfs_buf **bpp);
+
+extern const struct xfs_buf_ops xfs_attr_leaf_buf_ops;
+
 #endif	/* __XFS_ATTR_LEAF_H__ */
include/xfs_bmap.h +72 -253

382 lines not on this page · raw message

include/xfs_bmap_btree.h +1 -0
index 0e66c4e..88469ca 100644
@@ -236,5 +236,6 @@ extern int xfs_bmbt_maxrecs(struct xfs_mount *, int blocklen, int leaf);
 extern struct xfs_btree_cur *xfs_bmbt_init_cursor(struct xfs_mount *,
 		struct xfs_trans *, struct xfs_inode *, int);
 
+extern const struct xfs_buf_ops xfs_bmbt_buf_ops;
 
 #endif	/* __XFS_BMAP_BTREE_H__ */
include/xfs_btree.h +20 -4
index 82fafc6..be1eb23 100644
@@ -188,6 +188,8 @@ struct xfs_btree_ops {
 	__int64_t (*key_diff)(struct xfs_btree_cur *cur,
 			      union xfs_btree_key *key);
 
+	const struct xfs_buf_ops	*buf_ops;
+
 #ifdef DEBUG
 	/* check that k1 is lower than k2 */
 	int	(*keys_inorder)(struct xfs_btree_cur *cur,
@@ -281,7 +283,7 @@ typedef struct xfs_btree_cur
 /*
  * Convert from buffer to btree block header.
  */
-#define	XFS_BUF_TO_BLOCK(bp)	((struct xfs_btree_block *)XFS_BUF_PTR(bp))
+#define	XFS_BUF_TO_BLOCK(bp)	((struct xfs_btree_block *)((bp)->b_addr))
 
 
 /*
@@ -374,7 +376,8 @@ xfs_btree_read_bufl(
 	xfs_fsblock_t		fsbno,	/* file system block number */
 	uint			lock,	/* lock flags for read_buf */
 	struct xfs_buf		**bpp,	/* buffer for fsbno */
-	int			refval);/* ref count value for buffer */
+	int			refval,	/* ref count value for buffer */
+	const struct xfs_buf_ops *ops);
 
 /*
  * Read-ahead the block, don't wait for it, don't return a buffer.
@@ -384,7 +387,8 @@ void					/* error */
 xfs_btree_reada_bufl(
 	struct xfs_mount	*mp,	/* file system mount point */
 	xfs_fsblock_t		fsbno,	/* file system block number */
-	xfs_extlen_t		count);	/* count of filesystem blocks */
+	xfs_extlen_t		count,	/* count of filesystem blocks */
+	const struct xfs_buf_ops *ops);
 
 /*
  * Read-ahead the block, don't wait for it, don't return a buffer.
@@ -395,8 +399,20 @@ xfs_btree_reada_bufs(
 	struct xfs_mount	*mp,	/* file system mount point */
 	xfs_agnumber_t		agno,	/* allocation group number */
 	xfs_agblock_t		agbno,	/* allocation group block number */
-	xfs_extlen_t		count);	/* count of filesystem blocks */
+	xfs_extlen_t		count,	/* count of filesystem blocks */
+	const struct xfs_buf_ops *ops);
 
+/*
+ * Initialise a new btree block header
+ */
+void
+xfs_btree_init_block(
+	struct xfs_mount *mp,
+	struct xfs_buf	*bp,
+	__u32		magic,
+	__u16		level,
+	__u16		numrecs,
+	unsigned int	flags);
 
 /*
  * Common btree core entry points.
include/xfs_buf_item.h +22 -33

91 lines not on this page · raw message

include/xfs_da_btree.h +14 -45

113 lines not on this page · raw message

include/xfs_dinode.h +2 -2
index dffba9b..1d9643b 100644
@@ -33,7 +33,7 @@ typedef struct xfs_timestamp {
  * variable size the leftover area split into a data and an attribute fork.
  * The format of the data and attribute fork depends on the format of the
  * inode as indicated by di_format and di_aformat.  To access the data and
- * attribute use the XFS_DFORK_PTR, XFS_DFORK_DPTR, and XFS_DFORK_PTR macros
+ * attribute use the XFS_DFORK_DPTR, XFS_DFORK_APTR, and XFS_DFORK_PTR macros
  * below.
  *
  * There is a very similar struct icdinode in xfs_inode which matches the
@@ -148,7 +148,7 @@ typedef enum xfs_dinode_fmt {
 		be32_to_cpu((dip)->di_nextents) : \
 		be16_to_cpu((dip)->di_anextents))
 
-#define	XFS_BUF_TO_DINODE(bp)	((xfs_dinode_t *)XFS_BUF_PTR(bp))
+#define	XFS_BUF_TO_DINODE(bp)	((xfs_dinode_t *)((bp)->b_addr))
 
 /*
  * For block and character special files the 32bit dev_t is stored at the
include/xfs_dir1.h new file +13 -0
new file mode 100644
index 0000000..d83537c
@@ -0,0 +1,13 @@
+#ifndef __XFS_DIRV1_H
+#define __XFS_DIRV1_H 1
+
+#if XFS_BIG_INUMS
+typedef xfs_ino_t	xfs_intino_t;
+#else
+typedef __uint32_t	xfs_intino_t;
+#endif
+
+#include <xfs_dir_sf.h>
+#include <xfs_dir_leaf.h>
+
+#endif /* __XFS_DIRV1_H */
include/xfs_dir2.h +42 -45

112 lines not on this page · raw message

include/xfs_dir2_block.h deleted +0 -92

92 lines not on this page · raw message

include/xfs_dir2_data.h deleted +0 -184

184 lines not on this page · raw message

include/xfs_dir2_format.h new file +597 -0

597 lines not on this page · raw message

include/xfs_dir2_leaf.h deleted +0 -253

253 lines not on this page · raw message

include/xfs_dir2_node.h deleted +0 -100

100 lines not on this page · raw message

include/xfs_dir2_sf.h deleted +0 -171

15 lines not on this page · raw message

include/xfs_fs.h +37 -1
index faac5af..1cc1aa0 100644

Lines of this file are not shown. View the raw message.

include/xfs_ialloc.h +4 -13
index bb53854..c8da3df 100644

Lines of this file are not shown. View the raw message.

include/xfs_ialloc_btree.h +2 -0
index f782ad0..25c0239 100644

Lines of this file are not shown. View the raw message.

include/xfs_inode.h +116 -115

231 lines not on this page · raw message

include/xfs_inode_item.h +13 -9
index d3dee61..779812f 100644

Lines of this file are not shown. View the raw message.

include/xfs_inum.h +0 -16
index b8e4ee4..90efdaf 100644

Lines of this file are not shown. View the raw message.

include/xfs_log.h +10 -21
index 916eb7d..5caee96 100644

Lines of this file are not shown. View the raw message.

include/xfs_log_priv.h +62 -39

101 lines not on this page · raw message

include/xfs_mount.h +16 -24
index 9be9a05..c267379 100644

Lines of this file are not shown. View the raw message.

include/xfs_quota.h +28 -19

47 lines not on this page · raw message

include/xfs_rtalloc.h +2 -2
index ff614c2..f7f3a35 100644

Lines of this file are not shown. View the raw message.

include/xfs_sb.h +8 -2
index 5dcc2d7..6a7f8b0 100644

Lines of this file are not shown. View the raw message.

include/xfs_trace.h +67 -2

69 lines not on this page · raw message

include/xfs_trans.h +58 -30

88 lines not on this page · raw message

include/xfs_types.h +21 -3
index 26d1867..e9bd5c3 100644

Lines of this file are not shown. View the raw message.

libxfs/Makefile +1 -1
index b3fd85c..dc9b22c 100644

Lines of this file are not shown. View the raw message.

libxfs/init.c +0 -3
index 08fc584..1b11fb0 100644

Lines of this file are not shown. View the raw message.

libxfs/logitem.c +13 -7
index 116d3ed..84e4c14 100644

Lines of this file are not shown. View the raw message.

libxfs/rdwr.c +314 -95

409 lines not on this page · raw message

libxfs/trans.c +23 -27

50 lines not on this page · raw message

libxfs/util.c +15 -187

202 lines not on this page · raw message

libxfs/xfs.h +61 -47

108 lines not on this page · raw message

libxfs/xfs_alloc.c +369 -221

590 lines not on this page · raw message

libxfs/xfs_alloc_btree.c +89 -16

105 lines not on this page · raw message

libxfs/xfs_attr.c +123 -136

259 lines not on this page · raw message

libxfs/xfs_attr_leaf.c +298 -197

495 lines not on this page · raw message

libxfs/xfs_bmap.c +1739 -1460

3,199 lines not on this page · raw message

libxfs/xfs_bmap_btree.c +66 -5

71 lines not on this page · raw message

libxfs/xfs_btree.c +81 -107

188 lines not on this page · raw message

libxfs/xfs_da_btree.c +600 -678

1,278 lines not on this page · raw message

libxfs/xfs_dir2.c +27 -122

149 lines not on this page · raw message

libxfs/xfs_dir2_block.c +380 -329

709 lines not on this page · raw message

libxfs/xfs_dir2_data.c +308 -198

506 lines not on this page · raw message

libxfs/xfs_dir2_leaf.c +409 -311

720 lines not on this page · raw message

libxfs/xfs_dir2_node.c +345 -377

722 lines not on this page · raw message

libxfs/xfs_dir2_priv.h new file +152 -0

152 lines not on this page · raw message

libxfs/xfs_dir2_sf.c +192 -128

320 lines not on this page · raw message

libxfs/xfs_ialloc.c +309 -277

586 lines not on this page · raw message

libxfs/xfs_ialloc_btree.c +54 -1

55 lines not on this page · raw message

libxfs/xfs_inode.c +225 -183

408 lines not on this page · raw message

libxfs/xfs_mount.c +175 -1

176 lines not on this page · raw message

libxfs/xfs_rtalloc.c +32 -45

77 lines not on this page · raw message

libxfs/xfs_trans.c +3 -6
index 7249196..bdd0ebc 100644

Lines of this file are not shown. View the raw message.

logprint/log_misc.c +2 -1
index 2e3dbdf..8e72788 100644

Lines of this file are not shown. View the raw message.

logprint/log_print_all.c +1 -1
index 69d6e71..cbc51d9 100644

Lines of this file are not shown. View the raw message.

mkfs/proto.c +5 -5
index 3021028..56eed31 100644

Lines of this file are not shown. View the raw message.

repair/dir.c +1 -0
index 01c8f10..daca17d 100644

Lines of this file are not shown. View the raw message.

repair/dir2.c +93 -241

334 lines not on this page · raw message

repair/dir2.h +27 -1
index a88579f..63e35d4 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +74 -81

155 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-kernel-3.9-rc1-dev-update0000600000175000017500000110727512132011546022356 0ustar davedavexfsprogs: update libxfs to 3.9-rc1 + xfsdev

From: Dave Chinner <[email protected]>

Update the code from 3.8-rc2 to 3.9-rc1 and the current xfs-dev tree (to pick up xfs_bmap.c rework).

---
 db/check.c              |    3 +-
 db/metadump.c           |    3 +-
 include/libxfs.h        |    2 +-
 include/xfs_dinode.h    |    6 +-
 include/xfs_inode.h     |    6 +-
 include/xfs_mount.h     |    7 +-
 include/xfs_types.h     |    1 -
 libxfs/xfs.h            |    4 +-
 libxfs/xfs_alloc.c      |    2 +-
 libxfs/xfs_attr.c       |    1 +
 libxfs/xfs_attr_leaf.c  |    6 +-
 libxfs/xfs_bmap.c       | 8388 +++++++++++++++++++++++------------------------
 libxfs/xfs_dir2_block.c |    6 +-
 libxfs/xfs_ialloc.c     |    6 +-
 libxfs/xfs_inode.c      |    1 +
 libxfs/xfs_mount.c      |    2 +-
 repair/dinode.c         |    8 +-
 repair/prefetch.c       |    2 +-
 18 files changed, 4218 insertions(+), 4236 deletions(-)
db/check.c +2 -1
index f1cec8f..1dfef74 100644

Lines of this file are not shown. View the raw message.

db/metadump.c +2 -1
index 5739f86..0635e7b 100644

Lines of this file are not shown. View the raw message.

include/libxfs.h +1 -1
index 0e2fc5f..b60bcf5 100644

Lines of this file are not shown. View the raw message.

include/xfs_dinode.h +3 -3
index 1d9643b..88a3368 100644

Lines of this file are not shown. View the raw message.

include/xfs_inode.h +4 -2
index 437b3af..4733f85 100644

Lines of this file are not shown. View the raw message.

include/xfs_mount.h +6 -1
index c267379..28bbf46 100644

Lines of this file are not shown. View the raw message.

include/xfs_types.h +0 -1
index e9bd5c3..dd6bf71 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +2 -2
index 6213284..9fbe261 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc.c +1 -1
index 61cdc6c..e59fdac 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr.c +1 -0
index 42546a9..2adf92b 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_leaf.c +4 -2
index 824c122..426130f 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_bmap.c +4175 -4213

8,388 lines not on this page · raw message

libxfs/xfs_dir2_block.c +4 -2
index 7397faa..2a99dea 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc.c +5 -1
index 529d92d..f0322c9 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_inode.c +1 -0
index 2970f46..3cf2423 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_mount.c +1 -1
index a9155b3..b7514fb 100644

Lines of this file are not shown. View the raw message.

repair/dinode.c +5 -3
index 5a2da39..f564216 100644

Lines of this file are not shown. View the raw message.

repair/prefetch.c +1 -1
index c0b1002..e0eff96 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-crc-infrastructure0000600000175000017500000015574612132011546021702 0ustar davedavexfsprogs: add CRC32c infrastructure

From: Dave Chinner <[email protected]>

Pull the generic crc32(c) code from the kernel and add it to libxfs. Modify it to build in the libxfs environment, and drop the bigendian CRC version as it is unused by XFS, which uses the little endian version so that it can be hardware accelerated using native instructions on x86-64 CPUs.

Also wire up the self-test code in the crc32 module to the build infrastructure and make passing the self test a build dependency. This prevents xfsprogs from being built on platforms that the CRC algorithm does not work on and hence ensures the tools do not write bad CRCs to disk as a result of a broken calculation.

Also pull the XFS CRC helper functions across in preparation for using the CRC functions in libxfs.

XXX: something in the CRC table generation breaks the debian package build. It fails to build libxfs as a dependency of mkfs.xfs. Works fine outside the debian build environment, so I'm not sure what the issue is yet. Most likely it is the execution path of the gen_crc32table binary that is built...

---
 include/Makefile        |    6 +-
 include/libxfs.h        |   10 +
 include/xfs_arch.h      |   16 +
 include/xfs_cksum.h     |   63 +++
 libxfs/Makefile         |   26 +-
 libxfs/crc32.c          | 1036 +++++++++++++++++++++++++++++++++++++++++++++++
 libxfs/crc32defs.h      |   72 ++++
 libxfs/gen_crc32table.c |  144 +++++++
 8 files changed, 1367 insertions(+), 6 deletions(-)
include/Makefile +3 -3
index de2c4f0..9ed5077 100644

Lines of this file are not shown. View the raw message.

include/libxfs.h +10 -0
index 0e2fc5f..e671391 100644

Lines of this file are not shown. View the raw message.

include/xfs_arch.h +16 -0
index 0902249..d5e591a 100644

Lines of this file are not shown. View the raw message.

include/xfs_cksum.h new file +63 -0

63 lines not on this page · raw message

libxfs/Makefile +23 -3
index dc9b22c..28f71c8 100644

Lines of this file are not shown. View the raw message.

libxfs/crc32.c new file +1036 -0

1,036 lines not on this page · raw message

libxfs/crc32defs.h new file +72 -0

72 lines not on this page · raw message

libxfs/gen_crc32table.c new file +144 -0

144 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-libxlog-kernel-sync0000600000175000017500000006635212132011546021737 0ustar davedavexfsprogs: updata libxlog to current kernel code

From: Dave Chinner <[email protected]>

Update the log recovery code to match the current 3.8-rc2 kernel code.

Note: while this introduces CRC validation infrastructure, it is currently short-circuited as we cannot validate the CRC from userspace because we do not know what the size of the log buffer was that wrote the header. This information is not written into the log header anywhere, so we have no way of working out the correct number of extra headers that need to be summed. This is also a problem for the kernel code, and needs fixing.

---
 db/sb.c                    |    7 +-
 include/libxlog.h          |   32 ++---
 libxlog/xfs_log_recover.c  |  301 +++++++++++++++++++++++++++-----------------
 logprint/log_copy.c        |    2 +-
 logprint/log_dump.c        |    2 +-
 logprint/log_misc.c        |    4 +-
 logprint/log_print_all.c   |    2 +-
 logprint/log_print_trans.c |    4 +-
 logprint/logprint.c        |    2 +-
 logprint/logprint.h        |   10 +-
 repair/phase2.c            |    7 +-
 11 files changed, 229 insertions(+), 144 deletions(-)
db/sb.c +5 -2
index 21f38c5..d83db9c 100644

Lines of this file are not shown. View the raw message.

include/libxlog.h +18 -14
index d1142ab..36ede59 100644

Lines of this file are not shown. View the raw message.

libxlog/xfs_log_recover.c +188 -113

301 lines not on this page · raw message

logprint/log_copy.c +1 -1
index fd36317..f6ef0e9 100644

Lines of this file are not shown. View the raw message.

logprint/log_dump.c +1 -1
index 1975b1b..a333077 100644

Lines of this file are not shown. View the raw message.

logprint/log_misc.c +2 -2
index c480795..4277a48 100644

Lines of this file are not shown. View the raw message.

logprint/log_print_all.c +1 -1
index cbc51d9..44fb4c4 100644

Lines of this file are not shown. View the raw message.

logprint/log_print_trans.c +2 -2
index 7405772..86e1c42 100644

Lines of this file are not shown. View the raw message.

logprint/logprint.c +1 -1
index 482fd4e..2a01780 100644

Lines of this file are not shown. View the raw message.

logprint/logprint.h +5 -5
index df4cea3..933c9e6 100644

Lines of this file are not shown. View the raw message.

repair/phase2.c +5 -2
index 9fd591c..23b457a 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/btree-format-changes0000600000175000017500000015372112132011546020170 0ustar davedavelibxfs: add crc format changes to generic btrees

From: Dave Chinner <[email protected]>

---
 include/libxfs.h           |   15 +--
 include/xfs_alloc_btree.h  |   13 ++-
 include/xfs_bmap_btree.h   |   20 ++--
 include/xfs_btree.h        |   60 +++++++++--
 include/xfs_buf_item.h     |   24 ++++-
 include/xfs_dinode.h       |    4 +-
 include/xfs_ialloc_btree.h |   10 +-
 include/xfs_trans.h        |    2 +
 libxfs/rdwr.c              |   24 ++---
 libxfs/xfs.h               |    4 +
 libxfs/xfs_alloc_btree.c   |   99 +++++++++++------
 libxfs/xfs_attr_leaf.c     |    2 +-
 libxfs/xfs_bmap.c          |   49 ++++++---
 libxfs/xfs_bmap_btree.c    |  107 ++++++++++++------
 libxfs/xfs_btree.c         |  257 ++++++++++++++++++++++++++++++++++++--------
 libxfs/xfs_ialloc_btree.c  |   80 +++++++++-----
 libxfs/xfs_inode.c         |   33 +++---
 libxfs/xfs_mount.c         |    2 +-
 mdrestore/Makefile         |    2 +-
 19 files changed, 587 insertions(+), 220 deletions(-)
include/libxfs.h +9 -6
index b6e83f4..a4564fd 100644

Lines of this file are not shown. View the raw message.

include/xfs_alloc_btree.h +8 -5
index 7e89a2b..70c3ea0 100644

Lines of this file are not shown. View the raw message.

include/xfs_bmap_btree.h +11 -9
index 88469ca..8a28b89 100644

Lines of this file are not shown. View the raw message.

include/xfs_btree.h +51 -9

60 lines not on this page · raw message

include/xfs_buf_item.h +19 -5
index ee36c88..101ef83 100644

Lines of this file are not shown. View the raw message.

include/xfs_dinode.h +2 -2
index 88a3368..6b5bd17 100644

Lines of this file are not shown. View the raw message.

include/xfs_ialloc_btree.h +6 -4
index 25c0239..a1bfa7a 100644

Lines of this file are not shown. View the raw message.

include/xfs_trans.h +2 -0
index acf1381..a9bd826 100644

Lines of this file are not shown. View the raw message.

libxfs/rdwr.c +12 -12
index e75edd0..e9cc7b1 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +4 -0
index 9fbe261..b3b45bb 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc_btree.c +67 -32

99 lines not on this page · raw message

libxfs/xfs_attr_leaf.c +1 -1
index 426130f..85cb31d 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_bmap.c +32 -17

49 lines not on this page · raw message

libxfs/xfs_bmap_btree.c +76 -31

107 lines not on this page · raw message

libxfs/xfs_btree.c +212 -45

257 lines not on this page · raw message

libxfs/xfs_ialloc_btree.c +56 -24

80 lines not on this page · raw message

libxfs/xfs_inode.c +17 -16
index 3cf2423..f9f792c 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_mount.c +1 -1
index b7514fb..7ab3519 100644

Lines of this file are not shown. View the raw message.

mdrestore/Makefile +1 -1
index ca2d1a0..5171306 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/ag-hdr-format-changes0000600000175000017500000004304512132011546020226 0ustar davedavexfsprogs: add crc format chagnes to ag headers

From: Dave Chinner <[email protected]>

---
 include/xfs_ag.h       |   54 ++++-
 include/xfs_buf_item.h |    8 +-
 libxfs/xfs_alloc.c     |  197 ++++++++++-----
 libxfs/xfs_bmap.c      |  625 +++++++++++++++++++++++++++++++++++++++++++++++-
 libxfs/xfs_ialloc.c    |   55 +++--
 5 files changed, 851 insertions(+), 88 deletions(-)
include/xfs_ag.h +51 -3

54 lines not on this page · raw message

include/xfs_buf_item.h +7 -1
index 101ef83..c256606 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc.c +132 -65

197 lines not on this page · raw message

libxfs/xfs_ialloc.c +41 -14

55 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/quota-format-changes0000600000175000017500000000217312132011546020212 0ustar davedavelibxfs: change quota buffer formats

From: Dave Chinner <[email protected]>

---
 include/xfs_quota.h |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
include/xfs_quota.h +10 -1
index b50ec5b..c61e31c 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/inode-v30000600000175000017500000005021012132011546015604 0ustar davedavelibxfs: add version 3 inode support

From: Dave Chinner <[email protected]>

Header from folded patch 'debug':

xfs_quota: fix report command parsing

From: Dave Chinner <[email protected]>

The report command line needs to be parsed as a whole not as individual elements - report_f() is set up to do this correctly. When treated as non-global command line, the report function is called once for each command line arg, resulting in reports being issued multiple times.

Set the command to be a global command so that it is only called once.

---
 db/dir2sf.c              |    9 +++--
 include/xfs_buf_item.h   |    4 +-
 include/xfs_dinode.h     |   33 +++++++++++++++--
 include/xfs_inode.h      |   26 +++++++++++++
 libxfs/trans.c           |    1 +
 libxfs/util.c            |   30 ++++++++++++++-
 libxfs/xfs_ialloc.c      |   25 ++++++++++++-
 libxfs/xfs_inode.c       |   91 ++++++++++++++++++++++++++++++++++++++++------
 logprint/log_misc.c      |    2 +-
 logprint/log_print_all.c |    3 +-
 repair/phase6.c          |   63 +++++++++++++++++++++++++++++---
 11 files changed, 257 insertions(+), 30 deletions(-)
db/dir2sf.c +6 -3
index 92f8a66..271e08a 100644

Lines of this file are not shown. View the raw message.

include/xfs_buf_item.h +3 -1
index c256606..abae8c8 100644

Lines of this file are not shown. View the raw message.

include/xfs_dinode.h +29 -4
index 6b5bd17..f7a0e95 100644

Lines of this file are not shown. View the raw message.

include/xfs_inode.h +26 -0
index 4733f85..cc14743 100644

Lines of this file are not shown. View the raw message.

libxfs/trans.c +1 -0
index 7cb3c8c..619aad1 100644

Lines of this file are not shown. View the raw message.

libxfs/util.c +29 -1
index 2ad4bfd..abe16cf 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc.c +23 -2
index feb4a4e..008c4ea 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_inode.c +80 -11

91 lines not on this page · raw message

logprint/log_misc.c +1 -1
index 94fcf5b..ffc6916 100644

Lines of this file are not shown. View the raw message.

logprint/log_print_all.c +2 -1
index 44fb4c4..5b2d942 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +57 -6

63 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/remote-symlink-crc0000600000175000017500000001701312132011546017710 0ustar davedavelibxfs: add support for crc headers on remote symlinks

From: Dave Chinner <[email protected]>

---
 include/Makefile       |    4 +-
 include/libxfs.h       |    1 +
 include/xfs_buf_item.h |    4 +-
 include/xfs_symlink.h  |   43 ++++++++++++++
 libxfs/Makefile        |    2 +-
 libxfs/xfs_symlink.c   |  154 ++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 204 insertions(+), 4 deletions(-)
include/Makefile +2 -2
index 61b30a8..b1c685d 100644

Lines of this file are not shown. View the raw message.

include/libxfs.h +1 -0
index a4564fd..41cb585 100644

Lines of this file are not shown. View the raw message.

include/xfs_buf_item.h +3 -1
index abae8c8..09cab4e 100644

Lines of this file are not shown. View the raw message.

include/xfs_symlink.h new file +43 -0

43 lines not on this page · raw message

libxfs/Makefile +1 -1
index 28f71c8..75f365c 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_symlink.c new file +154 -0

154 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-dir2-block-20000600000175000017500000010077712132011546020776 0ustar davedavexfs: add CRC checks to block format directory blocks

From: Dave Chinner <[email protected]>

Now that directory buffers are made from a single struct xfs_buf, we can add CRC calculation and checking callbacks. While there, add all the fields to the on disk structures for future functionality such as d_type support, uuids, block numbers, owner inode, etc.

To distinguish between the different on disk formats, change the magic numbers for the new format directory blocks.

---
 include/xfs_dir2_format.h |  155 +++++++++++++++++++++++++++++++++++++++++--
 libxfs/xfs_dir2_block.c   |  126 +++++++++++++++++++++++++----------
 libxfs/xfs_dir2_data.c    |  160 ++++++++++++++++++++++++++++-----------------
 libxfs/xfs_dir2_leaf.c    |    6 +-
 libxfs/xfs_dir2_node.c    |    2 +-
 libxfs/xfs_dir2_priv.h    |    4 +-
 libxfs/xfs_dir2_sf.c      |    2 +-
 7 files changed, 346 insertions(+), 109 deletions(-)
include/xfs_dir2_format.h +149 -6

155 lines not on this page · raw message

libxfs/xfs_dir2_block.c +90 -36

126 lines not on this page · raw message

libxfs/xfs_dir2_data.c +99 -61

160 lines not on this page · raw message

libxfs/xfs_dir2_leaf.c +4 -2
index d303813..d83fce4 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_node.c +1 -1
index 649f677..e7820b2 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_priv.h +2 -2
index 7da79f6..e6f2e0a 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_sf.c +1 -1
index a96be76..6848d05 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-dir2-free-20000600000175000017500000007172712132011546020627 0ustar davedavexfs: add CRC checking to dir2 free blocks

From: Dave Chinner <[email protected]>

This addition follows the same pattern as the dir2 block CRCs, but with a few differences. The main difference is that the free block header is different between the v2 and v3 formats, so an "in-core" free block header has been added and _todisk/_from_disk functions used to abstract the differences in structure format from the code. This is similar to the on-disk superblock versus the in-core superblock setup. The in-core strucutre is populated when the buffer is read from disk, all the in memory checks and modifications are done on the in-core version of the structure which is written back to the buffer before the buffer is logged.

---
 db/check.c                |    2 +-
 include/xfs_dir2_format.h |   55 +++++-
 libxfs/xfs_dir2_leaf.c    |   15 +-
 libxfs/xfs_dir2_node.c    |  474 ++++++++++++++++++++++++++++++---------------
 repair/phase6.c           |    2 +-
 5 files changed, 384 insertions(+), 164 deletions(-)
db/check.c +1 -1
index 1dfef74..368d2b7 100644

Lines of this file are not shown. View the raw message.

include/xfs_dir2_format.h +51 -4

55 lines not on this page · raw message

libxfs/xfs_dir2_leaf.c +8 -7
index d83fce4..a1df347 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_node.c +323 -151

474 lines not on this page · raw message

repair/phase6.c +1 -1
index 136bb4f..80701a4 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-dir2-data-20000600000175000017500000006031012132011546020601 0ustar davedavexfs: add CRC checking to dir2 data blocks

From: Dave Chinner <[email protected]>

This addition follows the same pattern as the dir2 block CRCs.

---
 include/xfs_dir2_format.h |   21 +++++-----
 libxfs/xfs_dir2_block.c   |   20 ++++-----
 libxfs/xfs_dir2_data.c    |   98 +++++++++++++++++++++++++++++++--------------
 libxfs/xfs_dir2_leaf.c    |   59 ++++++++++++++++-----------
 libxfs/xfs_dir2_node.c    |   39 ++++++++++--------
 libxfs/xfs_dir2_priv.h    |   12 +++---
 6 files changed, 152 insertions(+), 97 deletions(-)
include/xfs_dir2_format.h +9 -12
index bec058f..dfc8ccf 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_block.c +11 -9
index 9978a02..e1e1161 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_data.c +68 -30

98 lines not on this page · raw message

libxfs/xfs_dir2_leaf.c +35 -24

59 lines not on this page · raw message

libxfs/xfs_dir2_node.c +23 -16
index 0edaddc..9dda757 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_priv.h +6 -6
index e6f2e0a..910e644 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-dir2-leaf-30000600000175000017500000026266012132011546020614 0ustar davedavexfs: add CRC checking to dir2 leaf blocks

From: Dave Chinner <[email protected]>

This addition follows the same pattern as the dir2 block CRCs. Seeing as both LEAF1 and LEAFN types need to changed at the same time, this is a pretty large amount of change. leaf block headers need to be abstracted away from the on-disk structures (struct xfs_dir3_icleaf_hdr), as do the base leaf entry locations.

This header abstract allows the in-core header and leaf entry location to be passed around instead of the leaf block itself. This saves a lot of converting individual variables from on-disk format to host format where they are used, so there's a good chance that the compiler will be able to produce much more optimal code as it's not having to byteswap variables all over the place.

---
 db/check.c                |    2 +-
 db/dir2.c                 |    2 +-
 include/xfs_da_btree.h    |   23 ++
 include/xfs_dir2_format.h |   60 +++-
 libxfs/xfs_da_btree.c     |   45 ++-
 libxfs/xfs_dir2_block.c   |   19 +-
 libxfs/xfs_dir2_leaf.c    |  786 ++++++++++++++++++++++++++++-----------------
 libxfs/xfs_dir2_node.c    |  475 +++++++++++++++------------
 libxfs/xfs_dir2_priv.h    |   32 +-
 repair/dir2.c             |   12 +-
 repair/phase6.c           |   14 +-
 11 files changed, 938 insertions(+), 532 deletions(-)
db/check.c +1 -1
index 368d2b7..73d9da2 100644

Lines of this file are not shown. View the raw message.

db/dir2.c +1 -1
index be58639..abdbfee 100644

Lines of this file are not shown. View the raw message.

include/xfs_da_btree.h +23 -0
index ee5170c..0854b95 100644

Lines of this file are not shown. View the raw message.

include/xfs_dir2_format.h +53 -7

60 lines not on this page · raw message

libxfs/xfs_da_btree.c +35 -10

45 lines not on this page · raw message

libxfs/xfs_dir2_block.c +12 -7
index 18eabd1..b98b749 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_leaf.c +500 -286

786 lines not on this page · raw message

libxfs/xfs_dir2_node.c +277 -198

475 lines not on this page · raw message

libxfs/xfs_dir2_priv.h +20 -12
index 910e644..932565d 100644

Lines of this file are not shown. View the raw message.

repair/dir2.c +7 -5
index c455c83..a48971f 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +9 -5
index 80701a4..243b808 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/dir2-sf0000600000175000017500000001216312132011546015433 0ustar davedavexfs: shortform directory offsets change for dir3 format

From: Dave Chinner <[email protected]>

Because the header size for the CRC enabled directory blocks is larger, the offset of the first entry into a directory block is different to the dir2 format. The shortform directory stores the dirent's offset so that it doesn't change when moving from shortform to block form and back again, and hence it needs to take into account the different header sizes to maintain the correct offsets.

---
 db/check.c                |    2 +-
 include/xfs_dir2_format.h |   25 ++++++++++++++-----------
 libxfs/xfs_dir2_sf.c      |    6 +++---
 repair/dir2.c             |    7 ++++---
 4 files changed, 22 insertions(+), 18 deletions(-)
db/check.c +1 -1
index 73d9da2..69cfbdb 100644

Lines of this file are not shown. View the raw message.

include/xfs_dir2_format.h +14 -11
index 8bb4efe..8d33f03 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_sf.c +3 -3
index 6848d05..cb23368 100644

Lines of this file are not shown. View the raw message.

repair/dir2.c +4 -3
index 6b7c8d7..de5e737 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-da-node0000600000175000017500000033255712132011546020221 0ustar davedavexfs: add CRCs to dir2/da node blocks

From: Dave Chinner <[email protected]>

---
 db/attr.c              |    4 +-
 db/check.c             |    8 +-
 db/dir.c               |    4 +-
 db/dir2.c              |    2 +-
 include/xfs_da_btree.h |  106 +++-
 libxfs/xfs_attr.c      |   24 +-
 libxfs/xfs_attr_leaf.c |   17 +-
 libxfs/xfs_da_btree.c  | 1393 +++++++++++++++++++++++++++++-------------------
 libxfs/xfs_dir2_node.c |   26 +-
 repair/dir.c           |   87 +--
 repair/dir2.c          |   96 ++--
 repair/phase6.c        |    6 +-
 12 files changed, 1070 insertions(+), 703 deletions(-)
db/attr.c +2 -2
index 74bf411..a5087b8 100644

Lines of this file are not shown. View the raw message.

db/check.c +4 -4
index 69cfbdb..efbd0c9 100644

Lines of this file are not shown. View the raw message.

db/dir.c +2 -2
index 4b7e9dc..70ecc46 100644

Lines of this file are not shown. View the raw message.

db/dir2.c +1 -1
index abdbfee..07809b0 100644

Lines of this file are not shown. View the raw message.

include/xfs_da_btree.h +83 -23

106 lines not on this page · raw message

libxfs/xfs_attr.c +12 -12
index 2adf92b..bb2ccf2 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_leaf.c +9 -8
index 85cb31d..cb37198 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_da_btree.c +840 -553

1,393 lines not on this page · raw message

libxfs/xfs_dir2_node.c +13 -13
index edf6e03..c1c50ad 100644

Lines of this file are not shown. View the raw message.

repair/dir.c +48 -39

87 lines not on this page · raw message

repair/dir2.c +52 -44

96 lines not on this page · raw message

repair/phase6.c +4 -2
index e3d0934..090e400 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-attr-leaf0000600000175000017500000033071412132011546020562 0ustar davedavexfs: add CRCs to attr leaf blocks

From: Dave Chinner <[email protected]>

---
 db/attr.c               |   16 +-
 db/dir.c                |    4 +-
 db/dir2.c               |    2 +-
 db/metadump.c           |    4 +-
 include/xfs_attr_leaf.h |  122 +++-
 include/xfs_da_btree.h  |    5 +-
 libxfs/xfs_attr.c       |   66 +-
 libxfs/xfs_attr_leaf.c  | 1529 +++++++++++++++++++++++++++--------------------
 libxfs/xfs_da_btree.c   |   34 +-
 repair/attr_repair.c    |    4 +-
 10 files changed, 1034 insertions(+), 752 deletions(-)
db/attr.c +8 -8
index a5087b8..05049ba 100644

Lines of this file are not shown. View the raw message.

db/dir.c +2 -2
index 70ecc46..a9b1654 100644

Lines of this file are not shown. View the raw message.

db/dir2.c +1 -1
index 07809b0..2cbc22a 100644

Lines of this file are not shown. View the raw message.

db/metadump.c +2 -2
index 0635e7b..44e7162 100644

Lines of this file are not shown. View the raw message.

include/xfs_attr_leaf.h +95 -27

122 lines not on this page · raw message

include/xfs_da_btree.h +3 -2
index 6bedb3c..0e8182c 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr.c +33 -33

66 lines not on this page · raw message

libxfs/xfs_attr_leaf.c +868 -661

1,529 lines not on this page · raw message

libxfs/xfs_da_btree.c +20 -14
index 3176626..ea16bee 100644

Lines of this file are not shown. View the raw message.

repair/attr_repair.c +2 -2
index ec7f4a3..033b7fe 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-attr-rmt-move0000600000175000017500000004764212132011546017513 0ustar davedavexfs: split remote attribute code out

From: Dave Chinner <[email protected]>

Adding CRC support to remote attributes adds a significant amount of remote attribute specific code. Split the existing remote attribute code out into it's own file so that all the relevant remote attribute code is in a single, easy to find place.

---
 include/libxfs.h                     |    1 +
 include/{xfs.h => xfs_attr_remote.h} |   23 +--
 libxfs/Makefile                      |    2 +-
 libxfs/xfs.h                         |    9 +-
 libxfs/xfs_attr.c                    |  296 --------------------------------
 libxfs/xfs_attr_remote.c             |  306 ++++++++++++++++++++++++++++++++++
 6 files changed, 322 insertions(+), 315 deletions(-)
include/libxfs.h +1 -0
index 41cb585..972d850 100644

Lines of this file are not shown. View the raw message.

include/xfs_attr_remote.h renamed from include/xfs.h +7 -16
similarity index 69%
copy from include/xfs.h
copy to include/xfs_attr_remote.h
index e32c4a8..b4be90e 100644

Lines of this file are not shown. View the raw message.

libxfs/Makefile +1 -1
index 75f365c..d0b483d 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +7 -2
index b3b45bb..c69dc4a 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr.c +0 -296

296 lines not on this page · raw message

libxfs/xfs_attr_remote.c new file +306 -0

306 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-add-crc-to-remote-attr0000600000175000017500000003445012132011546021144 0ustar davedavexfs: add CRC protection to remote attributes

From: Dave Chinner <[email protected]>

There are two ways of doing this - the first is to add a CRC to the remote attribute entry in the attribute block. The second is to treat them similar to the remote symlink, where each fragment has it's own header and identifies fragment location in the attribute.

The problem with the CRC in the remote attr entry is that we cannot identify the owner of the metadata from the metadata blocks themselves, or where the blocks fit into the remote attribute. The down side to this approach is that we never know when the attribute has been read from disk or not and so we have to verify it every time it is read, and we must calculate it during the create transaction and log it. We do not log CRCs for any other metadata, and so this creates a unique set of coherency problems that, in general, are best avoided.

Adding an identifying header to each allocated block allows us to identify each fragment and where in the attribute it is located. It enables us to rebuild the remote attribute from just the raw blocks containing the attribute. It also provides us to do per-block CRCs verification at IO time rather than during the transaction context that creates it or every time it is read into a user buffer. Hence it avoids all the problems that an external, logged CRC has, and provides all the benefits of self identifying metadata.

The only complexity is that we have to add a header per fragment, and we don't know how many fragments will be needed prior to allocations. If we take the symlink example, the header is 56 bytes and hence for a 4k block size filesystem, in the worst case 16 headers requires 1 extra block for the 64k attribute data. For 512 byte filesystems the worst case is an extra block for every 9 fragments (i.e. 16 extra blocks in the worse case). This will be very rare and so it's not really a major concern.

Because allocation is done in two steps - the first finds a hole large enough in the attribute file, the second does the allocation - we only need to find a hole big enough for a worst case allocation. We only need to allocate enough extra blocks for number of headers required by the fragments, and we can calculate that as we go....

Hence it really only makes sense to use the same model as for symlinks - it doesn't add that much complexity, does not require an attribute tree format change, and does not require logging calculated CRC values.

---
 include/xfs_attr_remote.h |   19 +++
 libxfs/xfs_attr_remote.c  |  321 ++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 290 insertions(+), 50 deletions(-)
include/xfs_attr_remote.h +19 -0
index b4be90e..9e71edf 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_remote.c +271 -50

321 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-da-blf-types0000600000175000017500000003612112132011547017253 0ustar davedavexfs: add buffer types to directory and attribute buffers

From: Dave Chinner <[email protected]>

Add buffer types to the buffer log items so that log recovery can validate the buffers and calculate CRCs correctly after the buffers are recovered.

---
 include/xfs_attr_remote.h |    2 ++
 include/xfs_buf_item.h    |   18 +++++++++++++++++-
 include/xfs_da_btree.h    |    2 ++
 include/xfs_trans.h       |    2 ++
 libxfs/xfs.h              |    1 +
 libxfs/xfs_attr_leaf.c    |    9 ++++++++-
 libxfs/xfs_da_btree.c     |   46 ++++++++++++++++++++++++++++++++++++++++++---
 libxfs/xfs_dir2_block.c   |   12 +++++++++---
 libxfs/xfs_dir2_data.c    |    8 +++++++-
 libxfs/xfs_dir2_leaf.c    |   24 +++++++++++++++++++----
 libxfs/xfs_dir2_node.c    |   17 ++++++++++++++---
 libxfs/xfs_dir2_priv.h    |    2 ++
 12 files changed, 127 insertions(+), 16 deletions(-)
include/xfs_attr_remote.h +2 -0
index 9e71edf..28f6f10 100644

Lines of this file are not shown. View the raw message.

include/xfs_buf_item.h +17 -1
index 09cab4e..640adcf 100644

Lines of this file are not shown. View the raw message.

include/xfs_da_btree.h +2 -0
index 0e8182c..6fb3371 100644

Lines of this file are not shown. View the raw message.

include/xfs_trans.h +2 -0
index a9bd826..9e145e9 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +1 -0
index c69dc4a..6bec18e 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_leaf.c +8 -1
index 9de2244..7724781 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_da_btree.c +43 -3

46 lines not on this page · raw message

libxfs/xfs_dir2_block.c +9 -3
index b98b749..574e414 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_data.c +7 -1
index 69841df..9752ae3 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_leaf.c +20 -4
index f00b23c..3d1ec23 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_node.c +14 -3
index 9e75553..a88049b 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_priv.h +2 -0
index 932565d..7cf573c 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-trans-type-blf-change0000600000175000017500000004130012132011547021051 0ustar davedavexfs: buffer type overruns blf_flags field

From: Dave Chinner <[email protected]>

The buffer type passed to log recvoery in the buffer log item overruns the blf_flags field. I had assumed that flags field was a 32 bit value, and it turns out it is a unisgned short. Therefore having 19 flags doesn't really work.

Convert the buffer type field to numeric value, and use the top 5 bits of the flags field for it. We currently have 17 types of buffers, so using 5 bits gives us plenty of room for expansion in future....

---
 include/xfs_buf_item.h  |   92 +++++++++++++++++++++++++++--------------------
 include/xfs_trans.h     |    4 ---
 libxfs/trans.c          |    2 +-
 libxfs/xfs_alloc.c      |    4 +--
 libxfs/xfs_attr_leaf.c  |    6 ++--
 libxfs/xfs_bmap.c       |    2 +-
 libxfs/xfs_btree.c      |    8 ++---
 libxfs/xfs_da_btree.c   |   12 +++----
 libxfs/xfs_dir2_block.c |    4 +--
 libxfs/xfs_dir2_data.c  |    4 +--
 libxfs/xfs_dir2_leaf.c  |   12 +++----
 libxfs/xfs_dir2_node.c  |   10 +++---
 libxfs/xfs_ialloc.c     |    2 +-
 13 files changed, 86 insertions(+), 76 deletions(-)
include/xfs_buf_item.h +53 -39

92 lines not on this page · raw message

include/xfs_trans.h +0 -4
index 9e145e9..acf1381 100644

Lines of this file are not shown. View the raw message.

libxfs/trans.c +1 -1
index 619aad1..831e42a 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc.c +2 -2
index 30fc5f4..1041f8f 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_leaf.c +3 -3
index 7724781..b28266a 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_bmap.c +1 -1
index 5e736a5..6664265 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_btree.c +4 -4
index a7c19e9..a613294 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_da_btree.c +6 -6
index 565010d..0a96f20 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_block.c +2 -2
index 574e414..dc69394 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_data.c +2 -2
index 9752ae3..155352c 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_leaf.c +6 -6
index d58c25b..12fb61d 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_node.c +5 -5
index 707aae8..eb430f9 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc.c +1 -1
index 008c4ea..bea5254 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs__add_crc_checks_to_the_superblock-20000600000175000017500000003700012132011547024033 0ustar davedavexfs: add CRC checks to the superblock

From: Dave Chinner <[email protected]>

With the addition of CRCs, there is such a wide and varied change to the on disk format that it makes sense to bump the superblock version number rather than try to use feature bits for all the new functionality.

This commit introduces all the new superblock fields needed for all the new functionality: feature masks similar to ext4, separate project quota inodes, a LSN field for recovery and the CRC field.

This commit does not bump the superblock version number, however. That will be done as a separate commit at the end of the series after all the new functionality is present so we switch it all on in one commit. This means that we can slowly introduce the changes without them being active and hence maintain bisectability of the tree.

This patch is based on a patch originally written by myself back from SGI days, which was subsequently modified by Christoph Hellwig. There is relatively little of that patch remaining, but the history of the patch still should be acknowledged here.

---
 include/xfs_mount.h |    1 +
 include/xfs_sb.h    |  100 ++++++++++++++++++++++++++++++++++++---------------
 libxfs/xfs_mount.c  |   92 +++++++++++++++++++++++++++++++++++++++++------
 3 files changed, 153 insertions(+), 40 deletions(-)
include/xfs_mount.h +1 -0
index 28bbf46..68c02a9 100644

Lines of this file are not shown. View the raw message.

include/xfs_sb.h +71 -29

100 lines not on this page · raw message

libxfs/xfs_mount.c +81 -11

92 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfs-sb-v5-feature-masks0000600000175000017500000002057312132011547020471 0ustar davedavexfs: implement extended feature masks

From: Dave Chinner <[email protected]>

The version 5 superblock has extended feature masks for compatible, incompatible and read-only compatible feature sets. Implement the masking and mount-time checking for these feature masks.

---
 include/xfs_sb.h           |   70 ++++++++++++++++++++++++++++++++++++++++++--
 libxfs/xfs_mount.c         |   41 ++++++++++++++++++++++----
 logprint/log_print_trans.c |   18 ++++++++++++
 3 files changed, 122 insertions(+), 7 deletions(-)
include/xfs_sb.h +68 -2

70 lines not on this page · raw message

libxfs/xfs_mount.c +36 -5

41 lines not on this page · raw message

logprint/log_print_trans.c +18 -0
index 86e1c42..2dd3a10 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-mkfs-crc-support0000600000175000017500000022567312132011547021272 0ustar davedavexfsprogs: introduce CRC support into mkfs.xfs

From: Dave Chinner <[email protected]>

---
 copy/xfs_copy.c           |    5 +-
 db/sb.c                   |    6 +-
 include/libxfs.h          |   85 ++++++++++++++----------
 include/libxlog.h         |    2 +-
 libxfs/init.c             |   20 +++---
 libxfs/logitem.c          |    4 +-
 libxfs/rdwr.c             |  143 ++++++++++++++++++++++++++-------------
 libxfs/trans.c            |    8 +--
 libxfs/xfs.h              |   15 +++--
 libxfs/xfs_alloc.c        |   10 +--
 libxfs/xfs_alloc_btree.c  |    6 +-
 libxfs/xfs_attr_leaf.c    |    6 +-
 libxfs/xfs_attr_remote.c  |    6 +-
 libxfs/xfs_bmap_btree.c   |    6 +-
 libxfs/xfs_btree.c        |    8 +--
 libxfs/xfs_da_btree.c     |    6 +-
 libxfs/xfs_dir2_block.c   |    6 +-
 libxfs/xfs_dir2_data.c    |   10 +--
 libxfs/xfs_dir2_leaf.c    |    6 +-
 libxfs/xfs_dir2_node.c    |    6 +-
 libxfs/xfs_ialloc.c       |    6 +-
 libxfs/xfs_ialloc_btree.c |    6 +-
 libxfs/xfs_inode.c        |    4 +-
 libxfs/xfs_mount.c        |   18 +++--
 libxfs/xfs_symlink.c      |    8 +--
 logprint/logprint.c       |    3 +-
 mkfs/maxtrres.c           |    4 +-
 mkfs/proto.c              |    4 +-
 mkfs/xfs_mkfs.c           |  162 +++++++++++++++++++++++++++++++++++----------
 mkfs/xfs_mkfs.h           |   12 ++--
 repair/attr_repair.c      |    6 +-
 repair/dino_chunks.c      |    8 ++-
 repair/dinode.c           |   10 +--
 repair/dir.c              |    8 +--
 repair/dir2.c             |    2 +-
 repair/phase2.c           |    5 +-
 repair/phase3.c           |    2 +-
 repair/phase6.c           |    8 +--
 repair/prefetch.c         |    4 +-
 repair/rt.c               |    4 +-
 repair/scan.c             |   12 ++--
 repair/xfs_repair.c       |    7 +-
 42 files changed, 423 insertions(+), 244 deletions(-)
copy/xfs_copy.c +4 -1
index c01e0b9..7dc7d9a 100644

Lines of this file are not shown. View the raw message.

db/sb.c +3 -3
index d83db9c..f99210c 100644

Lines of this file are not shown. View the raw message.

include/libxfs.h +51 -34

85 lines not on this page · raw message

include/libxlog.h +1 -1
index 36ede59..37cbc68 100644

Lines of this file are not shown. View the raw message.

libxfs/init.c +12 -8
index 1b11fb0..55a17d2 100644

Lines of this file are not shown. View the raw message.

libxfs/logitem.c +2 -2
index 84e4c14..f298aa0 100644

Lines of this file are not shown. View the raw message.

libxfs/rdwr.c +96 -47

143 lines not on this page · raw message

libxfs/trans.c +4 -4
index 831e42a..7cef147 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +9 -6
index 6bec18e..4bad148 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc.c +5 -5
index 1041f8f..1429c9b 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc_btree.c +3 -3
index 949c96d..a845a15 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_leaf.c +3 -3
index b28266a..6d7ac3b 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_attr_remote.c +3 -3
index fa112ad..68956ac 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_bmap_btree.c +3 -3
index 473db4a..761ef29 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_btree.c +4 -4
index a613294..60a7d61 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_da_btree.c +3 -3
index 0a96f20..fb2f95a 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_block.c +3 -3
index dc69394..004e240 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_data.c +5 -5
index 155352c..8182f60 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_leaf.c +3 -3
index 12fb61d..1862e0c 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_node.c +3 -3
index eb430f9..36747b1 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc.c +3 -3
index bea5254..8b0fa0e 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc_btree.c +3 -3
index ee036bf..d7c865f 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_inode.c +2 -2
index d6513b9..5ca8f32 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_mount.c +8 -10
index f7daa2f..029f891 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_symlink.c +4 -4
index e018abc..6c42de7 100644

Lines of this file are not shown. View the raw message.

logprint/logprint.c +2 -1
index 2a01780..5452e87 100644

Lines of this file are not shown. View the raw message.

mkfs/maxtrres.c +3 -1
index f12cc70..d571d77 100644

Lines of this file are not shown. View the raw message.

mkfs/proto.c +2 -2
index 56eed31..4254f8a 100644

Lines of this file are not shown. View the raw message.

mkfs/xfs_mkfs.c +126 -36

162 lines not on this page · raw message

mkfs/xfs_mkfs.h +7 -5
index f25a7f3..d10e444 100644

Lines of this file are not shown. View the raw message.

repair/attr_repair.c +3 -3
index 033b7fe..70a2041 100644

Lines of this file are not shown. View the raw message.

repair/dino_chunks.c +6 -2
index 4d14c57..3e7e225 100644

Lines of this file are not shown. View the raw message.

repair/dinode.c +6 -4
index f564216..7a75dc8 100644

Lines of this file are not shown. View the raw message.

repair/dir.c +4 -4
index cb04267..925ba5d 100644

Lines of this file are not shown. View the raw message.

repair/dir2.c +1 -1
index b774897..274273d 100644

Lines of this file are not shown. View the raw message.

repair/phase2.c +3 -2
index 23b457a..5a4cf10 100644

Lines of this file are not shown. View the raw message.

repair/phase3.c +1 -1
index 80c66b5..3e43938 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +4 -4
index 090e400..8d4d941 100644

Lines of this file are not shown. View the raw message.

repair/prefetch.c +2 -2
index e0eff96..f985e38 100644

Lines of this file are not shown. View the raw message.

repair/rt.c +2 -2
index d6ecd56..042ff46 100644

Lines of this file are not shown. View the raw message.

repair/scan.c +6 -6
index 76bb7f1..82a0fed 100644

Lines of this file are not shown. View the raw message.

repair/xfs_repair.c +5 -2
index 67a7446..167b1f6 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-repair-crc-support0000600000175000017500000013007612132011547021604 0ustar davedavexfsprogs: add crc format support to repair

From: Dave Chinner <[email protected]>

---
 db/sb.c                    |    1 +
 include/libxfs.h           |    5 ++
 include/xfs_alloc_btree.h  |    2 +-
 include/xfs_bmap_btree.h   |    2 +-
 include/xfs_btree.h        |    5 +-
 include/xfs_ialloc_btree.h |    2 +-
 include/xfs_symlink.h      |    2 +
 libxfs/rdwr.c              |   20 ++++-
 libxfs/xfs.h               |   12 ++-
 libxfs/xfs_alloc.c         |    7 +-
 libxfs/xfs_btree.c         |   20 +++--
 libxfs/xfs_ialloc.c        |    2 -
 libxfs/xfs_mount.c         |   16 ----
 libxlog/xfs_log_recover.c  |    4 +-
 logprint/logprint.c        |    3 +
 repair/agheader.c          |   36 ++++++++-
 repair/dino_chunks.c       |    7 +-
 repair/dinode.c            |  190 ++++++++++++++++++++++++++------------------
 repair/phase2.c            |    1 +
 repair/phase5.c            |  157 +++++++++++++++++++++++++++---------
 repair/prefetch.c          |    7 +-
 repair/scan.c              |  158 +++++++++++++++++++-----------------
 repair/scan.h              |   12 ++-
 repair/versions.c          |    2 +-
 repair/xfs_repair.c        |    2 +-
 25 files changed, 435 insertions(+), 240 deletions(-)
db/sb.c +1 -0
index f99210c..af86722 100644

Lines of this file are not shown. View the raw message.

include/libxfs.h +5 -0
index 8ee4eaa..0f870f6 100644

Lines of this file are not shown. View the raw message.

include/xfs_alloc_btree.h +1 -1
index 70c3ea0..e160339 100644

Lines of this file are not shown. View the raw message.

include/xfs_bmap_btree.h +1 -1
index 8a28b89..20d66b0 100644

Lines of this file are not shown. View the raw message.

include/xfs_btree.h +4 -1
index 02f89d8..c0acbbf 100644

Lines of this file are not shown. View the raw message.

include/xfs_ialloc_btree.h +1 -1
index a1bfa7a..7f5ae6b 100644

Lines of this file are not shown. View the raw message.

include/xfs_symlink.h +2 -0
index bb21e6a..55f3f2d 100644

Lines of this file are not shown. View the raw message.

libxfs/rdwr.c +19 -1
index db4ed6e..1b56e57 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs.h +10 -2
index 4bad148..7051ec5 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_alloc.c +6 -1
index 1429c9b..54f1b35 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_btree.c +9 -11
index 60a7d61..3814b53 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_ialloc.c +0 -2
index 8b0fa0e..282d938 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_mount.c +0 -16
index 029f891..774fd2c 100644

Lines of this file are not shown. View the raw message.

libxlog/xfs_log_recover.c +1 -3
index ad53e86..c66f9a1 100644

Lines of this file are not shown. View the raw message.

logprint/logprint.c +3 -0
index 5452e87..cf24b6e 100644

Lines of this file are not shown. View the raw message.

repair/agheader.c +34 -2
index 769022d..bc8b1bf 100644

Lines of this file are not shown. View the raw message.

repair/dino_chunks.c +5 -2
index 3e7e225..280423b 100644

Lines of this file are not shown. View the raw message.

repair/dinode.c +111 -79

190 lines not on this page · raw message

repair/phase2.c +1 -0
index 5a4cf10..0481f51 100644

Lines of this file are not shown. View the raw message.

repair/phase5.c +118 -39

157 lines not on this page · raw message

repair/prefetch.c +6 -1
index f985e38..a1b2454 100644

Lines of this file are not shown. View the raw message.

repair/scan.c +87 -71

158 lines not on this page · raw message

repair/scan.h +8 -4
index 9f945cf..92593e9 100644

Lines of this file are not shown. View the raw message.

repair/versions.c +1 -1
index 957766a..c11a728 100644

Lines of this file are not shown. View the raw message.

repair/xfs_repair.c +1 -1
index 167b1f6..8eefc48 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-db-crc-support0000600000175000017500000010675112132011547020712 0ustar davedavexfsprogs: add crc format support to db

From: Dave Chinner <[email protected]>

---
 db/agf.c                 |    3 +
 db/agfl.c                |   16 +++++
 db/agfl.h                |    2 +
 db/agi.c                 |    3 +
 db/btblock.c             |  145 ++++++++++++++++++++++++++++++++++++++++++++++
 db/btblock.h             |   10 ++++
 db/check.c               |   20 ++++++-
 db/field.c               |   16 +++++
 db/field.h               |    8 +++
 db/freesp.c              |   11 +++-
 db/init.c                |    4 ++
 db/inode.c               |   27 +++++++++
 db/inode.h               |    3 +
 db/sb.c                  |   28 ++++++++-
 db/type.c                |   35 ++++++++++-
 db/type.h                |    3 +-
 include/xfs_dir2.h       |    8 +++
 include/xfs_inode.h      |    4 +-
 libxfs/init.c            |    3 +-
 logprint/log_misc.c      |    2 +-
 logprint/log_print_all.c |    4 +-
 repair/dir2.c            |   15 ++---
 repair/phase6.c          |   20 +++----
 23 files changed, 359 insertions(+), 31 deletions(-)
db/agf.c +3 -0
index 668637a..389cb43 100644

Lines of this file are not shown. View the raw message.

db/agfl.c +16 -0
index 72dca23..e2340e6 100644

Lines of this file are not shown. View the raw message.

db/agfl.h +2 -0
index 7b7631b..177ad41 100644

Lines of this file are not shown. View the raw message.

db/agi.c +3 -0
index 02d5d30..6b2e889 100644

Lines of this file are not shown. View the raw message.

db/btblock.c +145 -0

145 lines not on this page · raw message

db/btblock.h +10 -0
index 0631e66..daee060 100644

Lines of this file are not shown. View the raw message.

db/check.c +19 -1
index efbd0c9..41c150b 100644

Lines of this file are not shown. View the raw message.

db/field.c +16 -0
index 6903898..032b74e 100644

Lines of this file are not shown. View the raw message.

db/field.h +8 -0
index 6962d69..f503c42 100644

Lines of this file are not shown. View the raw message.

db/freesp.c +8 -3
index 472b1f7..9813137 100644

Lines of this file are not shown. View the raw message.

db/init.c +4 -0
index 2a31cb8..141b484 100644

Lines of this file are not shown. View the raw message.

db/inode.c +27 -0
index 036717f..6596e4f 100644

Lines of this file are not shown. View the raw message.

db/inode.h +3 -0
index 6c1ac5c..1624f1d 100644

Lines of this file are not shown. View the raw message.

db/sb.c +27 -1
index af86722..c52d545 100644

Lines of this file are not shown. View the raw message.

db/type.c +34 -1
index e5fd9eb..ad67543 100644

Lines of this file are not shown. View the raw message.

db/type.h +2 -1
index 8dd7925..ae92581 100644

Lines of this file are not shown. View the raw message.

include/xfs_dir2.h +8 -0
index 2dd0cc0..2ed4d82 100644

Lines of this file are not shown. View the raw message.

include/xfs_inode.h +2 -2
index cc14743..fdca7f7 100644

Lines of this file are not shown. View the raw message.

libxfs/init.c +2 -1
index 55a17d2..372dd6b 100644

Lines of this file are not shown. View the raw message.

logprint/log_misc.c +1 -1
index ffc6916..a9c3710 100644

Lines of this file are not shown. View the raw message.

logprint/log_print_all.c +2 -2
index 70b0905..4626186 100644

Lines of this file are not shown. View the raw message.

repair/dir2.c +8 -7
index 274273d..02c3bf3 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +9 -11
index 8d4d941..48596e8 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-repair-dir-crc-support0000600000175000017500000005262612132011547022364 0ustar davedavexfs_repair: update for dir/attr crc format changes.

From: Dave Chinner <[email protected]>

---
 include/xfs_attr_leaf.h   |    2 +
 include/xfs_dir2_format.h |    3 ++
 libxfs/xfs_dir2_priv.h    |    2 -
 repair/attr_repair.c      |   53 ++++++++++++++-----------
 repair/dir2.c             |   43 +++++++++++---------
 repair/dir2.h             |    6 +--
 repair/phase6.c           |   95 ++++++++++++++++++++++++++-------------------
 7 files changed, 118 insertions(+), 86 deletions(-)
include/xfs_attr_leaf.h +2 -0
index f9d7846..b3e93bb 100644

Lines of this file are not shown. View the raw message.

include/xfs_dir2_format.h +3 -0
index 8d33f03..7137ba0 100644

Lines of this file are not shown. View the raw message.

libxfs/xfs_dir2_priv.h +0 -2
index 7cf573c..a5f1e97 100644

Lines of this file are not shown. View the raw message.

repair/attr_repair.c +31 -22

53 lines not on this page · raw message

repair/dir2.c +25 -18

43 lines not on this page · raw message

repair/dir2.h +3 -3
index 63e35d4..6a85015 100644

Lines of this file are not shown. View the raw message.

repair/phase6.c +54 -41

95 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/debug0000600000175000017500000000000512132011547015244 0ustar davedave---

xfsprogs-crc-patchset-v2/bpm-progs-deb0000600000175000017500000000777112132011547016635 0ustar davedavexfsprogs: update 'make deb' to use tarball
From: Ben Myers <[email protected]>

This patch changes the build process so that 'make deb' uses the same process of creating a source tree as the release script.

* Add a list of files which go in the release tarball in .gitcensus This is needed so that you can create a tarball in a bare release tree, when .git is not available.

* Modify the SRCTAR target to include files from .git_census and use tar instead of git archive.

* Modify the SRCTARINC files to include .git_census, and include .git_census in the 'make realclean' target.

* remove the 'make source-link' target.

---

v2: don't muck with signing the deb in this patch, rename .git_census to .gitcensus, add .gitcensus to .gitignore.

 .gitignore         |    1 +
 Makefile           |   24 ++++++++++++------------
 include/buildrules |   11 -----------
 3 files changed, 13 insertions(+), 23 deletions(-)
.gitignore +1 -0
Index: b/.gitignore
===================================================================

Lines of this file are not shown. View the raw message.

Makefile +12 -12
Index: b/Makefile
===================================================================

Lines of this file are not shown. View the raw message.

include/buildrules +0 -11
Index: b/include/buildrules
===================================================================

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Signature · 28 lines
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.



xfsprogs-crc-patchset-v2/xfsprogs-freespace0000600000175000017500000002453112132011547017776 0ustar  davedavexfsprogs: Space management tool

From: Dave Chinner <[email protected]>

xfs_spaceman is intended as a diagnostic and control tool for space
management operations within XFS. Operations like examining free
space, managing allocation policies, issuing block discards on free
space, etc.

The tool is modelled on the xfs_io interface, allowing both
interactive and command line control of the tool, enabling it to be
used in scripts and automated management tools.

Signed-off-by: Dave Chinner <[email protected]>
---
 Makefile          |    3 +-
 spaceman/Makefile |   34 ++++++++++++
 spaceman/file.c   |  149 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 spaceman/init.c   |  119 ++++++++++++++++++++++++++++++++++++++++++
 spaceman/init.h   |   24 +++++++++
 spaceman/space.h  |   36 +++++++++++++
 6 files changed, 364 insertions(+), 1 deletion(-)
Makefile +2 -1
index c40fb2c..a81b8b2 100644

Lines of this file are not shown. View the raw message.

spaceman/Makefile new file +34 -0
new file mode 100644
index 0000000..ff8d23e

Lines of this file are not shown. View the raw message.

spaceman/file.c new file +149 -0

149 lines not on this page · raw message

spaceman/init.c new file +119 -0

119 lines not on this page · raw message

spaceman/init.h new file +24 -0
new file mode 100644
index 0000000..ecd0b5d

Lines of this file are not shown. View the raw message.

spaceman/space.h new file +36 -0
new file mode 100644
index 0000000..6e1bc52

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/spaceman-trim0000600000175000017500000001155612132011547016733 0ustar davedavespaceman: add FITRIM support

From: Dave Chinner <[email protected]>

Add support for discarding free space extents via the FITRIM command. Make it easy to discard a single range, an entire AG or all the freespace in the filesystem.

---
 spaceman/Makefile |    2 +-
 spaceman/init.c   |    1 +
 spaceman/space.h  |    1 +
 spaceman/trim.c   |  140 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 143 insertions(+), 1 deletion(-)
spaceman/Makefile +1 -1
index ff8d23e..9fb9142 100644

Lines of this file are not shown. View the raw message.

spaceman/init.c +1 -0
index f3d5397..307d91f 100644

Lines of this file are not shown. View the raw message.

spaceman/space.h +1 -0
index 6e1bc52..7b4f034 100644

Lines of this file are not shown. View the raw message.

spaceman/trim.c new file +140 -0

140 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/spaceman-prealloc-flush0000600000175000017500000001210012132011547020662 0ustar davedavespaceman: add new speculative prealloc control

From: Dave Chinner <[email protected]>

Add an control interface for purging speculative
preallocation via the new ioctls.

---
 spaceman/Makefile   |    2 +-
 spaceman/init.c     |    1 +
 spaceman/prealloc.c |  136 +++++++++++++++++++++++++++++++++++++++++++++++++++
 spaceman/space.h    |    1 +
 4 files changed, 139 insertions(+), 1 deletion(-)
spaceman/Makefile +1 -1
index 9fb9142..b1f1136 100644

Lines of this file are not shown. View the raw message.

spaceman/init.c +1 -0
index 314b5aa..e16ad83 100644

Lines of this file are not shown. View the raw message.

spaceman/prealloc.c new file +136 -0

136 lines not on this page · raw message

spaceman/space.h +1 -0
index 7b4f034..0ae3116 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/spaceman-ag-control0000600000175000017500000001521212132011547020016 0ustar davedavespaceman: AG state control

From: Dave Chinner <[email protected]>

Add support for a new allocation group state control ioctl. This allows control of various AG parameters, such as whether inode allocation is allowed in the AG, metadata preference, whether new allocations are allowed, etc. This requires a new ioctl.

---
 spaceman/Makefile |    2 +-
 spaceman/ag.c     |  222 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 223 insertions(+), 1 deletion(-)
spaceman/Makefile +1 -1
index b1f1136..08709b3 100644

Lines of this file are not shown. View the raw message.

spaceman/ag.c new file +222 -0

222 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

xfsprogs-crc-patchset-v2/xfsprogs-freespace-20000600000175000017500000002463512132011547020142 0ustar davedavexfsprogs: Space management tool

From: Dave Chinner <[email protected]>

Add freespace mapping tool modelled on the xfs_db freesp command. The advantage of this command over xfs_db is that it can be done online and is coherent with concurrent modifications to the filesystem.

This requires kernel extensions to the fiemap command to map free space indexes.

---
 spaceman/Makefile |    2 +-
 spaceman/freesp.c |  395 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 spaceman/init.c   |    1 +
 spaceman/space.h  |    1 +
 4 files changed, 398 insertions(+), 1 deletion(-)
spaceman/Makefile +1 -1
index b1f1136..4743ad8 100644

Lines of this file are not shown. View the raw message.

spaceman/freesp.c new file +395 -0

395 lines not on this page · raw message

spaceman/init.c +1 -0
index e16ad83..f8a3cb3 100644

Lines of this file are not shown. View the raw message.

spaceman/space.h +1 -0
index 0ae3116..a1381a6 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 34 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

Dave Chinner (26):
xfsprogs: sync code to current kernel code
xfsprogs: update libxfs to 3.9-rc1 + xfsdev
xfsprogs: add CRC32c infrastructure
xfsprogs: updata libxlog to current kernel code
libxfs: add crc format changes to generic btrees
xfsprogs: add crc format chagnes to ag headers
libxfs: change quota buffer formats
libxfs: add version 3 inode support
libxfs: add support for crc headers on remote symlinks
xfs: add CRC checks to block format directory blocks
xfs: add CRC checking to dir2 free blocks
xfs: add CRC checking to dir2 data blocks
xfs: add CRC checking to dir2 leaf blocks
xfs: shortform directory offsets change for dir3 format
xfs: add CRCs to dir2/da node blocks
xfs: add CRCs to attr leaf blocks
xfs: split remote attribute code out
xfs: add CRC protection to remote attributes

Quoted 8 lines

xfs: add buffer types to directory and attribute buffers
xfs: buffer type overruns blf_flags field
xfs: add CRC checks to the superblock
xfs: implement extended feature masks
xfsprogs: introduce CRC support into mkfs.xfs
xfsprogs: add crc format support to repair
xfsprogs: add crc format support to db
xfs_repair: update for dir/attr crc format changes.

The patch "logprint-agi-dump" needs a commit message and Signed-off-by.

The patch "debug" be removed (empty) from series and directory.

Thanks,

--Mark.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 44 lines · Mark Tinguely
Quoted 34 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

Dave Chinner (26):
xfsprogs: sync code to current kernel code
xfsprogs: update libxfs to 3.9-rc1 + xfsdev
xfsprogs: add CRC32c infrastructure
xfsprogs: updata libxlog to current kernel code
libxfs: add crc format changes to generic btrees
xfsprogs: add crc format chagnes to ag headers
libxfs: change quota buffer formats
libxfs: add version 3 inode support
libxfs: add support for crc headers on remote symlinks
xfs: add CRC checks to block format directory blocks
xfs: add CRC checking to dir2 free blocks
xfs: add CRC checking to dir2 data blocks
xfs: add CRC checking to dir2 leaf blocks
xfs: shortform directory offsets change for dir3 format
xfs: add CRCs to dir2/da node blocks
xfs: add CRCs to attr leaf blocks
xfs: split remote attribute code out
xfs: add CRC protection to remote attributes

Quoted 8 lines

xfs: add buffer types to directory and attribute buffers
xfs: buffer type overruns blf_flags field
xfs: add CRC checks to the superblock
xfs: implement extended feature masks
xfsprogs: introduce CRC support into mkfs.xfs
xfsprogs: add crc format support to repair
xfsprogs: add crc format support to db
xfs_repair: update for dir/attr crc format changes.

Quoted 3 lines

The patch "logprint-agi-dump" needs a commit message and Signed-off-by.

The patch "debug" be removed (empty) from series and directory.

Looks like I didn't clear out a couple of debug-only patches from the tarball properly. I'll fix that for the next release...

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#3 lore raw
In reply to Dave Chinner
Quoted 7 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

Quoted 8 lines

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

BTW forgot about this gem, the UBER/xfsprogs-kernel-3.8-update patch has been kicking up duplicate defines in sles11sp2 (gcc 4.3.4), but fine in newer distros (gcc 4.6.2). Looks like a compile difference issue:

xfs_dir2_data_aoff_t xfs_dir2_format.h and xfs_dir2.h
xfs_dir2_db_t xfs_dir2_format.h and xfs_dir2.h

The one below seems new to me:
prid_t project.h and xfs_types.h

I have been removing the entry in xfs_dir2_format.h in the past to test. I don't remember the prid_t duplicate.

--Mark.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#4 lore raw
Quoted 22 lines · Mark Tinguely
Quoted 7 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

Quoted 8 lines

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

BTW forgot about this gem, the UBER/xfsprogs-kernel-3.8-update patch has been kicking up duplicate defines in sles11sp2 (gcc 4.3.4), but fine in newer distros (gcc 4.6.2). Looks like a compile difference issue:

Quoted 8 lines

xfs_dir2_data_aoff_t xfs_dir2_format.h and xfs_dir2.h
xfs_dir2_db_t xfs_dir2_format.h and xfs_dir2.h

The one below seems new to me:
prid_t project.h and xfs_types.h

I have been removing the entry in xfs_dir2_format.h in the past to test. I don't remember the prid_t duplicate.

Hmmmm. I'm not getting those warnings here (gcc-4.7.2). I'll have a look into it....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#5 lore raw
Quoted 32 lines · Dave Chinner
Quoted 22 lines · Mark Tinguely
Quoted 7 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

Quoted 8 lines

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

BTW forgot about this gem, the UBER/xfsprogs-kernel-3.8-update patch has been kicking up duplicate defines in sles11sp2 (gcc 4.3.4), but fine in newer distros (gcc 4.6.2). Looks like a compile difference issue:

Quoted 8 lines

xfs_dir2_data_aoff_t xfs_dir2_format.h and xfs_dir2.h
xfs_dir2_db_t xfs_dir2_format.h and xfs_dir2.h

The one below seems new to me:
prid_t project.h and xfs_types.h

I have been removing the entry in xfs_dir2_format.h in the past to test. I don't remember the prid_t duplicate.

Quoted 6 lines

Hmmmm. I'm not getting those warnings here (gcc-4.7.2). I'll have a look into it....

Cheers,

Dave.

I replaced the gcc-4.3 compiler with a gcc-4.6.3 compiler and the duplicates errors disappeared.

The following patch works with both the gcc-4.3 and gcc-4.6 compilers.

Beyond the duplicates, the header and libxfs files in thexfsprogs-kernel-3.8-update patch compare to Linux 3.8 kernel code and I consider it Reviewed-by: me.

I will do the xfsprogs-kernel-3.9-rc1-dev-update tonight.

--Mark.

---
 include/xfs/project.h         |    4 ----
 include/xfs/xfs_dir2_format.h |    6 ------
 2 files changed, 10 deletions(-)
include/xfs/project.h +0 -4
Index: b/include/xfs/project.h
===================================================================
@@ -20,10 +20,6 @@
 
 #include <xfs/xfs.h>
 
-#if !defined(__sgi__)
-typedef __uint32_t	prid_t;
-#endif
-
 extern int setprojid(const char *__name, int __fd, prid_t __id);
 extern int getprojid(const char *__name, int __fd, prid_t *__id);
 
include/xfs/xfs_dir2_format.h +0 -1
Index: b/include/xfs/xfs_dir2_format.h
===================================================================
@@ -40,7 +40,6 @@
  */
 typedef	__uint16_t	xfs_dir2_data_off_t;
 #define	NULLDATAOFF	0xffffU
-typedef uint		xfs_dir2_data_aoff_t;	/* argument form */
 
 /*
  * Normalized offset (in a data block) of the entry, really 

xfs_dir2_data_off_t.
@@ -61,11 +60,6 @@ typedef __uint32_t xfs_dir2_dataptr_t;
typedef xfs_off_t xfs_dir2_off_t;

/*
- * Directory block number (logical dirblk in file)
- */
-typedef __uint32_t xfs_dir2_db_t;
-
-/*
* Inode number stored as 8 8-bit values. */
typedef struct { __uint8_t i[8]; } xfs_dir2_ino8_t;

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#6 lore raw
Quoted 41 lines · Mark Tinguely
Quoted 32 lines · Dave Chinner
Quoted 22 lines · Mark Tinguely
Quoted 7 lines · Dave Chinner

Hi folks,

I've attached a tarball containing the patch series that adds metadata CRC support to xfsprogs. It is still very much a work in progress, but is sufficient to start running xfstests on CRC enable filesystems.

Quoted 8 lines

THere is much missing functionality, especially with respect to directly/attribute modifications. Only mkfs and xfs_repair have been updated to explicitly support CRC on directory/sttribute blocks, though all the other tools will stil run the result might be a little unpredictable.

The patch series is as follows:

BTW forgot about this gem, the UBER/xfsprogs-kernel-3.8-update patch has been kicking up duplicate defines in sles11sp2 (gcc 4.3.4), but fine in newer distros (gcc 4.6.2). Looks like a compile difference issue:

Quoted 8 lines

xfs_dir2_data_aoff_t xfs_dir2_format.h and xfs_dir2.h
xfs_dir2_db_t xfs_dir2_format.h and xfs_dir2.h

The one below seems new to me:
prid_t project.h and xfs_types.h

I have been removing the entry in xfs_dir2_format.h in the past to test. I don't remember the prid_t duplicate.

Quoted 6 lines

Hmmmm. I'm not getting those warnings here (gcc-4.7.2). I'll have a look into it....

Cheers,

Dave.

Quoted 8 lines

I replaced the gcc-4.3 compiler with a gcc-4.6.3 compiler and the duplicates errors disappeared.

The following patch works with both the gcc-4.3 and gcc-4.6 compilers.

Beyond the duplicates, the header and libxfs files in thexfsprogs-kernel-3.8-update patch compare to Linux 3.8 kernel code and I consider it Reviewed-by: me.

I've got an updated version of the the update that has the dir v1 removal staged before it that I've been testing the last couple of days. I'll post that later today with an updated version of your fixes and a couple of other fixes that I've been sent in the last couple of days as well...

Quoted 1 line

I will do the xfsprogs-kernel-3.9-rc1-dev-update tonight.

It's probably worth waiting a short while before doing that ;)

include/xfs/project.h line 26

Quoted 12 lines

Index: b/include/xfs/project.h
===================================================================

include/xfs/project.h +0 -4
@@ -20,10 +20,6 @@
 
 #include <xfs/xfs.h>
 
-#if !defined(__sgi__)
-typedef __uint32_t	prid_t;
-#endif
-

Yeah, that can go, but what it means is that the Irix build will probably now break with duplicate definitions. I don't have an Irix build environment, so somebody else is going to have to fix that if they care...

include/xfs/xfs_dir2_format.h line 43

Quoted 12 lines
include/xfs/project.h +0 -0
 extern int setprojid(const char *__name, int __fd, prid_t __id);
 extern int getprojid(const char *__name, int __fd, prid_t *__id);
 

Index: b/include/xfs/xfs_dir2_format.h
===================================================================

include/xfs/xfs_dir2_format.h +0 -1
@@ -40,7 +40,6 @@
  */
 typedef	__uint16_t	xfs_dir2_data_off_t;
 #define	NULLDATAOFF	0xffffU
-typedef uint		xfs_dir2_data_aoff_t;	/* argument form */

This file is common with the kernel code, so whatever other definition it conflicts with is the one to remove.

include/xfs/xfs_dir2_format.h typedef __uint32_t xfs_dir2_dataptr_t; · line 66

Quoted 7 lines
include/xfs/xfs_dir2_format.h +0 -3
@@ -61,11 +60,6 @@ typedef	__uint32_t	xfs_dir2_dataptr_t;
 typedef	xfs_off_t	xfs_dir2_off_t;
 
 /*
- * Directory block number (logical dirblk in file)
- */
-typedef	__uint32_t	xfs_dir2_db_t;

Same here.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#7 lore raw
Quoted 19 lines · Dave Chinner

include/xfs/xfs_dir2_format.h line 43

Quoted 11 lines · Mark Tinguely
Quoted 1 line · Dave Chinner

On Thu, Apr 25, 2013 at 04:12:04PM -0500, Mark Tinguely wrote:

Index: b/include/xfs/xfs_dir2_format.h
===================================================================

include/xfs/xfs_dir2_format.h +0 -1
@@ -40,7 +40,6 @@
  */
 typedef	__uint16_t	xfs_dir2_data_off_t;
 #define	NULLDATAOFF	0xffffU
-typedef uint		xfs_dir2_data_aoff_t;	/* argument form */

This file is common with the kernel code, so whatever other definition it conflicts with is the one to remove.

Quoted 3 lines
include/xfs/xfs_dir2_format.h +0 -0
@@ -61,11 +60,6 @@ typedef	__uint32_t	xfs_dir2_dataptr_t;
 typedef	xfs_off_t	xfs_dir2_off_t;
 
Quoted 6 lines

include/xfs/xfs_dir2_format.h typedef __uint32_t xfs_dir2_dataptr_t; · line 66

Quoted 4 lines
include/xfs/xfs_dir2_format.h +0 -3
 /*
- * Directory block number (logical dirblk in file)
- */
-typedef	__uint32_t	xfs_dir2_db_t;

Same here.

So looking at this in more detail, the reason these got added to xfs_dir2.h was that there are a bunch of function prototypes I had to move from xfs_dir2_priv.h to xfs_dir2.h so that they were visible outside libxfs. This is one of the changes I need to propagate back into the kernel code to bring the kernel headers inline with what is needed by userspace.

So as a temporary measure, the above patch that just removes them from xfs_dir2_format.h is OK. I'll fold these into the current patchset.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#9 lore raw
Quoted 2 lines · Christoph Hellwig

Can you send out the libxfs resync separately? I think that's something that should go in ASAP.

Yes, the next version of the tarball will be split up into 3 parts:

1. - remove dirv1
- libxfs kernel resync
- add CRC infrstructure
- libxlog kernel resync

2. add CRC support to libxfs

3. Add CRC support to mkfs, repair, db, etc....

The plan is to do the resync (part 1) as soon as the current xfsprogs RC is officially released as that gets the largest part of the patchset into the upstream tree. I've already got this part of it pretty much ready to go....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#10 lore raw
In reply to Dave Chinner

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Thanks
--Rich

commit 49f693fa26783bb95136cdb3479902324be3f587

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 07:24:15 2013 -0500

xfsprogs: update libxfs to 3.9-rc1 + xfsdev

commit a2ceac1f6dd8771fc1cd993a6cffc30589af1ddc

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 07:23:15 2013 -0500

xfsprogs: sync code to current kernel code

commit 9a048535fceee3d199978f31524bfd649edaff08

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 07:22:15 2013 -0500

xfsprogs: Die dir1 Die!

commit 108e985bc596a1f1a33d31a348fdb430213fb8c0

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 07:16:09 2013 -0500

xfs_fsr: file reads should be O_DIRECT

commit a59111c1fc89a8bb5bd1030efce8b75f583e9b1e

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 07:11:50 2013 -0500

xfs_logprint: print all AGI unlinked buckets

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#11 lore raw
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#12 lore raw
Quoted 11 lines · Dave Chinner
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Quoted 8 lines

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Cheers,

Dave.

From this tar
xfsprogs-kern-sync-patchset-v2.tar.gz

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#13 lore raw
Quoted 16 lines · Rich Johnston
Quoted 15 lines · Dave Chinner
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Quoted 7 lines
Quoted 4 lines

Cheers,

Dave.

From this tar
xfsprogs-kern-sync-patchset-v2.tar.gz

Sorry for any confusion, the last 2 have also been commited.

commit 999f0b9c38baf5ef72535c6bb4df7ca0db677192

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 08:19:06 2013 -0500

xfsprogs: updata libxlog to current kernel code

commit 7e280e68cab97e321e306c6d1b2e684095f47296

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 08:18:51 2013 -0500

xfsprogs: add CRC32c infrastructure

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#14 lore raw
Quoted 30 lines · Rich Johnston
Quoted 16 lines · Rich Johnston
Quoted 15 lines · Dave Chinner
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Quoted 7 lines
Quoted 4 lines

Cheers,

Dave.

From this tar
xfsprogs-kern-sync-patchset-v2.tar.gz

Sorry for any confusion, the last 2 have also been committed.

commit 999f0b9c38baf5ef72535c6bb4df7ca0db677192

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 08:19:06 2013 -0500
Quoted 9 lines

xfsprogs: updata libxlog to current kernel code

commit 7e280e68cab97e321e306c6d1b2e684095f47296

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 08:18:51 2013 -0500

xfsprogs: add CRC32c infrastructure

They are all committed now, thanks for the patchset Dave.

--Rich

commit 8e78288a3a994534a320f9699c91572f7c859b8c

Author: Dave Chinner <[email protected]>
Date:   Thu May 9 11:20:13 2013 -0500

xfs_logprint: fix continuation transactions

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#15 lore raw
In reply to Rich Johnston
Quoted 16 lines · Rich Johnston
Quoted 15 lines · Dave Chinner
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Quoted 6 lines
Quoted 4 lines

Cheers,

Dave.

From this tar
xfsprogs-kern-sync-patchset-v2.tar.gz

Ok. In future, can you make sure you respond to the thread that patchset was posted in so there isn't any confusion about what you committed?

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#16 lore raw
Quoted 24 lines · Dave Chinner
Quoted 16 lines · Rich Johnston
Quoted 15 lines · Dave Chinner
Quoted 9 lines · Rich Johnston

Dave,

The following have been committed:

logprint-agi-dump
xfs-fsr-odirect-read
xfsprogs-remove-dirv1-support
xfsprogs-kernel-3.8-update
xfsprogs-kernel-3.9-rc1-dev-update

Which version did you commit? This ones posted in this thread were superceded by the tarball I posted on May 1 (i.e [TARBALL V2]
xfsprogs: fixes and updates to current kernel code)...

Quoted 6 lines
Quoted 4 lines

Cheers,

Dave.

From this tar
xfsprogs-kern-sync-patchset-v2.tar.gz

Quoted 8 lines

Ok. In future, can you make sure you respond to the thread that patchset was posted in so there isn't any confusion about what you committed?

Cheers,

Dave.

I did It shows up threaded in thunderbird.

Here is your post

Received: from dave by dastard with local (Exim 4.76) (envelope-from
<[email protected]>) id 1UQfON-0000vN-KC for [email protected]; Sat,
13 Apr
2013 00:55:55 +1000
Date: Sat, 13 Apr 2013 00:55:55 +1000
From: Dave Chinner <[email protected]>
To: <[email protected]>
Subject: [PATCH TARBALL, DEV ONLY] xfsprogs: metadata CRC support V2
Message-ID: <20130412145555.GF30622@dastard>

             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 9 lines

Message-ID: <[email protected]>
Date: Thu, 9 May 2013 07:42:03 -0500
From: Rich Johnston <[email protected]>
User-Agent: Mozilla/5.0 (X11; Linux i686;

	rv:17.0) Gecko/20130329 Thunderbird/17.0.5

To: Dave Chinner <[email protected]>
Subject: Re: [PATCH TARBALL, DEV ONLY] xfsprogs: metadata CRC support V2
References: <20130412145555.GF30622@dastard>
In-Reply-To: <20130412145555.GF30622@dastard>

                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

And my reply:

Regards
--Rich

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs