vxlan: use IANA assigned port
Subsystems (2)
PATCH 1/1 vxlan: use IANA assigned port
Ken Duda of Arista Networks, one of the VXLAN RFC authors notified me that IANA has assigned an official port for VXLAN. My initial version of the driver used the value from CISCO LISP that was also being used by OpenVswitch.
drivers/net/vxlan.c +1 -2
@@ -8,7 +8,6 @@* published by the Free Software Foundation. * * TODO -* - use IANA UDP port number (when defined) * - IPv6 (not in RFC) */
@@ -66,7 +65,7 @@ struct vxlanhdr { };/* UDP port for VXLAN traffic. */ -static unsigned int vxlan_port__read_mostly =8472 ; +static unsigned int vxlan_port__read_mostly =4789 ;module_param_named (udp_port, vxlan_port, uint,0444 );MODULE_PARM_DESC (udp_port,"Destination UDP port" );
David Miller
maintainerFrom: Stephen Hemminger <[email protected]>
Date: Fri, 26 Apr 2013 16:33:46 -0700
Quoted 6 lines
Ken Duda of Arista Networks, one of the VXLAN RFC authors notified me that IANA has assigned an official port for VXLAN. My initial version of the driver used the value from CISCO LISP that was also being used by OpenVswitch.
Signed-off-by Stephen Hemminger <[email protected]>
So how does this interact with already deployed VXLAN links?
What is the backwards compatability story? What if one node upgrades with this patch installed, but all the other nodes are left using the older port number by default?
Quoted 8 lines · * David Miller ([email protected]) wrote:
From: Stephen Hemminger <[email protected]>
Date: Fri, 26 Apr 2013 16:33:46 -0700Quoted 5 lines
Ken Duda of Arista Networks, one of the VXLAN RFC authors notified me that IANA has assigned an official port for VXLAN. My initial version of the driver used the value from CISCO LISP that was also being used by OpenVswitch.
Quoted 7 lines
Quoted 1 line
Signed-off-by Stephen Hemminger <[email protected]>So how does this interact with already deployed VXLAN links?
What is the backwards compatability story? What if one node upgrades with this patch installed, but all the other nodes are left using the older port number by default?
With this patch, I think one node upgrading would need to override the default vxlan_port module param (falling back to the pre IANA default) to keep active with the existing overlays.
David Miller
maintainerFrom: Chris Wright <[email protected]>
Date: Fri, 26 Apr 2013 18:51:29 -0700
Quoted 13 lines · * David Miller ([email protected]) wrote:
Quoted 12 lines
From: Stephen Hemminger <[email protected]>
Date: Fri, 26 Apr 2013 16:33:46 -0700Quoted 6 lines
Ken Duda of Arista Networks, one of the VXLAN RFC authors notified me that IANA has assigned an official port for VXLAN. My initial version of the driver used the value from CISCO LISP that was also being used by OpenVswitch.
Signed-off-by Stephen Hemminger <[email protected]>So how does this interact with already deployed VXLAN links?
Quoted 7 lines
Quoted 3 lines
What is the backwards compatability story? What if one node upgrades with this patch installed, but all the other nodes are left using the older port number by default?
With this patch, I think one node upgrading would need to override the default
vxlan_portmodule param (falling back to the pre IANA default) to keep active with the existing overlays.
That's an unacceptable burdon for our users.
We're stuck with the initial port number you've choosen.
People can override to the "official" port if they want to.
A message that is not in the archive (sent off-list or not yet received): CAOaVG14yv=TixikAkrjEOTBznoC6YDqm1vb4ByZ32bgXM3Q7xQ@mail.gmail.com
David Miller
maintainerFrom: Stephen Hemminger <[email protected]>
Date: Fri, 26 Apr 2013 21:53:59 -0700
Quoted 3 lines
The port should be a property anyway.
That way the value is easier to control. And we can do the transistion there.
Works for me.