Skip to contentSkip to conversation

EFI urgent fix

GIT PULL Matt Fleming 2 participants 3 messages Apr 26, 2013 EFI

lore
Share & tools
lore
#0 lore raw

Hi Peter, Linus,

I've got a small patch that fixes a crash for the Google folks and their EFI SMI driver, which was caused by dereferencing a garbage pointer.

Please consider pulling.

The following changes since commit f697036b93aa7345d4cbb3c854a76456c0ddac45:

efi: Check EFI revision in setup_efi_vars (2013-04-24 16:19:01 +0100)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-urgent

for you to fetch changes up to 45432323ef7038a91599959173700fdb8a0adb2f:

efivars: only check for duplicates on the registered list (2013-04-26 16:50:01 +0100)

----------------------------------------------------------------
* Last minute bugfix for the efivars code. The google EFI SMI driver maintains its own list of EFI variables but the efivars core was directly accessing a different (and in this case, uninitialised) list resulting in a crash.

----------------------------------------------------------------
Matt Fleming (1):
efivars: only check for duplicates on the registered list

 drivers/firmware/efivars.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
Matt Fleming, Intel Open Source Technology Center
#1 lore raw
Quoted 4 lines · Matt Fleming

Hi Peter, Linus,

I've got a small patch that fixes a crash for the Google folks and their EFI SMI driver, which was caused by dereferencing a garbage pointer.

Hmm. I already took this from the earlier email you sent. Did it change since?

Linus

#2 lore raw
Quoted 7 lines · Linus Torvalds
Quoted 4 lines · Matt Fleming

Hi Peter, Linus,

I've got a small patch that fixes a crash for the Google folks and their EFI SMI driver, which was caused by dereferencing a garbage pointer.

Hmm. I already took this from the earlier email you sent. Did it change since?

Nope, there hasn't been any change. I just didn't know whether you preferred to take the fix via email or a pull request.

Thanks for picking this up.

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center