drm/tegra: Include header drm/drm.h
Subsystems (5)
PATCH 1/1 drm/tegra: Include header drm/drm.h
Include definitions of used types by including drm/drm.h
Sparse output:/usr/include/drm/tegra_drm.h:21:
found __[us]{8,16,32,64} type without
#include <linux/types.h>--- include/uapi/drm/tegra_drm.h | 2 ++ 1 file changed, 2 insertions(+)
include/uapi/drm/tegra_drm.h +2 -0
@@ -17,6 +17,8 @@ #ifndef _UAPI_TEGRA_DRM_H_ #define _UAPI_TEGRA_DRM_H_ +#include <drm/drm.h> + struct drm_tegra_gem_create { __u64 size; __u32 flags;
Signature · 1 line
1.7.10.4
Quoted 17 lines · Emil Goode
Include definitions of used types by including
drm/drm.hSparse output:
/usr/include/drm/tegra_drm.h:21:found __[us]{8,16,32,64} type without #include <linux/types.h>Signed-off-by Emil Goode <[email protected]>--- include/uapi/drm/tegra_drm.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/drm/tegra_drm.h +0
-0
include/uapi/drm/tegra_drm.h line 21
Quoted 5 lines
include/uapi/drm/tegra_drm.h +2
-0@@ -17,6 +17,8 @@#ifndef _UAPI_TEGRA_DRM_H_#define _UAPI_TEGRA_DRM_H_ +#include <drm/drm.h> +
sparse complains about linux/types.h not being included, so I wonder if it makes more sense to include that instead of drm/drm.h. In fact I have a fix that does exactly that in a local branch and was going to put that into my fixes branch. It's a bit more lightweight.
On the other hand, some drivers already include drm/drm.h in the public header so I don't really have any objections to this patch.
Thierry
Hi Thierry,
I don't know this code well but the drm/drm.h has an #if def so that either linux/types.h is included or the __[us]* types are defined in a different way with the comment "One of the BSDs".
Also I sent a patch last year to include linux/types.h in exynos_drm.h but it now includes drm/drm.h instead.
Best regards,
Emil Goode
Quoted 33 lines · Thierry Reding
Quoted 17 lines · Emil Goode
Include definitions of used types by including
drm/drm.hSparse output:
/usr/include/drm/tegra_drm.h:21:found __[us]{8,16,32,64} type without #include <linux/types.h>Signed-off-by Emil Goode <[email protected]>--- include/uapi/drm/tegra_drm.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/drm/tegra_drm.h +0
-0include/uapi/drm/tegra_drm.h line 21
Quoted 5 lines
include/uapi/drm/tegra_drm.h +2
-0@@ -17,6 +17,8 @@#ifndef _UAPI_TEGRA_DRM_H_#define _UAPI_TEGRA_DRM_H_ +#include <drm/drm.h> +sparse complains about
linux/types.hnot being included, so I wonder if it makes more sense to include that instead ofdrm/drm.h. In fact I have a fix that does exactly that in a local branch and was going to put that into my fixes branch. It's a bit more lightweight.On the other hand, some drivers already include
drm/drm.hin the public header so I don't really have any objections to this patch.Thierry