Skip to contentSkip to conversation

regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

PATCH Applied Axel Lin 2 participants 3 messages Apr 24, 2013 – Apr 28, 2013 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit untouched may result in wrong voltage setting.

For example, currently switch voltage from 1400000 to 1300000 will set the voltage to 1800000 because the HI bit is still set.

---
 drivers/regulator/mc13892-regulator.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/regulator/mc13892-regulator.c +3 -3
index 9891aec..cc76c52 100644
@@ -465,13 +465,13 @@ static int mc13892_sw_regulator_set_voltage_sel(struct regulator_dev *rdev,
 	 */
 
 	if (mc13892_regulators[id].vsel_reg != MC13892_SWITCHERS0) {
+		mask |= MC13892_SWITCHERS0_SWxHI;
+
 		if (volt > 1375000) {
 			reg_value -= MC13892_SWxHI_SEL_OFFSET;
 			reg_value |= MC13892_SWITCHERS0_SWxHI;
-			mask |= MC13892_SWITCHERS0_SWxHI;
-		} else if (volt < 1100000) {
+		} else {
 			reg_value &= ~MC13892_SWITCHERS0_SWxHI;
-			mask |= MC13892_SWITCHERS0_SWxHI;
 		}
 	}
 
Signature · 1 line
1.7.10.4
maintainer Applied
#1 lore raw
Quoted 3 lines · Axel Lin

It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit untouched may result in wrong voltage setting.

Applied, thanks.

maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 3 lines · Axel Lin

It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit untouched may result in wrong voltage setting.

Applied, thanks.