ARM: cfi_flash: Avoid generation of unaligned accesses
PATCH 1/1 ARM: cfi_flash: Avoid generation of unaligned accesses
Packed structure cfi_qry contains unaligned 16- and 32-bits members, accessing which causes problems when cfi_flash driver is compiled with -munaligned-access option: flash initialization hangs, probably due to data error.
Since fixing the code to use some other way of accessing those fields seems quite expensive, just force the compiler to use -mno-unaligned-access.
--- drivers/mtd/Makefile | 3 +++ 1 file changed, 3 insertions(+)
drivers/mtd/Makefile +3 -0
@@ -46,6 +46,9 @@ all: $(LIB) $(LIB): $(obj).depend $(OBJS) $(call cmd_link_o_target, $(OBJS)) +# SEE README.arm-unaligned-accesses +$(obj)cfi_flash.o: CFLAGS += $(PLATFORM_NO_UNALIGNED) + ######################################################################### # defines $(obj).depend target
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: cfi_flash: Avoid generation of unaligned accesses
Dear Andrew Gabbasov,
Quoted 19 lines
Packed structure
cfi_qrycontains unaligned 16- and 32-bits members, accessing which causes problems whencfi_flashdriver is compiled with -munaligned-access option: flash initialization hangs, probably due to data error.Since fixing the code to use some other way of accessing those fields seems quite expensive, just force the compiler to use -mno-unaligned-access.
Signed-off-by Andrew Gabbasov <[email protected]>--- drivers/mtd/Makefile | 3 +++ 1 file changed, 3 insertions(+)drivers/mtd/Makefile +0
-0
drivers/mtd/Makefile all: $(LIB) · line 54
Quoted 9 lines
drivers/mtd/Makefile +3
-0@@ -46,6 +46,9 @@ all: $(LIB) $(LIB): $(obj).depend $(OBJS) $(call cmd_link_o_target, $(OBJS)) +# SEE README.arm-unaligned-accesses +$(obj)cfi_flash.o: CFLAGS += $(PLATFORM_NO_UNALIGNED) + ######################################################################### # defines $(obj).depend target
I'd say rather fix the structure than use this workaround. See, using
u8[3]
u16
will make unaligned access. The fix would be to split that u16 into two u8 and add a proper accessor. It'll be much larger effort, but it'd also be more correct.
Best regards,
Marek Vasut
Gabbasov
PATCH 1/1 ARM: cfi_flash: Avoid generation of unaligned accesses
Quoted 42 lines
From: Marek Vasut [marek.vasut at gmail.com]
Sent: Sunday, April 28, 2013 22:58
To: u-boot at lists.denx.de
Cc: Gabbasov, Andrew; Albert ARIBAUD; Tom Rini
Subject: Re: [U-Boot] [PATCH] ARM:cfi_flash: Avoid generation of unaligned accessesDear Andrew Gabbasov,
Quoted 19 lines
Packed structure
cfi_qrycontains unaligned 16- and 32-bits members, accessing which causes problems whencfi_flashdriver is compiled with -munaligned-access option: flash initialization hangs, probably due to data error.Since fixing the code to use some other way of accessing those fields seems quite expensive, just force the compiler to use -mno-unaligned-access.
Signed-off-by Andrew Gabbasov <[email protected]>--- drivers/mtd/Makefile | 3 +++ 1 file changed, 3 insertions(+)drivers/mtd/Makefile +0
-0drivers/mtd/Makefile all: $(LIB) · line 54
Quoted 9 lines
drivers/mtd/Makefile +3
-0@@ -46,6 +46,9 @@ all: $(LIB) $(LIB): $(obj).depend $(OBJS) $(call cmd_link_o_target, $(OBJS)) +# SEE README.arm-unaligned-accesses +$(obj)cfi_flash.o: CFLAGS += $(PLATFORM_NO_UNALIGNED) + ######################################################################### # defines $(obj).depend targetI'd say rather fix the structure than use this workaround. See, using
u8[3]
u16
Quoted 6 lines
will make unaligned access. The fix would be to split that u16 into two u8 and add a proper accessor. It'll be much larger effort, but it'd also be more correct.
Best regards,
Marek Vasut
Hi Marek,
Thank you for your response.
I was thinking about this way of fixing, but it seemed too require too much effort. However, after some closer look it turned out to be not quite difficult, since there are quite a few accesses to such unaligned fields. So, I made another fix and sent to separately to the list with Subject: "[U-Boot][PATCH] ARM: cfi_flash: Fix unaligned accesses to cfi_qry structure". Please, look at it, if it is OK from your point of view.
Thanks.
Best regards,
Andrew
Gabbasov
PATCH 1/1 ARM: cfi_flash: Avoid generation of unaligned accesses
Quoted 5 lines
From: Gabbasov, Andrew
Sent: Monday, April 29, 2013 13:40
To: Marek Vasut; u-boot at lists.denx.de
Cc: Albert ARIBAUD; Tom Rini
Subject: RE: [U-Boot] [PATCH] ARM:cfi_flash: Avoid generation of unaligned accesses
[ skipped ]
Quoted 10 lines
Hi Marek,
Thank you for your response.
I was thinking about this way of fixing, but it seemed too require too much effort. However, after some closer look it turned out to be not quite difficult, since there are quite a few accesses to such unaligned fields. So, I made another fix and sent to separately to the list with Subject: "[U-Boot][PATCH] ARM:
cfi_flash: Fix unaligned accesses tocfi_qrystructure". Please, look at it, if it is OK from your point of view.
Quoted 4 lines
Thanks.
Best regards,
Andrew
Any comments on that new fix?
Thanks.
Best regards,
Andrew