Skip to contentSkip to conversation

dlm_tool: Trimming garbages at in Expecting reply output

PATCH New Masatake YAMATO 2 participants 3 messages May 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dlm_tool: Trimming garbages at in Expecting reply output

The buffer used in "Expecting reply" of dlm_tool lockdebug output is used as C string (via printf %s) but not terminated with nul char.

---
 dlm/tool/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
dlm/tool/main.c +1 -1
index 4752008..a404be3 100644
@@ -822,7 +822,7 @@ static void do_waiters(char *name, struct summary *sum)
 		/* parse the resource name from the remainder of the line */
 		j = 0;
 		spaces = 0;
-
+		memset(rname, 0, sizeof(rname));
 		for (i = 0; i < LOCK_LINE_MAX; i++) {
 			if (line[i] == '\n')
 				break;
Signature · 1 line
1.7.11.7
#1 lore raw

PATCH 1/1 dlm_tool: Trimming garbages at in Expecting reply output

Quoted 2 lines · Masatake YAMATO

The buffer used in "Expecting reply" of dlm_tool lockdebug output is used as C string (via printf %s) but not terminated with nul char.

Yes, thanks. This was fixed for some time in dlm.git. I'm afraid we'll need to go through the bz process to fix in RHEL.
Dave

#2 lore raw

PATCH 1/1 dlm_tool: Trimming garbages at in Expecting reply output

Quoted 7 lines · Masatake YAMATO
Quoted 2 lines

The buffer used in "Expecting reply" of dlm_tool lockdebug output is used as C string (via printf %s) but not terminated with nul char.

Yes, thanks. This was fixed for some time in dlm.git. I'm afraid we'll need to go through the bz process to fix in RHEL.
Dave

Ugh. I should look at https://git.fedorahosted.org/git/dlm.git.
I refereed RHEL60 branch of https://git.fedorahosted.org/cgit/cluster.git/.

Masatake YAMATO