blockdev: Replace "undefined error" in qmp_block_resize
PATCH 1/1 blockdev: Replace "undefined error" in qmp_block_resize
We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system.
Signed-off-by Kevin Wolf <[email protected]>
--- blockdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
blockdev.c +4 -2
@@ -1118,6 +1118,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data)void qmp_block_resize (const char *device,int64_t size,Error **errp) {BlockDriverState *bs; +int ret; bs =bdrv_find (device);if (!bs) {
@@ -1133,7 +1134,8 @@ void qmp_block_resize(const char *device, int64_t size, Error **errp)/* complete all in-flight operations before resizing the device */ bdrv_drain_all (); -switch (bdrv_truncate (bs, size)) { + ret =bdrv_truncate (bs, size); +switch (ret) {case 0 :break ;case -ENOMEDIUM :
@@ -1149,7 +1151,7 @@ void qmp_block_resize(const char *device, int64_t size, Error **errp)error_set (errp,QERR_DEVICE_IN_USE , device);break ;default : -error_set (errp,QERR_UNDEFINED_ERROR ); +error_setg_errno (errp, -ret,"Could not resize" );break ; } }
Signature · 1 line
1.8.1.4
Quoted 8 lines · Kevin Wolf
We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system.
Signed-off-by Kevin Wolf <[email protected]>--- blockdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by Eric Blake <[email protected]>
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Stefan Hajnoczi
AppliedQuoted 8 lines · Kevin Wolf
We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system.
Signed-off-by Kevin Wolf <[email protected]>--- blockdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan