ARM: OMAP-USB: Fix possible memory leak
Subsystems (4)
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/usb-host.c +17 -4
@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;
@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;
@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config; ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }return ret; }
Signature · 1 line
1.8.1.5
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Quoted 50 lines · Alexander Shiyan
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 10 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }
Might be better to switch to devm_XXX managed functions?
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c +0
-0return ret; }Signature · 7 lines
1.8.1.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
Regards, Nishanth Menon
Quoted 52 lines · Alexander Shiyan
Quoted 51 lines
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?
If anyone can rewrite driver to use devm_xx, it would have been better. I'm not going to redo the patch yet, let it be so, I just showed a point for OMAP-developers.
Thanks.
---
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Hi,
Quoted 52 lines · Alexander Shiyan
Quoted 52 lines · Alexander Shiyan
Quoted 51 lines
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;
Quoted 11 lines
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?
I don't think it makes sense since the platform_device hasn't been registered yet.
Still, patch can be improved with proper goto labels instead of sprinkling different kfree() calls in every single error branch.
Quoted 3 lines
If anyone can rewrite driver to use
devm_xx, it would have been better. I'm not going to redo the patch yet, let it be so, I just showed a point for OMAP-developers.
fair enough.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130502/4c5991d0/attachment.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Quoted 70 lines · Felipe Balbi
Hi,
Quoted 52 lines · Alexander Shiyan
Quoted 52 lines · Alexander Shiyan
Quoted 51 lines
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;Quoted 11 lines
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?I don't think it makes sense since the
platform_devicehasn't been registered yet.
Quoted 8 lines
Still, patch can be improved with proper goto labels instead of sprinkling different
kfree()calls in every single error branch.Quoted 3 lines
If anyone can rewrite driver to use
devm_xx, it would have been better. I'm not going to redo the patch yet, let it be so, I just showed a point for OMAP-developers.fair enough.
Well, as long as this crap violates the driver model by using kfree() on a device... Devices are refcounted and must only be freed when the refcount drops to zero.
This is exactly why we have platform_device_alloc(), platform_device_register_full() and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.
Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Hi,
Quoted 72 lines · Russell King - ARM Linux
Quoted 72 lines
Quoted 50 lines
Quoted 50 lines
Quoted 50 lines
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;Quoted 11 lines
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?I don't think it makes sense since the
platform_devicehasn't been registered yet.Still, patch can be improved with proper goto labels instead of sprinkling different
kfree()calls in every single error branch.Quoted 3 lines
If anyone can rewrite driver to use
devm_xx, it would have been better. I'm not going to redo the patch yet, let it be so, I just showed a point for OMAP-developers.
Quoted 5 lines
Quoted 1 line
fair enough.
Well, as long as this crap violates the driver model by using
kfree()on a device... Devices are refcounted and must only be freed when the refcount drops to zero.
read the patch again, there's no kfree() on any device. There is a kfree of supplies, reg_data and config.
On top of that, the code being changed here doesn't even exist, so I wonder which tree is this code based off. usb-host.c has always being using omap_device_build() which internally calls platform_device_alloc().
Quoted 6 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a platform_device. Wrong as it is, it's not part of $SUBJECT.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/b244bb23/attachment.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Hi,
Quoted 10 lines · Felipe Balbi
Quoted 6 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a
platform_device. Wrong as it is, it's not part of $SUBJECT.
that line was added by Roger on commit 5ecd52e563f1e14f9cfe06130fbf9fdb73f227e8 (ARM: OMAP2+: omap-usb-host: Add usbhs_init_phys()).
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/4a947d27/attachment.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Quoted 7 lines · Felipe Balbi
Quoted 7 lines
Quoted 6 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
Quoted 7 lines
Quoted 3 lines
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a
platform_device. Wrong as it is, it's not part of $SUBJECT.that line was added by Roger on commit
5ecd52e563f1e14f9cfe06130fbf9fdb73f227e8(ARM: OMAP2+: omap-usb-host: Addusbhs_init_phys()).
forgot to add him to Cc, now done.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/45651a32/attachment-0001.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
In reply to Felipe BalbiQuoted 93 lines · Felipe Balbi
Hi,
Quoted 72 lines · Russell King - ARM Linux
Quoted 72 lines
Quoted 50 lines
Quoted 50 lines
Quoted 50 lines
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;Quoted 11 lines
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?I don't think it makes sense since the
platform_devicehasn't been registered yet.Still, patch can be improved with proper goto labels instead of sprinkling different
kfree()calls in every single error branch.Quoted 3 lines
If anyone can rewrite driver to use
devm_xx, it would have been better. I'm not going to redo the patch yet, let it be so, I just showed a point for OMAP-developers.Quoted 5 lines
Quoted 1 line
fair enough.
Well, as long as this crap violates the driver model by using
kfree()on a device... Devices are refcounted and must only be freed when the refcount drops to zero.read the patch again, there's no
kfree()on any device. There is a kfree of supplies,reg_dataand config.On top of that, the code being changed here doesn't even exist, so I wonder which tree is this code based off.
usb-host.chas always being usingomap_device_build()which internally callsplatform_device_alloc().Quoted 4 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.
Quoted 6 lines
Quoted 2 lines
Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a
platform_device. Wrong as it is, it's not part of $SUBJECT.
It's really simple. You do not use k*alloc with platform devices. And you reject any patch which contains that, and point it out to the patch author.
It really doesn't matter if there's a kfree or not. The fact is you do not allow it in any situation, because such bad practises get copied and then you end up with kfree's.
How about you gain an understanding of this stuff and why this stuff is soo "hot".
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Hi,
Quoted 4 lines · Russell King - ARM Linux
Quoted 4 lines
Quoted 4 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a
platform_device. Wrong as it is, it's not part of $SUBJECT.It's really simple. You do not use k*alloc with platform devices. And
agree, no discussions here
Quoted 9 lines
you reject any patch which contains that, and point it out to the patch author.
It really doesn't matter if there's a kfree or not. The fact is you do not allow it in any situation, because such bad practises get copied and then you end up with kfree's.
How about you gain an understanding of this stuff and why this stuff is soo "hot".
how about you look at the git log to figure out I had nothing to do with that original patch which added k*alloc to the pdev ?
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/624e77bc/attachment.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Quoted 25 lines · Felipe Balbi
Hi,
Quoted 4 lines · Russell King - ARM Linux
Quoted 4 lines
Quoted 4 lines
This is exactly why we have
platform_device_alloc(),platform_device_register_full()and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Would you like me to pass your details to gregkh for another one of his public humilation exercises over basic kernel programming stuff? :)
How about we pass yours for not reading the patch before flaming ? Note that $SUBJECT is *not* touching at all that line which kzallocs a
platform_device. Wrong as it is, it's not part of $SUBJECT.It's really simple. You do not use k*alloc with platform devices. And
agree, no discussions here
Quoted 7 lines
you reject any patch which contains that, and point it out to the patch author.
It really doesn't matter if there's a kfree or not. The fact is you do not allow it in any situation, because such bad practises get copied and then you end up with kfree's.
Quoted 5 lines
Quoted 2 lines
How about you gain an understanding of this stuff and why this stuff is soo "hot".
how about you look at the git log to figure out I had nothing to do with that original patch which added k*alloc to the pdev ?
How about you realise I haven't got time to fuck around like that at the moment, so in the interests of getting people to fix the glaring error I commented on it instead in a relevant thread in the hope that some prat like you would take notice and ask for it to be fixed by someone working on the driver.
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
In reply to Felipe BalbiQuoted 1 line · Felipe Balbi
How about we pass yours for not reading the patch before flaming ?
And another thing. If you want to be flamed, continue with that tone. The problem here is that *you* have not been flamed in the previous message. The previous message was all about pointing out an error in the code in a way that hopefully you will take notice of, because you showed no sign of taking any notice of my previous mail.
If you want to be a total dork, continue behaving as you currently are. There, *now* I *have* flamed you!
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Hi,
Quoted 11 lines · Russell King - ARM Linux
Quoted 1 line · Felipe Balbi
How about we pass yours for not reading the patch before flaming ?
And another thing. If you want to be flamed, continue with that tone. The problem here is that *you* have not been flamed in the previous message. The previous message was all about pointing out an error in the code in a way that hopefully you will take notice of, because you showed no sign of taking any notice of my previous mail.
If you want to be a total dork, continue behaving as you currently are. There, *now* I *have* flamed you!
what a load of crap. Just because it wasn't pointed out in my previous email doesn't automatically mean I haven't noticed. Anyway, I won't be doing this all day.
cheers
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130503/660b6d29/attachment-0001.sig>
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
Quoted 12 lines · Felipe Balbi
Hi,
Quoted 9 lines · Russell King - ARM Linux
Quoted 1 line · Felipe Balbi
How about we pass yours for not reading the patch before flaming ?
And another thing. If you want to be flamed, continue with that tone. The problem here is that *you* have not been flamed in the previous message. The previous message was all about pointing out an error in the code in a way that hopefully you will take notice of, because you showed no sign of taking any notice of my previous mail.
Quoted 6 lines
Quoted 2 lines
If you want to be a total dork, continue behaving as you currently are. There, *now* I *have* flamed you!
what a load of crap. Just because it wasn't pointed out in my previous email doesn't automatically mean I haven't noticed. Anyway, I won't be doing this all day.
Yes you are a load of crap *you* spout about people flaming you. Well, if you can't be bothered to acknowledge a problem then you can expect to get resends because it's not clear that the message has been received. And you do *not* call resends "flames" back to those who were kind enough put the effort in to tell you about them more than once.
That's just down right insulting and flame provoking. Which is exactly how we ended up here.
PATCH 1/1 ARM: OMAP-USB: Fix possible memory leak
In reply to Nishanth MenonQuoted 52 lines · Nishanth Menon
Quoted 51 lines · Alexander Shiyan
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/mach-omap2/usb-host.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)arch/arm/mach-omap2/usb-host.c +12
-3@@ -570,8 +570,10 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, supplies->dev_name = dev_id; reg_data =kzalloc (sizeof (*reg_data),GFP_KERNEL ); -if (!reg_data) +if (!reg_data) { +kfree (supplies);return -ENOMEM ; + } reg_data->constraints.valid_ops_mask =REGULATOR_CHANGE_STATUS ; reg_data->consumer_supplies = supplies;@@ -579,8 +581,11 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, config =kmemdup (&hsusb_reg_config,sizeof (hsusb_reg_config),GFP_KERNEL ); -if (!config) +if (!config) { +kfree (supplies); +kfree (reg_data);return -ENOMEM ; + } config->supply_name = name; config->gpio = gpio;@@ -589,17 +594,25 @@ static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply,/* create a regulator device */ pdev =kzalloc (sizeof (*pdev),GFP_KERNEL ); -if (!pdev) +if (!pdev) { +kfree (supplies); +kfree (reg_data); +kfree (config);return -ENOMEM ; + } pdev->id =PLATFORM_DEVID_AUTO ; pdev->name = reg_name; pdev->dev.platform_data = config;
Quoted 11 lines
arch/arm/mach-omap2/usb-host.c static int usbhs_add_regulator(char *name, char *dev_id, char *dev_supply, · line 615
Quoted 9 lines
arch/arm/mach-omap2/usb-host.c +5
-1ret =platform_device_register (pdev); -if (ret) +if (ret) {pr_err ("%s: Failed registering regulator %s for %s\n" , __func__, name, dev_id); +kfree (supplies); +kfree (reg_data); +kfree (config); + }Might be better to switch to
devm_XXXmanaged functions?
Oh god no. Stop this madness right now. Never kmalloc memory for platform devices. EVER.
There's an API provided to dynamically create platform devices. Use it!