Skip to contentSkip to conversation

virtio: don't expose u16 in userspace api

PATCH In review Stephen Hemminger 2 participants 2 messages May 4, 2013 – May 5, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio: don't expose u16 in userspace api

Programs using virtio headers outside of kernel will no longer build because u16 type does not exist in userspace. All user ABI must use __u16 typedef instead.

Bug introduce by:
commit 986a4f4d452dec004697f667439d27c3fda9c928
Author: Jason Wang <[email protected]>
Date: Fri Dec 7 07:04:56 2012 +0000

virtio_net: multiqueue support

---
Patch against -net but should go to stable for 3.9.1

include/uapi/linux/virtio_net.h +1 -1
@@ -191,7 +191,7 @@ struct virtio_net_ctrl_mac {
  * specified.
  */
 struct virtio_net_ctrl_mq {
-	u16 virtqueue_pairs;
+	__u16 virtqueue_pairs;
 };
 
 #define VIRTIO_NET_CTRL_MQ   4
maintainer
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Fri, 3 May 2013 17:49:41 -0700

Quoted 4 lines

Programs using virtio headers outside of kernel will no longer build because u16 type does not exist in userspace. All user ABI must use __u16 typedef instead.

Quoted 8 lines

Bug introduce by:
commit 986a4f4d452dec004697f667439d27c3fda9c928
Author: Jason Wang <[email protected]>
Date: Fri Dec 7 07:04:56 2012 +0000

virtio_net: multiqueue support

Applied and queued up for -stable.