Skip to contentSkip to conversation

Refactoring Freescale's iMX software revision levels

PATCH New Henk Fijnvandraat 4 participants 6 messages May 3, 2013 – May 5, 2013 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Refactoring Freescale's iMX software revision levels

imx-lib: bump to version 1.1.0

---
 package/imx-lib/imx-lib.mk |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
package/imx-lib/imx-lib.mk +13 -1
index c168c80..c398568 100644
@@ -1,10 +1,22 @@
 #############################################################
 #
+# freescale's imx-version-level
+#
+#############################################################
+
+# Current version level for a number of freescale software packages
+#
+# firmware-imx, imx-lib and gpu-viv-bin-mx6q
+
+IMX_VERSION_LEVEL = 1.1.0
+
+#############################################################
+#
 # imx-lib
 #
 #############################################################
 
-IMX_LIB_VERSION = 12.09.01
+IMX_LIB_VERSION = $(IMX_VERSION_LEVEL)
 # No official download site from freescale, just this mirror
 IMX_LIB_SITE    = http://download.ossystems.com.br/bsp/freescale/source
 IMX_LIB_LICENSE = LGPLv2.1+
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/2 Refactoring Freescale's iMX software revision levels

Sorry,

But I have to withdraw these patches.

Due to the sequence in which the .mk files are included IMX_VERSION_LEVEL is defined when imx-lib.mk is processed, while it is already needed for firmware-imx (and gpu-viv-bin-mx6q if it would be introduced)

Placing it in firmware-imx would do for now, but then no dependencies can be placed alphabetically before it later.

It appears we need some other mechanism to rule them all.

Henk

Op Vr, 3 mei, 2013 10:27 am schreef Henk Fijnvandraat:

Quoted 45 lines

imx-lib: bump to version 1.1.0

---
package/imx-lib/imx-lib.mk | 14 +++++++++++++- 1 file changed, 13
insertions(+), 1 deletion(-)

package/imx-lib/imx-lib.mk index renamed from package/imx-lib/imx-lib.mk +0 -0

c168c80..c398568 100644 --- a/package/imx-lib/imx-lib.mk +++ b/package/imx-lib/imx-lib.mk

package/imx-lib/imx-lib.mk index renamed from package/imx-lib/imx-lib.mk +13 -1
@@ -1,10 +1,22 @@
 #############################################################
 #
+# freescale's imx-version-level
+#
+#############################################################
+
+# Current version level for a number of freescale software packages
+#
+# firmware-imx, imx-lib and gpu-viv-bin-mx6q
+
+IMX_VERSION_LEVEL = 1.1.0
+
+#############################################################
+#
 # imx-lib
 #
 #############################################################
 
 
-IMX_LIB_VERSION = 12.09.01
+IMX_LIB_VERSION = $(IMX_VERSION_LEVEL)
 # No official download site from freescale, just this mirror

IMX_LIB_SITE = http://download.ossystems.com.br/bsp/freescale/source
IMX_LIB_LICENSE = LGPLv2.1+
--
1.7.10.4

_______________________________________________
buildroot mailing list buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/2 Refactoring Freescale's iMX software revision levels

Quoted 4 lines · H.Fijnvandraat at inter.nl.net

Sorry,

But I have to withdraw these patches.

Quoted 8 lines

Due to the sequence in which the .mk files are included IMX_VERSION_LEVEL is defined when imx-lib.mk is processed, while it is already needed for firmware-imx (and gpu-viv-bin-mx6q if it would be introduced)

Placing it in firmware-imx would do for now, but then no dependencies can be placed alphabetically before it later.

It appears we need some other mechanism to rule them all.

Ah, yes stupid of me. Normally the order of assignments doesn't matter,
but the generic-target contains an 'ifndef $(2)_VERSION'.

So the only solution is to collect the imx packages in an imx
subdirectory, like qt5. I've told Henk earlier that we try to avoid creating subdirectories in the package directory, but perhaps this is a good reason to do it. What do the others think?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/2 Refactoring Freescale's iMX software revision levels

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Arnout> Ah, yes stupid of me. Normally the order of assignments doesn't Arnout> matter, but the generic-target contains an 'ifndef $(2)_VERSION'.

Arnout> So the only solution is to collect the imx packages in an imx Arnout> subdirectory, like qt5. I've told Henk earlier that we try to Arnout> avoid creating subdirectories in the package directory, but Arnout> perhaps this is a good reason to do it. What do the others Arnout> think?

Yes, I guess this is the best option.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/2 Refactoring Freescale's iMX software revision levels

In reply to H.Fijnvandraat at inter.nl.net

Dear H.Fijnvandraat at inter.nl.net,

Quoted 11 lines · H.Fijnvandraat at inter.nl.net

But I have to withdraw these patches.

Due to the sequence in which the .mk files are included IMX_VERSION_LEVEL is defined when imx-lib.mk is processed, while it is already needed for firmware-imx (and gpu-viv-bin-mx6q if it would be introduced)

Placing it in firmware-imx would do for now, but then no dependencies can be placed alphabetically before it later.

It appears we need some other mechanism to rule them all.

This shouldn't matter because we're using '=' everywhere, so they are recursively expanded, which means that the values are expanded only when the value is actually needed. So the inclusion order shouldn't matter.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 2/2 firmware-imx-version: bump to version 1.1.0

In reply to Henk Fijnvandraat

(indirect version increase through refactoring)

---
 package/firmware-imx/firmware-imx.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/firmware-imx/firmware-imx.mk +1 -1
index 3b43bef..167eb35 100644
@@ -4,7 +4,7 @@
 #
 #############################################################
 
-FIRMWARE_IMX_VERSION = 12.09.01
+FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL)
 # No official download site from freescale, just this mirror
 FIRMWARE_IMX_SITE = http://download.ossystems.com.br/bsp/freescale/source
 FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
Signature · 1 line
1.7.10.4