mx23: Operate DDR voltage supply at 2.5V
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/3 mx23: Operate DDR voltage supply at 2.5V
From: Fabio Estevam <[email protected]>
After the recent fixes in the mx23 DDR setup, it is safe to operate DDR voltage at the recommended 2.5V voltage level again.
--- arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +2 -2
@@ -247,7 +247,7 @@ static void mx23_mem_setup_vddmem(void)struct mxs_power_regs *power_regs = (struct mxs_power_regs *)MXS_POWER_BASE ; - writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) | + writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) | POWER_VDDMEMCTRL_ENABLE_ILIMIT | POWER_VDDMEMCTRL_ENABLE_LINREG | POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,
@@ -255,7 +255,7 @@ static void mx23_mem_setup_vddmem(void)early_delay (10000 ); -writel ((0x12 <<POWER_VDDMEMCTRL_TRG_OFFSET ) | +writel ((0x10 <<POWER_VDDMEMCTRL_TRG_OFFSET ) |POWER_VDDMEMCTRL_ENABLE_LINREG , &power_regs->hw_power_vddmemctrl); }
Signature · 1 line
1.7.9.5
Fabio Estevam
reviewerPATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
--- board/freescale/mx23evk/spl_boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx23evk/spl_boot.c +1 -1
@@ -25,7 +25,7 @@#include <asm/arch/imx-regs.h> #include <asm/arch/sys_proto.h> -#define MUX_CONFIG_SSP1 (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP) +#define MUX_CONFIG_SSP1 (MXS_PAD_8MA | MXS_PAD_PULLUP)#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_PULLUP)const iomux_cfg_t iomux_setup[] = {
Signature · 1 line
1.7.9.5
PATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
Dear Fabio Estevam,
Quoted 6 lines
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>
None of them do, so you can wipe those altogether for all the #defines, no ?
Best regards,
Marek Vasut
Fabio Estevam
reviewerPATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
Quoted 10 lines · Marek Vasut
Dear Fabio Estevam,
Quoted 6 lines
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>None of them do, so you can wipe those altogether for all the #defines, no ?
Sorry, I cannot understand this comment.
PATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
Dear Fabio Estevam,
Quoted 8 lines · Marek Vasut
Quoted 7 lines
Dear Fabio Estevam,
Quoted 5 lines
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>None of them do, so you can wipe those altogether for all the #defines, no ?
Sorry, I cannot understand this comment.
None of the MX23 pins contain voltage selection bit, you can just remove them all.
Best regards,
Marek Vasut
Fabio Estevam
reviewerPATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
Quoted 2 lines · Marek Vasut
None of the MX23 pins contain voltage selection bit, you can just remove them all.
The mx23 EMI pins do have voltage select bit.
I just removed the voltage select bit from SSP pins.
What is wrong with this patch, please?
PATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
Dear Fabio Estevam,
Quoted 9 lines · Marek Vasut
Quoted 2 lines
None of the MX23 pins contain voltage selection bit, you can just remove them all.
The mx23 EMI pins do have voltage select bit.
I just removed the voltage select bit from SSP pins.
What is wrong with this patch, please?
Ah uh ... 4:37 am here, forget my rambling, sorry, my fault, good night.
Best regards,
Marek Vasut
PATCH 2/3 mx23evk: Do not set voltage selection bit for SSP pads
In reply to Fabio EstevamQuoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH 3/3 mx23_olinuxino: Do not set voltage selection bit for SSP pads
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
--- board/olimex/mx23_olinuxino/spl_boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/olimex/mx23_olinuxino/spl_boot.c +1 -1
@@ -30,7 +30,7 @@#include <asm/arch/sys_proto.h> #define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_PULLUP) -#define MUX_CONFIG_SSP (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP) +#define MUX_CONFIG_SSP (MXS_PAD_8MA | MXS_PAD_PULLUP)const iomux_cfg_t iomux_setup[] = {/* DUART */
Signature · 1 line
1.7.9.5
PATCH 3/3 mx23_olinuxino: Do not set voltage selection bit for SSP pads
Dear Fabio Estevam,
Quoted 6 lines
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>
I see ... I'd say just squash this and 2/3 .
Best regards,
Marek Vasut
PATCH 3/3 mx23_olinuxino: Do not set voltage selection bit for SSP pads
In reply to Fabio EstevamQuoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
mx23 SSP pad registers do not contain voltage selection bit, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/3 mx23: Operate DDR voltage supply at 2.5V
In reply to Fabio EstevamDear Fabio Estevam,
Quoted 6 lines
From: Fabio Estevam <[email protected]>
After the recent fixes in the mx23 DDR setup, it is safe to operate DDR voltage at the recommended 2.5V voltage level again.
Signed-off-by Fabio Estevam <[email protected]>
Is this a tripple revert ?
Stefano, you can apply this before applying the patches I complained weren't applied a few hours ago, it'll prevent merge conflict. Esp. this [PATCH] arm:
mx23: Fix VDDMEM misconfiguration
Quoted 18 lines
--- arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.cindex 41fb803..4ed197b 100644arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +1
-1@@ -247,7 +247,7 @@ static void mx23_mem_setup_vddmem(void)struct mxs_power_regs *power_regs = (struct mxs_power_regs *)MXS_POWER_BASE ; - writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) | + writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) | POWER_VDDMEMCTRL_ENABLE_ILIMIT | POWER_VDDMEMCTRL_ENABLE_LINREG | POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c static void mx23_mem_setup_vddmem(void) · line 261
Quoted 8 lines
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +1
-1@@ -255,7 +255,7 @@ static void mx23_mem_setup_vddmem(void)early_delay (10000 ); -writel ((0x12 <<POWER_VDDMEMCTRL_TRG_OFFSET ) | +writel ((0x10 <<POWER_VDDMEMCTRL_TRG_OFFSET ) |POWER_VDDMEMCTRL_ENABLE_LINREG , &power_regs->hw_power_vddmemctrl); }
Best regards,
Marek Vasut
PATCH 1/3 mx23: Operate DDR voltage supply at 2.5V
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
After the recent fixes in the mx23 DDR setup, it is safe to operate DDR voltage at the recommended 2.5V voltage level again.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================