Skip to contentSkip to conversation

tipc: add a bounds check in link_recv_changeover_msg()

PATCH Applied Dan Carpenter 2 participants 2 messages May 6, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tipc: add a bounds check in link_recv_changeover_msg()

The bearer_id here comes from skb->data and it can be a number from 0 to
7. The problem is that the ->links[] array has only 2 elements so I have added a range check.

---
This is static analysis work. I am not very familiar with this subsystem and I haven't tested this.

net/tipc/link.c +4 -1
index daa6080..3a6064b3 100644
@@ -2306,8 +2306,11 @@ static int link_recv_changeover_msg(struct tipc_link **l_ptr,
 	struct tipc_msg *tunnel_msg = buf_msg(tunnel_buf);
 	u32 msg_typ = msg_type(tunnel_msg);
 	u32 msg_count = msg_msgcnt(tunnel_msg);
+	u32 bearer_id = msg_bearer_id(tunnel_msg);
 
-	dest_link = (*l_ptr)->owner->links[msg_bearer_id(tunnel_msg)];
+	if (bearer_id >= MAX_BEARERS)
+		goto exit;
+	dest_link = (*l_ptr)->owner->links[bearer_id];
 	if (!dest_link)
 		goto exit;
 	if (dest_link = *l_ptr) {
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Mon, 6 May 2013 21:28:41 +0300

Quoted 5 lines

The bearer_id here comes from skb->data and it can be a number from 0 to
7. The problem is that the ->links[] array has only 2 elements so I have added a range check.

Applied.