ARM: imx: compile fix for hotplug.c
Subsystems (3)
PATCH 1/1 ARM: imx: compile fix for hotplug.c
Commit bca7a5a (ARM: cpu hotplug: remove majority of cache flushing from platforms) removes include of <asm/cacheflush.h> and hence discovers a few indirect inclusion and declaration problems as below.
CC arch/arm/mach-imx/hotplug.o
In file included from arch/arm/mach-imx/hotplug.c:16:0:arch/arm/mach-imx/common.h:100:29: warning: ?struct pt_regs? declared inside parameter list [enabled by default] arch/arm/mach-imx/common.h:100:29: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] arch/arm/mach-imx/common.h:101:29: warning: ?struct pt_regs? declared inside parameter list [enabled by default] arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_die?:arch/arm/mach-imx/hotplug.c:53:2: error: implicit declaration of function ?cpu_do_idle? [-Werror=implicit-function-declaration] arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_kill?:arch/arm/mach-imx/hotplug.c:58:26: error: ?jiffies? undeclared (first use in this function) arch/arm/mach-imx/hotplug.c:58:26: note: each undeclared identifier is reported only once for each function it appears in arch/arm/mach-imx/hotplug.c:58:2: error: implicit declaration of function ?msecs_to_jiffies? [-Werror=implicit-function-declaration] arch/arm/mach-imx/hotplug.c:61:3: error: implicit declaration of function ?time_after? [-Werror=implicit-function-declaration]
Fix them by adding the needed inclusion and declaration.
--- arch/arm/mach-imx/common.h | 1 + arch/arm/mach-imx/hotplug.c | 2 ++ 2 files changed, 3 insertions(+)
arch/arm/mach-imx/common.h +1 -0
@@ -12,6 +12,7 @@#define __ASM_ARCH_MXC_COMMON_H__struct platform_device ; +struct pt_regs ;struct clk ;enum mxc_cpu_pwr_mode ;
arch/arm/mach-imx/hotplug.c +2 -0
@@ -11,7 +11,9 @@*/ #include <linux/errno.h> +#include <linux/jiffies.h> #include <asm/cp15.h> +#include <asm/proc-fns.h> #include "common.h"
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: imx: compile fix for hotplug.c
Quoted 17 lines · Shawn Guo
Commit bca7a5a (ARM: cpu hotplug: remove majority of cache flushing from platforms) removes include of <
asm/cacheflush.h> and hence discovers a few indirect inclusion and declaration problems as below.CC
arch/arm/mach-imx/hotplug.o
In file included fromarch/arm/mach-imx/hotplug.c:16:0:arch/arm/mach-imx/common.h:100:29: warning: ?structpt_regs? declared inside parameter list [enabled by default]arch/arm/mach-imx/common.h:100:29: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]arch/arm/mach-imx/common.h:101:29: warning: ?structpt_regs? declared inside parameter list [enabled by default]arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_die?:arch/arm/mach-imx/hotplug.c:53:2: error: implicit declaration of function ?cpu_do_idle? [-Werror=implicit-function-declaration]arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_kill?:arch/arm/mach-imx/hotplug.c:58:26: error: ?jiffies? undeclared (first use in this function)arch/arm/mach-imx/hotplug.c:58:26: note: each undeclared identifier is reported only once for each function it appears inarch/arm/mach-imx/hotplug.c:58:2: error: implicit declaration of function ?msecs_to_jiffies? [-Werror=implicit-function-declaration]arch/arm/mach-imx/hotplug.c:61:3: error: implicit declaration of function ?time_after? [-Werror=implicit-function-declaration]
Quoted 3 lines
Fix them by adding the needed inclusion and declaration.
Signed-off-by Shawn Guo <[email protected]>
I found the same thing today, and there seems to be a similar problem for highbank.
Arnd
PATCH 1/1 ARM: imx: compile fix for hotplug.c
In reply to Shawn GuoHello Shawn,
Quoted 17 lines · Shawn Guo
Commit bca7a5a (ARM: cpu hotplug: remove majority of cache flushing from platforms) removes include of <
asm/cacheflush.h> and hence discovers a few indirect inclusion and declaration problems as below.CC
arch/arm/mach-imx/hotplug.o
In file included fromarch/arm/mach-imx/hotplug.c:16:0:arch/arm/mach-imx/common.h:100:29: warning: ?structpt_regs? declared inside parameter list [enabled by default]arch/arm/mach-imx/common.h:100:29: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]arch/arm/mach-imx/common.h:101:29: warning: ?structpt_regs? declared inside parameter list [enabled by default]arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_die?:arch/arm/mach-imx/hotplug.c:53:2: error: implicit declaration of function ?cpu_do_idle? [-Werror=implicit-function-declaration]arch/arm/mach-imx/hotplug.c: In function ?imx_cpu_kill?:arch/arm/mach-imx/hotplug.c:58:26: error: ?jiffies? undeclared (first use in this function)arch/arm/mach-imx/hotplug.c:58:26: note: each undeclared identifier is reported only once for each function it appears inarch/arm/mach-imx/hotplug.c:58:2: error: implicit declaration of function ?msecs_to_jiffies? [-Werror=implicit-function-declaration]arch/arm/mach-imx/hotplug.c:61:3: error: implicit declaration of function ?time_after? [-Werror=implicit-function-declaration]
Quoted 3 lines
Fix them by adding the needed inclusion and declaration.
Signed-off-by Shawn Guo <[email protected]>
I just sent an equivalent patch for that issue (so:
).
Is this patch already queued somewhere?
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 ARM: imx: compile fix for hotplug.c
Hi Uwe,
Quoted 2 lines · Uwe Kleine-K?nig
I just sent an equivalent patch for that issue (so:
Acked-by Uwe Kleine-K?nig <[email protected]>
Thanks.
Quoted 4 lines
).
Is this patch already queued somewhere?
I just resend it to Arnd for 3.10-rc1 inclusion.
Shawn