Add device tree support for NAND flash in am335x-evm
Subsystems (2)
v2 cover Add device tree support for NAND flash in am335x-evm
This patch series adds device tree support for NAND flash in am335x-evm. Also ELM node is populated in device tree and been used for BCH error correction in NAND flash part. Also this patch series ensures RBL ecc layout maintained in Linux kernel with BCH8 ecc scheme.
This patch series based on [1] and depends on [2].
2.mtd: devices: elm: Removes <xx> literals in elm DT node
https://lkml.org/lkml/2013/1/24/30
Philip Avinash (1):
ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Philip, Avinash (2):
ARM: dts: AM33XX: Add ELM node
ARM: dts: AM33XX: Add GPMC node
arch/arm/boot/dts/am335x-evm.dts | 98 +++++++++++++++++++++++++++++++++++++- arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++ 2 files changed, 117 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
PATCH v2 1/3 ARM: dts: AM33XX: Add ELM node
From: "Philip, Avinash" <[email protected]>
Add ELM data node to AM33XX device tree file.
---
Changes since v2:
- Replace <xx> literals to 52
- remove tab
arch/arm/boot/dts/am33xx.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/am33xx.dtsi +8 -0
@@ -389,5 +389,13 @@ mac-address = [ 00 00 00 00 00 00 ]; }; }; + + elm: elm@48080000 { + compatible = "ti,am3352-elm"; + reg = <0x48080000 0x2000>; + interrupts = <4>; + ti,hwmods = "elm"; + status = "disabled"; + }; }; };
Signature · 1 line
1.7.9.5
Re: [v2,1/3] ARM: dts: AM33XX: Add ELM node
Quoted 3 lines · Pekon
From: avinash philip <[email protected]>
From: "Philip, Avinash" <[email protected]>
From: line is repeated twice.
Quoted 6 lines
Add ELM data node to AM33XX device tree file.
Signed-off-by Philip Avinash <[email protected]>Acked-by Peter Korsgaard <[email protected]>Tested-by Pekon Gupta <[email protected]>
You should add your sign-off (instead of tested-by) since you are now in the submission path.
Thanks,
Sekhar
PATCH v2 2/3 ARM: dts: AM33XX: Add GPMC node
In reply to Philip AvinashFrom: "Philip, Avinash" <[email protected]>
Add GPMC data node to AM33XX device tree file.
---
Changes since v2:
- Change number of chip select to 7
arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm/boot/dts/am33xx.dtsi +12 -0
@@ -397,5 +397,17 @@ ti,hwmods = "elm"; status = "disabled"; }; + + gpmc: gpmc@50000000 { + compatible = "ti,am3352-gpmc"; + ti,hwmods = "gpmc"; + reg = <0x50000000 0x2000>; + interrupts = <100>; + num-cs = <7>; + num-waitpins = <2>; + #address-cells = <2>; + #size-cells = <1>; + status = "disabled"; + }; }; };
Signature · 1 line
1.7.9.5
Re: [PATCH v3,2/3] ARM: dts: AM33XX: Add GPMC node
Quoted 7 lines · Gupta, Pekon
From: "Philip, Avinash" <[email protected]>
Add GPMC data node to AM33XX device tree file.
Signed-off-by Philip Avinash <[email protected]>Acked-by Peter Korsgaard <[email protected]>Signed-off-by Pekon Gupta <[email protected]>
Thanks adding into omap-for-v3.10/dt-fixes.
Tony
Quoted 29 lines
---
Changes in v2:
- Change number of chip select to 7arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm/boot/dts/am33xx.dtsi +12
-0@@ -407,5 +407,17 @@ ti,hwmods = "elm"; status = "disabled"; }; + + gpmc: gpmc at 50000000 { + compatible = "ti,am3352-gpmc"; + ti,hwmods = "gpmc"; + reg = <0x50000000 0x2000>; + interrupts = <100>; + num-cs = <7>; + num-waitpins = <2>; + #address-cells = <2>; + #size-cells = <1>; + status = "disabled"; + }; }; };
PATCH v2 3/3 ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
In reply to Philip AvinashNAND flash connected in am335x-evm on GPMC controller. This patch adds device tree node in am3355-evm with GPMC contoller timing for NAND flash interface, NAND partition table, ECC scheme, elm handle id.
--- arch/arm/boot/dts/am335x-evm.dts | 98 +++++++++++++++++++++++++++++++++++++- 1 file changed, 97 insertions(+), 1 deletion(-)
arch/arm/boot/dts/am335x-evm.dts +97 -1
@@ -26,7 +26,8 @@ am33xx_pinmux: pinmux@44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>; matrix_keypad_s0: matrix_keypad_s0 { pinctrl-single,pins = <
@@ -44,6 +45,26 @@ 0x154 0x27 /* spi0_d0.gpio0_3, INPUT | MODE7 */ >; }; + + nandflash_pins_s0: nandflash_pins_s0 { + pinctrl-single,pins = < + 0x0 0x30 /* gpmc_ad0.gpmc_ad0, INPUT | PULLUP | MODE0 */ + 0x4 0x30 /* gpmc_ad1.gpmc_ad1, INPUT | PULLUP | MODE0 */ + 0x8 0x30 /* gpmc_ad2.gpmc_ad2, INPUT | PULLUP | MODE0 */ + 0xc 0x30 /* gpmc_ad3.gpmc_ad3, INPUT | PULLUP | MODE0 */ + 0x10 0x30 /* gpmc_ad4.gpmc_ad4, INPUT | PULLUP | MODE0 */ + 0x14 0x30 /* gpmc_ad5.gpmc_ad5, INPUT | PULLUP | MODE0 */ + 0x18 0x30 /* gpmc_ad6.gpmc_ad6, INPUT | PULLUP | MODE0 */ + 0x1c 0x30 /* gpmc_ad7.gpmc_ad7, INPUT | PULLUP | MODE0 */ + 0x70 0x30 /* gpmc_wait0.gpmc_wait0, INPUT | PULLUP | MODE0 */ + 0x74 0x37 /* gpmc_wpn.gpio0_30, INPUT | PULLUP | MODE7 */ + 0x7c 0x8 /* gpmc_csn0.gpmc_csn0, PULL DISA */ + 0x90 0x8 /* gpmc_advn_ale.gpmc_advn_ale, PULL DISA */ + 0x94 0x8 /* gpmc_oen_ren.gpmc_oen_ren, PULL DISA */ + 0x98 0x8 /* gpmc_wen.gpmc_wen, PULL DISA */ + 0x9c 0x8 /* gpmc_be0n_cle.gpmc_be0n_cle, PULL DISA */ + >; + }; }; ocp {
@@ -102,6 +123,81 @@ reg = <0x48>; }; }; + + elm: elm@48080000 { + status = "okay"; + }; + + gpmc: gpmc@50000000 { + status = "okay"; + ranges = <0 0 0x08000000 0x10000000>; /* CS0: NAND */ + + nand@0,0 { + reg = <0 0 0>; /* CS0, offset 0 */ + nand-bus-width = <8>; + ti,nand-ecc-opt = "bch8"; + + gpmc,sync-clk = <0>; + gpmc,cs-on = <0>; + gpmc,cs-rd-off = <44>; + gpmc,cs-wr-off = <44>; + gpmc,adv-on = <6>; + gpmc,adv-rd-off = <34>; + gpmc,adv-wr-off = <44>; + gpmc,we-off = <40>; + gpmc,oe-off = <54>; + gpmc,access = <64>; + gpmc,rd-cycle = <82>; + gpmc,wr-cycle = <82>; + gpmc,wr-access = <40>; + gpmc,wr-data-mux-bus = <0>; + + #address-cells = <1>; + #size-cells = <1>; + elm_id = <&elm>; + + /* MTD partition table */ + partition@0 { + label = "SPL1"; + reg = <0x00000000 0x000020000>; + }; + + partition@1 { + label = "SPL2"; + reg = <0x00020000 0x00020000>; + }; + + partition@2 { + label = "SPL3"; + reg = <0x00040000 0x00020000>; + }; + + partition@3 { + label = "SPL4"; + reg = <0x00060000 0x00020000>; + }; + + partition@4 { + label = "U-boot"; + reg = <0x00080000 0x001e0000>; + }; + + partition@5 { + label = "environment"; + reg = <0x00260000 0x00020000>; + }; + + partition@6 { + label = "Kernel"; + reg = <0x00280000 0x00500000>; + }; + + partition@7 { + label = "File-System"; + reg = <0x00780000 0x0F880000>; + }; + }; + }; }; vbat: fixedregulator@0 {
Signature · 1 line
1.7.9.5
Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 18 lines · Pekon
From: avinash philip <[email protected]>
NAND flash connected in am335x-evm on GPMC controller. This patch adds device tree node in am3355-evm with GPMC contoller timing for NAND flash interface, NAND partition table, ECC scheme, elm handle id.
Signed-off-by Philip Avinash <[email protected]>Tested-by Pekon Gupta <[email protected]>---
arch/arm/boot/dts/am335x-evm.dts| 98 +++++++++++++++++++++++++++++++++++++-1 file changed, 97 insertions(+), 1 deletion(-)arch/arm/boot/dts/am335x-evm.dts +0
-0
arch/arm/boot/dts/am335x-evm.dts line 30
Quoted 6 lines
arch/arm/boot/dts/am335x-evm.dts +2
-1@@ -26,7 +26,8 @@ am33xx_pinmux: pinmux at 44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>;
Why add this to the board level fallback (called pinctrl hogs, I think)? This can be part of nand node you added below so that the pinctrl will take effect when nand gets probed instead of all the time.
Thanks,
Sekhar
Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 21 lines · Sekhar Nori
Quoted 19 lines · Pekon
From: avinash philip <[email protected]>
NAND flash connected in am335x-evm on GPMC controller. This patch adds device tree node in am3355-evm with GPMC contoller timing for NAND flash interface, NAND partition table, ECC scheme, elm handle id.
Signed-off-by Philip Avinash <[email protected]>Tested-by Pekon Gupta <[email protected]>---
arch/arm/boot/dts/am335x-evm.dts| 98 +++++++++++++++++++++++++++++++++++++-1 file changed, 97 insertions(+), 1 deletion(-)arch/arm/boot/dts/am335x-evm.dts +0
-0@@ -26,7 +26,8 @@
Quoted 9 lines
arch/arm/boot/dts/am335x-evm.dts line 30
Quoted 5 lines
arch/arm/boot/dts/am335x-evm.dts +2
-1am33xx_pinmux: pinmux at 44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>;Why add this to the board level fallback (called pinctrl hogs, I think)? This can be part of nand node you added below so that the pinctrl will take effect when nand gets probed instead of all the time.
Yes we should have all the pinctrl entries under the related drivers. This makes it easy remux pins during runtime if needed, and also allows unloading pinctrl-single.ko for development.
Regards,
Tony
RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 11 lines
Quoted 10 lines
arch/arm/boot/dts/am335x-evm.dts line 30
Quoted 6 lines
arch/arm/boot/dts/am335x-evm.dts +2
-1am33xx_pinmux: pinmux at 44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>;Why add this to the board level fallback (called pinctrl hogs, I think)? This can be part of nand node you added below so that the pinctrl will take effect when nand gets probed instead of all the time.
Quoted 4 lines
Yes we should have all the pinctrl entries under the related drivers. This makes it easy remux pins during runtime if needed, and also allows unloading pinctrl-single.ko for development.
Yes, accepted. This has been already fixed in v3 of this patch set. If all fine, then please pull this for next merge..
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html (already pulled)
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
with regards, pekon
RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 19 lines
Quoted 12 lines
Quoted 11 lines
arch/arm/boot/dts/am335x-evm.dts line 30
Quoted 7 lines
arch/arm/boot/dts/am335x-evm.dts +2
-1am33xx_pinmux: pinmux at 44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>;Why add this to the board level fallback (called pinctrl hogs, I think)? This can be part of nand node you added below so that the pinctrl will take effect when nand gets probed instead of all the time.
Quoted 4 lines
Yes we should have all the pinctrl entries under the related drivers. This makes it easy remux pins during runtime if needed, and also allows unloading pinctrl-single.ko for development.
Yes, accepted. This has been already fixed in v3 of this patch set. If all fine, then please pull this for next merge..
Quoted 8 lines
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
with regards, pekon
Request you to please accept | provide feedbacks on this patch series. These are waiting acceptance since Jan-2013, and are necessary for DT based configs for board having NAND support.
with regards, pekon
Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Hi Pekon,
Quoted 26 lines · Pekon
Quoted 26 lines
Quoted 12 lines
Quoted 11 lines
arch/arm/boot/dts/am335x-evm.dts line 30
Quoted 7 lines
arch/arm/boot/dts/am335x-evm.dts +2
-1am33xx_pinmux: pinmux at 44e10800 { pinctrl-names = "default"; - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 + &nandflash_pins_s0>;Why add this to the board level fallback (called pinctrl hogs, I think)? This can be part of nand node you added below so that the pinctrl will take effect when nand gets probed instead of all the time.
Quoted 4 lines
Yes we should have all the pinctrl entries under the related drivers. This makes it easy remux pins during runtime if needed, and also allows unloading pinctrl-single.ko for development.
Yes, accepted. This has been already fixed in v3 of this patch set. If all fine, then please pull this for next merge..
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
Quoted 7 lines
Quoted 1 line
with regards, pekon
Request you to please accept | provide feedbacks on this patch series. These are waiting acceptance since Jan-2013, and are necessary for DT based configs for board having NAND support.
with regards, pekon
Sorry, I missed that series.
I'm applying it right now.
Thanks,
Benoit
RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 5 lines
Sorry, I missed that series.
I'm applying it right now.
No issues.. Please pick newer v4 versions of this series. Following are rebased, updated and tested on linux-3.10-rc3
[PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
[PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
[PATCH v4,2/3] (please skip this one)
instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
[PATCH v4,3/3] http://www.spinics.net/lists/linux-omap/msg91167.html
Thanks..
with regards, pekon
RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Quoted 7 lines
Quoted 4 lines
Sorry, I missed that series.
I'm applying it right now.
No issues.. Please pick newer v4 versions of this series. Following are rebased, updated and tested on linux-3.10-rc3
Quoted 8 lines
[PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
[PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
[PATCH v4,2/3] (please skip this one)
instead pick http://www.spinics.net/lists/linux-omap/msg91161.html[PATCH v4,3/3] (typo)
http://www.spinics.net/lists/linux-omap/msg91164.html
Quoted 8 lines
Thanks..
with regards, pekon______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
In reply to Gupta, PekonQuoted 7 lines · Pekon
Quoted 4 lines
Sorry, I missed that series.
I'm applying it right now.
No issues.. Please pick newer v4 versions of this series. Following are rebased, updated and tested on linux-3.10-rc3
Quoted 8 lines
[PATCH v4,0/3] http://www.spinics.net/lists/linux-omap/msg91165.html
[PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
[PATCH v4,2/3] (please skip this one)
instead pick http://www.spinics.net/lists/linux-omap/msg91161.html[PATCH v4,3/3] http://www.spinics.net/lists/linux-omap/msg91167.html
Could you please rebase on for_3.11/dts and repost the whole stuff. It looks like Tony already pulled the GPMC node, and the two other ones cannot apply anymore.
Thanks,
Benoit
Benoit,
Quoted 5 lines · Avinash
This patch series adds device tree support for NAND flash in am335x-evm. Also ELM node is populated in device tree and been used for BCH error correction in NAND flash part. Also this patch series ensures RBL ecc layout maintained in Linux kernel with BCH8 ecc scheme.
Quoted 7 lines
This patch series based on [1] and depends on [2].
2.mtd: devices: elm: Removes <xx> literals in elm DT node
https://lkml.org/lkml/2013/1/24/30
Can you accept this patch series so that NAND flash with BCH support for am335x-evm available in 3.9.
Thanks
Avinash
Quoted 15 lines
Philip Avinash (1):
ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evmPhilip, Avinash (2):
ARM: dts: AM33XX: Add ELM node
ARM: dts: AM33XX: Add GPMC nodearch/arm/boot/dts/am335x-evm.dts | 98 +++++++++++++++++++++++++++++++++++++- arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++ 2 files changed, 117 insertions(+), 1 deletion(-)Signature · 1 line
1.7.9.5