COMPACTION: bugfix of improper cache flush in MIGRATION code.
Subsystems (2)
PATCH 1/1 COMPACTION: bugfix of improper cache flush in MIGRATION code.
Page 'new' during MIGRATION can't be flushed by flush_cache_page(). Using flush_cache_page(vma, addr, pfn) is justified only if page is already placed in process page table, and that is done right after flush_cache_page(). But without it the arch function has no knowledge of process PTE and does nothing.
Besides that, flush_cache_page() flushes an application cache, kernel has a different page virtual address and dirtied it.
Replace it with flush_dcache_page(new) which is a proper usage.
Old page is flushed in try_to_unmap_one() before MIGRATION.
This bug takes place in Sead3 board with M14Kc MIPS CPU without cache aliasing (but Harvard arch - separate I and D cache) in tight memory environment (128MB) each 1-3days on SOAK test. It fails in cc1 during kernel build (SIGILL, SIGBUS, SIGSEG) if CONFIG_COMPACTION is switched ON.
Author: Leonid Yegoshin <[email protected]>
--- mm/migrate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/migrate.c +1 -1
@@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma, pte = arch_make_huge_pte(pte, vma, new, 0); }#endif -flush_cache_page (vma, addr,pte_pfn (pte)); +flush_dcache_page (new);set_pte_at (mm, addr, ptep, pte);if (PageHuge (new)) {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 11 lines · Leonid Yegoshin
Page 'new' during MIGRATION can't be flushed by
flush_cache_page(). Usingflush_cache_page(vma, addr, pfn)is justified only if page is already placed in process page table, and that is done right afterflush_cache_page(). But without it the arch function has no knowledge of process PTE and does nothing.Besides that,
flush_cache_page()flushes an application cache, kernel has a different page virtual address and dirtied it.Replace it with
flush_dcache_page(new)which is a proper usage.
Quoted 7 lines
Old page is flushed in
try_to_unmap_one()before MIGRATION.This bug takes place in Sead3 board with M14Kc MIPS CPU without cache aliasing (but Harvard arch - separate I and D cache) in tight memory environment (128MB) each 1-3days on SOAK test. It fails in cc1 during kernel build (SIGILL, SIGBUS, SIGSEG) if
CONFIG_COMPACTIONis switched ON.
Good catch!
Quoted 2 lines
Author: Leonid Yegoshin <[email protected]>
Signed-off-by Leonid Yegoshin <[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 13 lines · Leonid Yegoshin
Page 'new' during MIGRATION can't be flushed by
flush_cache_page(). Usingflush_cache_page(vma, addr, pfn)is justified only if page is already placed in process page table, and that is done right afterflush_cache_page(). But without it the arch function has no knowledge of process PTE and does nothing.Besides that,
flush_cache_page()flushes an application cache, kernel has a different page virtual address and dirtied it.Replace it with
flush_dcache_page(new)which is a proper usage.Old page is flushed in
try_to_unmap_one()before MIGRATION.
Quoted 8 lines
This bug takes place in Sead3 board with M14Kc MIPS CPU without cache aliasing (but Harvard arch - separate I and D cache) in tight memory environment (128MB) each 1-3days on SOAK test. It fails in cc1 during kernel build (SIGILL, SIGBUS, SIGSEG) if
CONFIG_COMPACTIONis switched ON.Author: Leonid Yegoshin <[email protected]>
Signed-off-by Leonid Yegoshin <[email protected]>
Signature · 8 lines
Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>