ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
Subsystems (3)
PATCH 1/1 ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state.
This patch configures the USE_RETENTION bit of ARM_L2_OPTION register so that it does not depend on MANUAL_L2RSTDISABLE_CONTROL of ARM_COMMON_OPTION register for L2RSTDISABLE signal.
---
Tested on arndale board on arm-soc next/soc branch.
arch/arm/mach-exynos/include/mach/regs-pmu.h | 1 + arch/arm/mach-exynos/pmu.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-exynos/include/mach/regs-pmu.h +1 -0
@@ -344,6 +344,7 @@#define EXYNOS5_FSYS_ARM_OPTION S5P_PMUREG(0x2208)#define EXYNOS5_ISP_ARM_OPTION S5P_PMUREG(0x2288)#define EXYNOS5_ARM_COMMON_OPTION S5P_PMUREG(0x2408) +#define EXYNOS5_ARM_L2_OPTION S5P_PMUREG(0x2608)#define EXYNOS5_TOP_PWR_OPTION S5P_PMUREG(0x2C48)#define EXYNOS5_TOP_PWR_SYSMEM_OPTION S5P_PMUREG(0x2CC8)#define EXYNOS5_JPEG_MEM_OPTION S5P_PMUREG(0x2F48)
arch/arm/mach-exynos/pmu.c +2 -3
@@ -228,6 +228,7 @@ static struct exynos_pmu_conf exynos5250_pmu_config[] = { { EXYNOS5_DIS_IRQ_ISP_ARM_CENTRAL_SYS_PWR_REG, { 0x0, 0x0, 0x0} }, { EXYNOS5_ARM_COMMON_SYS_PWR_REG, { 0x0, 0x0, 0x2} }, { EXYNOS5_ARM_L2_SYS_PWR_REG, { 0x3, 0x3, 0x3} }, + { EXYNOS5_ARM_L2_OPTION, { 0x10, 0x10, 0x0 } }, { EXYNOS5_CMU_ACLKSTOP_SYS_PWR_REG, { 0x1, 0x0, 0x1} }, { EXYNOS5_CMU_SCLKSTOP_SYS_PWR_REG, { 0x1, 0x0, 0x1} }, { EXYNOS5_CMU_RESET_SYS_PWR_REG, { 0x1, 0x1, 0x0} },
@@ -353,11 +354,9 @@ static void exynos5_init_pmu(void)/* * SKIP_DEACTIVATE_ACEACP_IN_PWDN_BITFIELD Enable -* MANUAL_L2RSTDISABLE_CONTROL_BITFIELD Enable */ tmp =__raw_readl (EXYNOS5_ARM_COMMON_OPTION ); - tmp |= (EXYNOS5_MANUAL_L2RSTDISABLE_CONTROL | -EXYNOS5_SKIP_DEACTIVATE_ACEACP_IN_PWDN ); + tmp |=EXYNOS5_SKIP_DEACTIVATE_ACEACP_IN_PWDN ;__raw_writel (tmp,EXYNOS5_ARM_COMMON_OPTION );/*
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
Quoted 57 lines · Inderpal Singh
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state.
This patch configures the
USE_RETENTIONbit ofARM_L2_OPTIONregister so that it does not depend onMANUAL_L2RSTDISABLE_CONTROLofARM_COMMON_OPTIONregister for L2RSTDISABLE signal.Signed-off-by Inderpal Singh <[email protected]>---
Tested on arndale board on arm-soc next/soc branch.
arch/arm/mach-exynos/include/mach/regs-pmu.h | 1 + arch/arm/mach-exynos/pmu.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-)arch/arm/mach-exynos/include/mach/regs-pmu.h +1
-0@@ -344,6 +344,7 @@#define EXYNOS5_FSYS_ARM_OPTION S5P_PMUREG(0x2208)#define EXYNOS5_ISP_ARM_OPTION S5P_PMUREG(0x2288)#define EXYNOS5_ARM_COMMON_OPTION S5P_PMUREG(0x2408) +#define EXYNOS5_ARM_L2_OPTION S5P_PMUREG(0x2608)#define EXYNOS5_TOP_PWR_OPTION S5P_PMUREG(0x2C48)#define EXYNOS5_TOP_PWR_SYSMEM_OPTION S5P_PMUREG(0x2CC8)#define EXYNOS5_JPEG_MEM_OPTION S5P_PMUREG(0x2F48)arch/arm/mach-exynos/pmu.c +2
-4@@ -228,6 +228,7 @@ static struct exynos_pmu_conf exynos5250_pmu_config[] = { { EXYNOS5_DIS_IRQ_ISP_ARM_CENTRAL_SYS_PWR_REG, { 0x0, 0x0, 0x0} }, { EXYNOS5_ARM_COMMON_SYS_PWR_REG, { 0x0, 0x0, 0x2} }, { EXYNOS5_ARM_L2_SYS_PWR_REG, { 0x3, 0x3, 0x3} }, + { EXYNOS5_ARM_L2_OPTION, { 0x10, 0x10, 0x0 } }, { EXYNOS5_CMU_ACLKSTOP_SYS_PWR_REG, { 0x1, 0x0, 0x1} }, { EXYNOS5_CMU_SCLKSTOP_SYS_PWR_REG, { 0x1, 0x0, 0x1} }, { EXYNOS5_CMU_RESET_SYS_PWR_REG, { 0x1, 0x1, 0x0} },@@ -353,11 +354,9 @@ static void exynos5_init_pmu(void)/* * SKIP_DEACTIVATE_ACEACP_IN_PWDN_BITFIELD Enable -* MANUAL_L2RSTDISABLE_CONTROL_BITFIELD Enable */ tmp =__raw_readl (EXYNOS5_ARM_COMMON_OPTION ); - tmp |= (EXYNOS5_MANUAL_L2RSTDISABLE_CONTROL | -EXYNOS5_SKIP_DEACTIVATE_ACEACP_IN_PWDN ); + tmp |=EXYNOS5_SKIP_DEACTIVATE_ACEACP_IN_PWDN ;__raw_writel (tmp,EXYNOS5_ARM_COMMON_OPTION );/* -- 1.7.9.5
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
working fine.
--
with warm regards,
Chander Kashyap
PATCH 1/1 ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
In reply to Inderpal SinghQuoted 8 lines · Inderpal Singh
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state.
This patch configures the
USE_RETENTIONbit ofARM_L2_OPTIONregister so that it does not depend onMANUAL_L2RSTDISABLE_CONTROLofARM_COMMON_OPTIONregister for L2RSTDISABLE signal.Signed-off-by Inderpal Singh <[email protected]>
I haven't seen any activity from Kgene on this, but it seems reasonably bad (and the fix is self-contained). Applying to arm-soc fixes branch.
-Olof
PATCH 1/1 ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
Quoted 5 lines · Olof Johansson
Quoted 3 lines · Inderpal Singh
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state.
Quoted 8 lines
Quoted 5 lines
This patch configures the
USE_RETENTIONbit ofARM_L2_OPTIONregister so that it does not depend onMANUAL_L2RSTDISABLE_CONTROLofARM_COMMON_OPTIONregister for L2RSTDISABLE signal.Signed-off-by Inderpal Singh <[email protected]>I haven't seen any activity from Kgene on this, but it seems reasonably bad
I spent time with my family last week...
Quoted 2 lines
(and the fix is self-contained). Applying to arm-soc fixes branch.
Anyway, thanks.
- Kukjin
PATCH 1/1 ARM: EXYNOS5: Fix kernel dump in AFTR idle mode
Quoted 12 lines · Kukjin Kim
Quoted 11 lines · Olof Johansson
Quoted 8 lines · Inderpal Singh
The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state.
This patch configures the
USE_RETENTIONbit ofARM_L2_OPTIONregister so that it does not depend onMANUAL_L2RSTDISABLE_CONTROLofARM_COMMON_OPTIONregister for L2RSTDISABLE signal.Signed-off-by Inderpal Singh <[email protected]>
Quoted 8 lines
Quoted 2 lines
I haven't seen any activity from Kgene on this, but it seems reasonably bad
I spent time with my family last week...
Quoted 2 lines
(and the fix is self-contained). Applying to arm-soc fixes branch.
Anyway, thanks.
No worries. :)
-Olof