Skip to contentSkip to conversation

Add pciutils to the console package

PATCH In review Sam Nelson 4 participants 6 messages May 10, 2013

lore
Share & tools
lore

Sam Nelson

author
#0 lore raw

PATCH 1/3 Add pciutils to the console package

---
 .../packagegroups/packagegroup-arago-console.bb    |    1 +
 1 file changed, 1 insertion(+)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
index 5a80064..930049a 100755
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
     i2c-tools \
     iproute2 \
     strace \
+    pciutils \
     "
 
 ARAGO_SDK_PREREQ = "\
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 7 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 5:47 AM
To: [email protected]
Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?

Also, I didn't see patches 2 and 3 of this set. Did I miss them?

Quoted 15 lines

---
.../packagegroups/packagegroup-arago-console.bb | 1 +

1 file changed, 1 insertion(+)
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-console.bb b/meta-arago- distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb ARAGO_UTILS = "\ · line 28

Quoted 4 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
    i2c-tools \
    iproute2 \
    strace \
+    pciutils \

You would need to bump the PR

Quoted 10 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +0 -1
    "
 
 ARAGO_SDK_PREREQ = "\
--

1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#2 lore raw

Thanks for the response.
Pciutils provides very basic utilities for pci, when you have pci interface supported in the platform. ( I guess this is common). There was customer request to have it in a minimal file system.

If it does not belong in here. Please suggest any alternate recipes where this will naturally belong.

There is only 1 patch, I wanted to send. The other patches are not relevant, please ignore.

With regards,
sam

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 10, 2013 9:26 AM
To: Nelson, Sam; [email protected]
Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Quoted 6 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 5:47 AM
To: [email protected]
Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?

Also, I didn't see patches 2 and 3 of this set. Did I miss them?

Quoted 15 lines

---
.../packagegroups/packagegroup-arago-console.bb | 1 +

1 file changed, 1 insertion(+)
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-console.bb b/meta-arago- distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb ARAGO_UTILS = "\ · line 28

Quoted 4 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
    i2c-tools \
    iproute2 \
    strace \
+    pciutils \

You would need to bump the PR

Quoted 10 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +0 -1
    "
 
 ARAGO_SDK_PREREQ = "\
--

1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#3 lore raw

Not all machines support PCI so it isn't a good fit to force all machines to include this utility.

Use something like below:
ARAGO_UTILS_append_<machine> = "pci"

This will insure only the machine you care about is picking up this utility.

You also forgot to bump the PR.

Quoted 76 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 8:44 AM
To: Maupin, Chase; [email protected]
Subject: Re: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Thanks for the response.
Pciutils provides very basic utilities for pci, when you have pci interface supported in the platform. ( I guess this is common). There was customer request to have it in a minimal file system.

If it does not belong in here. Please suggest any alternate recipes where this will naturally belong.

There is only 1 patch, I wanted to send. The other patches are not relevant, please ignore.

With regards,
sam

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 10, 2013 9:26 AM
To: Nelson, Sam; [email protected]
Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Quoted 6 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 5:47 AM
To: [email protected]
Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?

Also, I didn't see patches 2 and 3 of this set. Did I miss them?

Quoted 15 lines

---
.../packagegroups/packagegroup-arago-console.bb | 1 +

1 file changed, 1 insertion(+)
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-console.bb b/meta-arago- distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb ARAGO_UTILS = "\ · line 28

Quoted 4 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
    i2c-tools \
    iproute2 \
    strace \
+    pciutils \

You would need to bump the PR

Quoted 10 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +0 -1
    "
 
 ARAGO_SDK_PREREQ = "\
--

1.7.9.5

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

#4 lore raw
In reply to Nelson, Sam

Sam,

See below.

Quoted 40 lines · Sam

Thanks for the response.
Pciutils provides very basic utilities for pci, when you have pci interface supported in the platform. ( I guess this is common). There was customer request to have it in a minimal file system.

If it does not belong in here. Please suggest any alternate recipes where this will naturally belong.

There is only 1 patch, I wanted to send. The other patches are not relevant, please ignore.

With regards,
sam

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 10, 2013 9:26 AM
To: Nelson, Sam; [email protected]
Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Quoted 6 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 5:47 AM
To: [email protected]
Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?

Also, I didn't see patches 2 and 3 of this set. Did I miss them?

Quoted 6 lines

---
.../packagegroups/packagegroup-arago-console.bb | 1 +

1 file changed, 1 insertion(+)
Quoted 13 lines

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb ARAGO_UTILS = "\ · line 28

Quoted 13 lines
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-console.bb b/meta-arago- distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
    i2c-tools \
    iproute2 \
    strace \
+    pciutils \
    ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \

And don't forget to add "pci" to the list of MACHINE_FEATURES for your machine "keystone-evm" or better yet to your SOC "keystone", if it's a common peripheral for all Keystone devices.

Quoted 1 line

You would need to bump the PR

Agree, make sure you bump PR on every recipe change.

Signature · 1 line
Denys
#5 lore raw

Oh, and the commit message should be of the proper format:

packagegroup-arago-console: add pciutils

Please see this past post about the same:
http://arago-project.org/pipermail/meta-arago/2013-May/001373.html

Signature · 1 line
Denys
Quoted 75 lines · Denys Dmytriyenko

Sam,

See below.

Quoted 40 lines · Sam

Thanks for the response.
Pciutils provides very basic utilities for pci, when you have pci interface supported in the platform. ( I guess this is common). There was customer request to have it in a minimal file system.

If it does not belong in here. Please suggest any alternate recipes where this will naturally belong.

There is only 1 patch, I wanted to send. The other patches are not relevant, please ignore.

With regards,
sam

-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 10, 2013 9:26 AM
To: Nelson, Sam; [email protected]
Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Quoted 6 lines

-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Nelson, Sam
Sent: Friday, May 10, 2013 5:47 AM
To: [email protected]
Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package

Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?

Also, I didn't see patches 2 and 3 of this set. Did I miss them?

Quoted 6 lines

---
.../packagegroups/packagegroup-arago-console.bb | 1 +

1 file changed, 1 insertion(+)
Quoted 13 lines

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb ARAGO_UTILS = "\ · line 28

Quoted 13 lines
(quoted diff) +0 -0

core/packagegroups/packagegroup-arago-console.bb b/meta-arago- distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup- arago-console.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +1 -0
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
    i2c-tools \
    iproute2 \
    strace \
+    pciutils \
    ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \

And don't forget to add "pci" to the list of MACHINE_FEATURES for your machine "keystone-evm" or better yet to your SOC "keystone", if it's a common peripheral for all Keystone devices.

Quoted 1 line

You would need to bump the PR

Agree, make sure you bump PR on every recipe change.

Signature · 5 lines
Denys
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago