Skip to contentSkip to conversation

Correct path error in package/freescale-imx/Config.in

PATCH New Henk Fijnvandraat 2 participants 2 messages May 10, 2013 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Correct path error in package/freescale-imx/Config.in

---
 package/freescale-imx/Config.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/freescale-imx/Config.in +1 -1
index 1f60192..8d0e347 100644
@@ -11,6 +11,6 @@ menuconfig BR2_PACKAGE_IMX
 
 
 if BR2_PACKAGE_IMX
-source "package/imx-lib/Config.in"
+source "package/freescale-imx/imx-lib/Config.in"
 source "package/freescale-imx/firmware-imx/Config.in"
 endif
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 Correct path error in package/freescale-imx/Config.in

Dear Henk Fijnvandraat,

Quoted 10 lines · Henk Fijnvandraat
---
 package/freescale-imx/Config.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/freescale-imx/Config.in +0 -0
index 1f60192..8d0e347 100644

package/freescale-imx/Config.in menuconfig BR2_PACKAGE_IMX · line 16

Quoted 7 lines
package/freescale-imx/Config.in +1 -1
@@ -11,6 +11,6 @@ menuconfig BR2_PACKAGE_IMX
 
 
 if BR2_PACKAGE_IMX
-source "package/imx-lib/Config.in"
+source "package/freescale-imx/imx-lib/Config.in"
 source "package/freescale-imx/firmware-imx/Config.in"
 endif

You shouldn't send just a fixup patch like this. When you make a mistake in a patch series, you have to send a new version of the entire patch series. Alternatively, you can reply to your own patches, say that you made a mistake and explain which one, and say that you'll resend the patch series a little bit later, once people will have had the time to review your patches, so that you can resend with more comments taken into account.

Also, when you send the same patch series multiple times, there should be a version number in the patch titles, and a small changelog in the cover letter. To generate your patches:

	git format-patch --cover --subject-prefix="PATCH vX"

where X will be replaced by the version of your patches.

Then, edit 0000-cover-letter.patch to include a global description of your patch series, and the list of changes from one revision to another. To do this, I generally keep a file called <branch>-cover-letter.txt for each branch I'm currently working on, in which I keep the cover letter that I update before sending a new version. This way, I don't have to rewrite the entire cover letter everytime.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com