freescale-imx directory patches
Ok, next attempt at getting this right ;-)
Henk
PATCH 1/3 Add package directory freescale-imx
The freescale-imx directory is intended to contain all freescale i.MXyy related packages, together with their download site and version info
--- package/Config.in | 1 + package/freescale-imx/Config.in | 14 ++++++++++++++ package/freescale-imx/freescale.mk | 13 +++++++++++++ 3 files changed, 28 insertions(+) create mode 100644 package/freescale-imx/Config.in create mode 100644 package/freescale-imx/freescale.mk
package/Config.in +1 -0
@@ -212,6 +212,7 @@ source "package/xfsprogs/Config.in" endmenu menu "Hardware handling" +source "package/freescale-imx/Config.in" menu "Misc devices firmwares" source "package/b43-firmware/Config.in" source "package/firmware-imx/Config.in"
package/freescale-imx/Config.in new file +14 -0
@@ -0,0 +1,14 @@ +comment "freescale-imx is only relevant for the i.MXxx series from Freescale" + depends on BR2_arm + +menuconfig BR2_PACKAGE_IMX + bool "freescale-imx" + depends on BR2_arm + help + This option enables the selection of some packages specific for + the i.MXxx series of processors from Freescale. + freescale-imx needs an imx-specific kernel to be built + + +if BR2_PACKAGE_IMX +endif
package/freescale-imx/freescale.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# freescale-imx +# +############################################################# + +IMX_VERSION_LEVEL = 1.1.0 + +# No official download site from freescale, just this mirror +IMX_MIRROR_SITE = http://download.ossystems.com.br/bsp/freescale/source + +include package/freescale-imx/*/*.mk +
Signature · 1 line
1.7.10.4
PATCH 1/3 Add package directory freescale-imx
Quoted 30 lines · Henk Fijnvandraat
The freescale-imx directory is intended to contain all freescale i.MXyy related packages, together with their download site and version info
Signed-off-by Henk Fijnvandraat <[email protected]>--- package/Config.in | 1 + package/freescale-imx/Config.in | 14 ++++++++++++++ package/freescale-imx/freescale.mk | 13 +++++++++++++ 3 files changed, 28 insertions(+)create mode 100644 package/freescale-imx/Config.in create mode 100644
package/freescale-imx/freescale.mkpackage/Config.in +1
-0@@ -212,6 +212,7 @@ source "package/xfsprogs/Config.in" endmenu menu "Hardware handling" +source "package/freescale-imx/Config.in" menu "Misc devices firmwares" source "package/b43-firmware/Config.in" source "package/firmware-imx/Config.in"package/freescale-imx/Config.in new file +0
-0
package/freescale-imx/Config.in line 2
Quoted 2 lines
package/freescale-imx/Config.in new file +2
-0@@ -0,0 +1,14 @@ +comment "freescale-imx is only relevant for the i.MXxx series from Freescale" + depends on BR2_arm
This comment is not needed, the fact that it's called freescale-imx is
pretty self-explanatory.
package/freescale-imx/Config.in line 5
Quoted 3 lines
package/freescale-imx/Config.in new file +3
-0+ +menuconfig BR2_PACKAGE_IMX + bool "freescale-imx"
Also here it can be a more verbose prompt, like:
bool "Freescale i.MX specific packages"
Quoted 15 lines
package/freescale-imx/Config.in new file +9
-0+ depends on BR2_arm + help + This option enables the selection of some packages specific for + the i.MXxx series of processors from Freescale. + freescale-imx needs an imx-specific kernel to be built + + +if BR2_PACKAGE_IMX +endifpackage/freescale-imx/freescale.mk new file +0
-0
package/freescale-imx/freescale.mk line 10
Quoted 10 lines
package/freescale-imx/freescale.mk new file +10
-0@@ -0,0 +1,13 @@ +############################################################# +# +# freescale-imx +# +############################################################# + +IMX_VERSION_LEVEL = 1.1.0 + +# No official download site from freescale, just this mirror +IMX_MIRROR_SITE = http://download.ossystems.com.br/bsp/freescale/source
We normally give let make variables begin with the uppercase'd package
(or directory) name - though there are exceptions. But in this case, I think it's a good idea to call it
FREESCALE_IMX_VERSION = 1.1.0FREESCALE_IMX_SITE = ...
Regards,
Arnout
Quoted 4 lines
package/freescale-imx/freescale.mk new file +3
-0+ +include package/freescale-imx/*/*.mk +
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 2/3 Move and refactor package imx-lib to the freescale-imx directory
In reply to Henk FijnvandraatWhen moved, the version and download site are set to those specified in the freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0
---
package/Config.in | 1 -
package/freescale-imx/Config.in | 1 +
package/{ => freescale-imx}/imx-lib/Config.in | 0
package/{ => freescale-imx}/imx-lib/imx-lib.mk | 5 ++---
4 files changed, 3 insertions(+), 4 deletions(-)
rename package/{ => freescale-imx}/imx-lib/Config.in (100%)
rename package/{ => freescale-imx}/imx-lib/imx-lib.mk (86%)package/Config.in +0 -1
@@ -460,7 +460,6 @@ endmenu menu "Hardware handling" source "package/ccid/Config.in" -source "package/imx-lib/Config.in" source "package/lcdapi/Config.in" source "package/libaio/Config.in" source "package/libatasmart/Config.in"
package/freescale-imx/Config.in +1 -0
@@ -11,4 +11,5 @@ menuconfig BR2_PACKAGE_IMX if BR2_PACKAGE_IMX +source "package/imx-lib/Config.in" endif
package/freescale-imx/imx-lib/Config.in renamed from package/imx-lib/Config.in +0 -0
package/freescale-imx/imx-lib/imx-lib.mk renamed from package/imx-lib/imx-lib.mk +2 -3
@@ -4,9 +4,8 @@ # ############################################################# -IMX_LIB_VERSION = 12.09.01 -# No official download site from freescale, just this mirror -IMX_LIB_SITE = http://download.ossystems.com.br/bsp/freescale/source +FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL) +FIRMWARE_IMX_SITE = $(IMX_MIRROR_SITE) IMX_LIB_LICENSE = LGPLv2.1+ # No license file included
Signature · 1 line
1.7.10.4
PATCH 2/3 Move and refactor package imx-lib to the freescale-imx directory
Dear Henk Fijnvandraat,
package/freescale-imx/imx-lib/imx-lib.mk line 8
Quoted 5 lines · Henk Fijnvandraat
package/freescale-imx/imx-lib/imx-lib.mk renamed from package/imx-lib/imx-lib.mk +2
-3-IMX_LIB_VERSION = 12.09.01 -# No official download site from freescale, just this mirror -IMX_LIB_SITE = http://download.ossystems.com.br/bsp/freescale/source +FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL) +FIRMWARE_IMX_SITE = $(IMX_MIRROR_SITE)
This is wrong, it should be IMX_LIB_VERSION and IMX_LIB_SITE.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 2/3 Move and refactor package imx-lib to the freescale-imx directory
In reply to Henk FijnvandraatQuoted 3 lines · Henk Fijnvandraat
When moved, the version and download site are set to those specified in the freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0
That version bump should be in the first line of the commit message. So
something like:
imx-lib: refactor to freescale-imx directory and bump version
Use the freescale-imx version and download site, which implicitly bumps the version from 12.09.01 to 1.1.0.
Quoted 2 lines
Signed-off-by Henk Fijnvandraat<[email protected]>
With that done and after modifying the variables as I suggested, you
can add my
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 3/3 Move and refactor package firmware-imx to the freescale-imx directory
In reply to Henk FijnvandraatWhen moved, the version and download site are set to those specified in the freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0
---
package/Config.in | 1 -
package/freescale-imx/Config.in | 1 +
package/{ => freescale-imx}/firmware-imx/Config.in | 0
package/{ => freescale-imx}/firmware-imx/firmware-imx.mk | 7 +++----
4 files changed, 4 insertions(+), 5 deletions(-)
rename package/{ => freescale-imx}/firmware-imx/Config.in (100%)
rename package/{ => freescale-imx}/firmware-imx/firmware-imx.mk (85%)package/Config.in +0 -1
@@ -215,7 +215,6 @@ menu "Hardware handling" source "package/freescale-imx/Config.in" menu "Misc devices firmwares" source "package/b43-firmware/Config.in" -source "package/firmware-imx/Config.in" source "package/linux-firmware/Config.in" source "package/rpi-firmware/Config.in" source "package/ux500-firmware/Config.in"
package/freescale-imx/Config.in +1 -0
@@ -12,4 +12,5 @@ menuconfig BR2_PACKAGE_IMX if BR2_PACKAGE_IMX source "package/imx-lib/Config.in" +source "package/freescale-imx/firmware-imx/Config.in" endif
package/freescale-imx/firmware-imx/Config.in renamed from package/firmware-imx/Config.in +0 -0
package/freescale-imx/firmware-imx/firmware-imx.mk renamed from package/firmware-imx/firmware-imx.mk +3 -4
@@ -1,12 +1,11 @@ ############################################################# # -# buildroot makefile for firmware-imx +# firmware-imx # ############################################################# -FIRMWARE_IMX_VERSION = 12.09.01 -# No official download site from freescale, just this mirror -FIRMWARE_IMX_SITE = http://download.ossystems.com.br/bsp/freescale/source +FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL) +FIRMWARE_IMX_SITE = $(IMX_MIRROR_SITE) FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \ Atheros license (ath6k)
Signature · 1 line
1.7.10.4
PATCH 3/3 Move and refactor package firmware-imx to the freescale-imx directory
Quoted 5 lines · Henk Fijnvandraat
When moved, the version and download site are set to those specified in the freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0Signed-off-by Henk Fijnvandraat<[email protected]>
Same comment as for imx-lib, and also my
(after changing variable names).
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Dear Henk Fijnvandraat,
Quoted 1 line · Henk Fijnvandraat
Ok, next attempt at getting this right ;-)
I've taken your patches, made a few minor modifications, built-tested them against a Freescale i.MX6 kernel. They are now part of a branch that I will push to Peter at the end of the day.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com