Skip to contentSkip to conversation

ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

PATCH New Tony Lindgren 2 participants 4 messages May 11, 2013 – May 16, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards) added support for MUSB on omap3 for device tree, but added the interrupts the wrong way probably as they were copied from the omap4.dtsi file. On omap3 we have TI specific interrupt controller, not GIC.

Fix this by specifying the interrupt following the TI INTC binding.

Without this fix MUSB won't work as it is trying to use irq0 instead of irq92.

arch/arm/boot/dts/omap3.dtsi +1 -1
@@ -516,7 +516,7 @@
 		usb_otg_hs: usb_otg_hs at 480ab000 {
 			compatible = "ti,omap3-musb";
 			reg = <0x480ab000 0x1000>;
-			interrupts = <0 92 0x4>, <0 93 0x4>;
+			interrupts = <92>, <93>;
 			interrupt-names = "mc", "dma";
 			ti,hwmods = "usb_otg_hs";
 			multipoint = <1>;
#1 lore raw

PATCH 1/1 ARM: dts: Fix musb interrupt for device tree booting

Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards) added support for MUSB on omap3 for device tree, but added the interrupts the wrong way probably as they were copied from the omap4.dtsi file. On omap3 we have TI specific interrupt controller, not GIC.

Fix this by specifying the interrupt following the TI INTC binding.

Without this fix MUSB won't work as it is trying to use irq0 instead of irq92.

---
Sorry had the wrong subject in the previous mail. That was for the breaking commit. Here's the patch again with correct subject.

arch/arm/boot/dts/omap3.dtsi +1 -1
@@ -516,7 +516,7 @@
 		usb_otg_hs: usb_otg_hs at 480ab000 {
 			compatible = "ti,omap3-musb";
 			reg = <0x480ab000 0x1000>;
-			interrupts = <0 92 0x4>, <0 93 0x4>;
+			interrupts = <92>, <93>;
 			interrupt-names = "mc", "dma";
 			ti,hwmods = "usb_otg_hs";
 			multipoint = <1>;
#2 lore raw

PATCH 1/1 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

In reply to Tony Lindgren
Quoted 6 lines · Tony Lindgren

Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards) added support for MUSB on omap3 for device tree, but added the interrupts the wrong way probably as they were copied from the omap4.dtsi file. On omap3 we have TI specific interrupt controller, not GIC.

Quoted 7 lines

Fix this by specifying the interrupt following the TI INTC binding.

Without this fix MUSB won't work as it is trying to use irq0 instead of irq92.

Tested in beagleboard-xm

Quoted 13 lines
arch/arm/boot/dts/omap3.dtsi +1 -1
@@ -516,7 +516,7 @@
  		usb_otg_hs: usb_otg_hs at 480ab000 {
  			compatible = "ti,omap3-musb";
  			reg = <0x480ab000 0x1000>;
-			interrupts = <0 92 0x4>, <0 93 0x4>;
+			interrupts = <92>, <93>;
  			interrupt-names = "mc", "dma";
  			ti,hwmods = "usb_otg_hs";
  			multipoint = <1>;
#3 lore raw

PATCH 1/1 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

Quoted 10 lines · Kishon Vijay Abraham I
Quoted 9 lines · Tony Lindgren

Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards) added support for MUSB on omap3 for device tree, but added the interrupts the wrong way probably as they were copied from the omap4.dtsi file. On omap3 we have TI specific interrupt controller, not GIC.

Fix this by specifying the interrupt following the TI INTC binding.

Quoted 7 lines
Quoted 4 lines

Without this fix MUSB won't work as it is trying to use irq0 instead of irq92.

Tested in beagleboard-xm

Oops thanks, sorry I already pushed it out into omap-for-v3.10/dt-fixes before noticing your tested-by.

Regards,

Tony

Quoted 13 lines
Quoted 12 lines
arch/arm/boot/dts/omap3.dtsi +1 -1
@@ -516,7 +516,7 @@
 		usb_otg_hs: usb_otg_hs at 480ab000 {
 			compatible = "ti,omap3-musb";
 			reg = <0x480ab000 0x1000>;
-			interrupts = <0 92 0x4>, <0 93 0x4>;
+			interrupts = <92>, <93>;
 			interrupt-names = "mc", "dma";
 			ti,hwmods = "usb_otg_hs";
 			multipoint = <1>;