Disable building of cups driver in host-gutenprint
PATCH 1/1 Disable building of cups driver in host-gutenprint
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
--- package/gutenprint/gutenprint.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gutenprint/gutenprint.mk +1 -1
@@ -29,7 +29,7 @@ GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \ --disable-escputil \ --disable-test \ --disable-testpattern \ - --with-cups="/usr" \ + --without-cups \ --with-sysroot="$(STAGING_DIR)" \ --disable-cups-ppds
Signature · 1 line
1.7.10.4
PATCH 1/1 Disable building of cups driver in host-gutenprint
Dear Olivier Schonken,
Quoted 15 lines · Olivier Schonken
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.Signed-off-by Olivier Schonken <[email protected]>--- package/gutenprint/gutenprint.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/gutenprint/gutenprint.mk +0
-0
package/gutenprint/gutenprint.mk GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \ · line 35
Quoted 8 lines
package/gutenprint/gutenprint.mk +1
-1@@ -29,7 +29,7 @@ GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \ --disable-escputil \ --disable-test \ --disable-testpattern \ - --with-cups="/usr" \ + --without-cups \ --with-sysroot="$(STAGING_DIR)" \ --disable-cups-ppds
Hum, in your commit description, you're mentionning "host-cups" does not exist, so host-gutenprint shouldn't try to build with CUPS support. But in your patch, you're changing GUTENPRINT_CONF_OPT, i.e the configuration option of gutenprint for the target.
Could you explain in a few more details the relation between your commit log and the patch itself?
Thanks a lot!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 Disable building of cups driver in host-gutenprint
In reply to Olivier SchonkenThis should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
Corrected absent minded mistake. Thanks Thomas
--- package/gutenprint/gutenprint.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/gutenprint/gutenprint.mk +2 -1
@@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \ --without-foomatic3 \ --disable-escputil \ --disable-test \ - --disable-testpattern + --disable-testpattern \ + --without-cups # Needed by autoreconf define GUTENPRINT_CREATE_M4_DIR
Signature · 1 line
1.7.10.4
PATCH 1/1 Disable building of cups driver in host-gutenprint
Dear Olivier Schonken,
Quoted 11 lines · Olivier Schonken
This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.Signed-off-by Olivier Schonken <[email protected]>Corrected absent minded mistake. Thanks Thomas
--- package/gutenprint/gutenprint.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, but the "Corrected absent minded mistake..." sentence should be below the "---" sign, otherwise, it will remain part of the commit history forever.
Also, when you send a new version of a patch, please make sure to change the title from PATCH 1/1 to PATCH v2 1/1. This can be achieved by doing git format-patch --subject-prefix="PATCH v2". --subject-prefix also works directly with git send-email.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 Disable building of cups driver in host-gutenprint
In reply to Olivier SchonkenThis should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Because there is no host-cups package, host-gutenprint cant build the
host-cups drivers - missing includes and libs. Host gutenprint only
built to get the xml. Thus not a loss.
---
Corrected absent minded mistake. Thanks Thomas
package/gutenprint/gutenprint.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/gutenprint/gutenprint.mk +2 -1
@@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \ --without-foomatic3 \ --disable-escputil \ --disable-test \ - --disable-testpattern + --disable-testpattern \ + --without-cups # Needed by autoreconf define GUTENPRINT_CREATE_M4_DIR
Signature · 1 line
1.7.10.4
PATCH v2 1/1 Disable building of cups driver in host-gutenprint
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Olivier" == Olivier Schonken <[email protected]> writes:
Olivier> This should fix http://autobuild.buildroot.org/results/d2e386b50744aeda7257a0b78aafe90ba4da697c/
Olivier> Because there is no host-cups package, host-gutenprint cant build the
Olivier> host-cups drivers - missing includes and libs. Host gutenprint only
Olivier> built to get the xml. Thus not a loss.
Olivier> Signed-off-by: Olivier Schonken <[email protected]>
Olivier> ---
Olivier> Corrected absent minded mistake. Thanks Thomas
Olivier> package/gutenprint/gutenprint.mk | 3 ++-
Olivier> 1 file changed, 2 insertions(+), 1 deletion(-)
Olivier> diff --git a/package/gutenprint/gutenprint.mk b/package/gutenprint/gutenprint.mk Olivier> index 0463771..072fada 100644
Olivier> --- a/package/gutenprint/gutenprint.mk
Olivier> +++ b/package/gutenprint/gutenprint.mk
Olivier> @@ -51,7 +51,8 @@ HOST_GUTENPRINT_CONF_OPT = --disable-libgutenprintui2 \
Olivier> --without-foomatic3 \ Olivier> --disable-escputil \ Olivier> --disable-test \ Olivier> - --disable-testpattern Olivier> + --disable-testpattern \
Olivier> + --without-cups
Indentation is off compared to the other lines, but I've fixed that.
After some more testing I've found out that I also have to set an explicit ac_cv_path_CUPS_CONFIG, otherwise the output of the (host) cups-config is still added to CFLAGS/LDFLAGS.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard