Skip to contentSkip to conversation

Unhide lttng-tools and lttng-modules

PATCH New Olivier Schonken 3 participants 3 messages May 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Unhide lttng-tools and lttng-modules

When using lttng-tools for userland tracing with lttng-libust lttng-modules is not required, thus a dependency on building lttng-modules and a kernel is overkill for lttng-tools. It also hides it from a user not wanting to build a kernel. A comment has been added to lttng-modules to show a user that lttng-modules is dependent on a kernel build.

---
 package/lttng-modules/Config.in |    3 +++
 package/lttng-tools/Config.in   |    1 -
 2 files changed, 3 insertions(+), 1 deletion(-)
package/lttng-modules/Config.in +3 -0
index 2a0f938..fb5947f 100644
@@ -16,3 +16,6 @@ config BR2_PACKAGE_LTTNG_MODULES
 	  http://lttng.org/files/bundles/20111214/README.compatible.kernels.txt
 
 	  http://lttng.org
+
+comment "lttng-modules requires a linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
package/lttng-tools/Config.in +0 -1
index 3d95eeb..4f86e77 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LTTNG_TOOLS
 	bool "lttng-tools"
-	depends on BR2_PACKAGE_LTTNG_MODULES
 	select BR2_PACKAGE_LIBURCU
 	select BR2_PACKAGE_POPT
 	# liburcu only works on some architectures and requires thread support
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 Unhide lttng-tools and lttng-modules

Dear Olivier Schonken,

Quoted 7 lines · Olivier Schonken

When using lttng-tools for userland tracing with lttng-libust lttng-modules is not required, thus a dependency on building lttng-modules and a kernel is overkill for lttng-tools. It also hides it from a user not wanting to build a kernel. A comment has been added to lttng-modules to show a user that lttng-modules is dependent on a kernel build.

Peter, I believe this can go in 2013.05-rc.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 Unhide lttng-tools and lttng-modules

In reply to Olivier Schonken
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Olivier" == Olivier Schonken <[email protected]> writes:

Olivier> When using lttng-tools for userland tracing with lttng-libust Olivier> lttng-modules is not required, thus a dependency on building Olivier> lttng-modules and a kernel is overkill for lttng-tools. It Olivier> also hides it from a user not wanting to build a kernel. A Olivier> comment has been added to lttng-modules to show a user that Olivier> lttng-modules is dependent on a kernel build.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard