Skip to contentSkip to conversation

8139cp: reset BQL when ring tx ring cleared

PATCH In review Stephen Hemminger 2 participants 3 messages May 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 8139cp: reset BQL when ring tx ring cleared

While looking for other problem found this potential issue. When the transmit ring is cleaned out, the Byte Queue Limit values need to be reset.

drivers/net/ethernet/realtek/8139cp.c +1 -0
@@ -1136,6 +1136,7 @@ static void cp_clean_rings (struct cp_pr
 			cp->dev->stats.tx_dropped++;
 		}
 	}
+	netdev_tx_reset_queue(cp->dev);
 
 	memset(cp->rx_ring, 0, sizeof(struct cp_desc) * CP_RX_RING_SIZE);
 	memset(cp->tx_ring, 0, sizeof(struct cp_desc) * CP_TX_RING_SIZE);
maintainer
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Sat, 11 May 2013 17:09:23 -0700

Quoted 5 lines

While looking for other problem found this potential issue. When the transmit ring is cleaned out, the Byte Queue Limit values need to be reset.

You neither compiled, nor tested this.

#2 lore raw

No forgot to refresh.

Quoted 10 lines · David Miller

From: Stephen Hemminger <[email protected]>
Date: Sat, 11 May 2013 17:09:23 -0700

Quoted 5 lines

While looking for other problem found this potential issue. When the transmit ring is cleaned out, the Byte Queue Limit values need to be reset.

You neither compiled, nor tested this.