perf report: Add --percent-limit option
Namhyung Kim
maintainerPATCH 1/2 perf report: Add --percent-limit option
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
--- tools/perf/Documentation/perf-report.txt | 4 ++ tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-report.c | 21 +++++++-- tools/perf/builtin-top.c | 4 +- tools/perf/ui/browsers/hists.c | 79 +++++++++++++++++++++++++++----- tools/perf/ui/gtk/hists.c | 13 ++++-- tools/perf/ui/stdio/hist.c | 7 ++- tools/perf/util/hist.h | 10 ++-- 8 files changed, 115 insertions(+), 25 deletions(-)
tools/perf/Documentation/perf-report.txt +4 -0
@@ -210,6 +210,10 @@ OPTIONS Demangle symbol names to human readable form. It's enabled by default, disable with --no-demangle. +--percent-limit:: + Do not show entries which have an overhead under that percent. + (Default: 0). + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-annotate[1]
tools/perf/builtin-diff.c +1 -1
@@ -457,7 +457,7 @@ static void hists__process(struct hists *old, struct hists *new)hists__output_resort (new); } -hists__fprintf (new, true,0 ,0 , stdout); +hists__fprintf (new, true,0 ,0 ,0 , stdout); }static int __cmd_diff (void )
tools/perf/builtin-report.c +17 -4
@@ -52,6 +52,7 @@ struct perf_report {symbol_filter_t annotate_init;const char *cpu_list;const char *symbol_filter_str; +float min_percent;DECLARE_BITMAP (cpu_bitmap,MAX_NR_CPUS ); };
@@ -456,7 +457,7 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,continue ;hists__fprintf_nr_sample_events (rep, hists, evname, stdout); -hists__fprintf (hists, true,0 ,0 , stdout); +hists__fprintf (hists, true,0 ,0 , rep->min_percent, stdout);fprintf (stdout,"\n\n" ); }
@@ -575,8 +576,8 @@ static int __cmd_report(struct perf_report *rep)if (use_browser >0 ) {if (use_browser ==1 ) { ret =perf_evlist__tui_browse_hists (session->evlist, - help, -NULL , + help,NULL , + rep->min_percent, &session->header.env);/* * Usually "ret" is the last pressed key, and we only
@@ -587,7 +588,7 @@ static int __cmd_report(struct perf_report *rep) }else if (use_browser ==2 ) {perf_evlist__gtk_browse_hists (session->evlist, help, -NULL ); +NULL , rep->min_percent); } }else perf_evlist__tty_browse_hists (session->evlist, rep, help);
@@ -698,6 +699,16 @@ parse_branch_mode(const struct option *opt __maybe_unused,return 0 ; } +static int +parse_percent_limit (const struct option *opt,const char *str, +int unset__maybe_unused ) +{ +struct perf_report *rep = opt->value; + + rep->min_percent =strtof (str,NULL ); +return 0 ; +} +int cmd_report (int argc,const char **argv,const char *prefix__maybe_unused ) {struct perf_session *session;
@@ -807,6 +818,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)OPT_BOOLEAN (0 ,"demangle" , &symbol_conf.demangle,"Disable symbol demangling" ),OPT_BOOLEAN (0 ,"mem-mode" , &report.mem_mode,"mem access profile" ), +OPT_CALLBACK (0 ,"percent-limit" , &report,"percent" , +"Don't show entries under that percent" , parse_percent_limit), OPT_END() };
tools/perf/builtin-top.c +2 -2
@@ -296,7 +296,7 @@ static void perf_top__print_sym_table(struct perf_top *top) top->print_entries - printed);putchar ('\n' );hists__fprintf (&top->sym_evsel->hists, false, - top->print_entries - printed, win_width, stdout); + top->print_entries - printed, win_width,0 , stdout); }static void prompt_integer (int *target,const char *msg)
@@ -580,7 +580,7 @@ static void *display_thread_tui(void *arg)list_for_each_entry (pos, &top->evlist->entries, node) pos->hists.uid_filter_str = top->record_opts.target.uid_str; -perf_evlist__tui_browse_hists (top->evlist, help, &hbt, +perf_evlist__tui_browse_hists (top->evlist, help, &hbt,0 , &top->session->header.env); done =1 ;
tools/perf/ui/browsers/hists.c +68 -11
217 lines not on this page · raw message
tools/perf/ui/gtk/hists.c +10 -3
@@ -124,7 +124,8 @@ void perf_gtk__init_hpp(void) perf_gtk__hpp_color_overhead_guest_us; } -static void perf_gtk__show_hists (GtkWidget *window,struct hists *hists) +static void perf_gtk__show_hists (GtkWidget *window,struct hists *hists, +float min_pcnt) {struct perf_hpp_fmt *fmt;GType col_types[MAX_COLUMNS ];
@@ -189,10 +190,15 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists)for (nd =rb_first (&hists->entries); nd; nd =rb_next (nd)) { struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);GtkTreeIter iter; +float percent = h->stat.period *100.0 / + hists->stats.total_period;if (h->filtered)continue ; +if (percent < min_pcnt) +continue ; +gtk_list_store_append (store, &iter); col_idx =0 ;
@@ -222,7 +228,8 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists)int perf_evlist__gtk_browse_hists (struct perf_evlist *evlist,const char *help, -struct hist_browser_timer *hbt__maybe_unused ) +struct hist_browser_timer *hbt__maybe_unused , +float min_pcnt) {struct perf_evsel *pos;GtkWidget *vbox;
@@ -286,7 +293,7 @@ int perf_evlist__gtk_browse_hists(struct perf_evlist *evlist,GTK_POLICY_AUTOMATIC , GTK_POLICY_AUTOMATIC); -perf_gtk__show_hists (scrolled_window, hists); +perf_gtk__show_hists (scrolled_window, hists, min_pcnt); tab_label =gtk_label_new (evname);
tools/perf/ui/stdio/hist.c +6 -1
@@ -334,7 +334,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size, }size_t hists__fprintf (struct hists *hists,bool show_header,int max_rows, -int max_cols,FILE *fp) +int max_cols,float min_pcnt,FILE *fp) {struct perf_hpp_fmt *fmt;struct sort_entry *se;
@@ -440,10 +440,15 @@ size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows, print_entries:for (nd =rb_first (&hists->entries); nd; nd =rb_next (nd)) { struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); +float percent = h->stat.period *100.0 / + hists->stats.total_period;if (h->filtered)continue ; +if (percent < min_pcnt) +continue ; + ret +=hist_entry__fprintf (h, max_cols, hists, fp);if (max_rows && ++nr_rows >= max_rows)
tools/perf/util/hist.h +7 -3
@@ -115,7 +115,7 @@ void events_stats__inc(struct events_stats *stats, u32 type);size_t events_stats__fprintf (struct events_stats *stats,FILE *fp);size_t hists__fprintf (struct hists *self,bool show_header,int max_rows, -int max_cols,FILE *fp); +int max_cols,float min_pcnt,FILE *fp);int hist_entry__inc_addr_samples (struct hist_entry *self,int evidx,u64 addr);int hist_entry__annotate (struct hist_entry *self,size_t privsize);
@@ -195,6 +195,7 @@ int hist_entry__tui_annotate(struct hist_entry *he, struct perf_evsel *evsel,int perf_evlist__tui_browse_hists (struct perf_evlist *evlist,const char *help,struct hist_browser_timer *hbt, +float min_pcnt,struct perf_session_env *env);int script_browse (const char *script_opt);#else
@@ -202,6 +203,7 @@ static inlineint perf_evlist__tui_browse_hists (struct perf_evlist *evlist__maybe_unused ,const char *help__maybe_unused ,struct hist_browser_timer *hbt__maybe_unused , +float min_pcnt__maybe_unused ,struct perf_session_env *env__maybe_unused ) {return 0 ;
@@ -229,12 +231,14 @@ static inline int script_browse(const char *script_opt __maybe_unused)#ifdef GTK2_SUPPORT int perf_evlist__gtk_browse_hists (struct perf_evlist *evlist,const char *help, -struct hist_browser_timer *hbt__maybe_unused ); +struct hist_browser_timer *hbt__maybe_unused , +float min_pcnt);#else static inline int perf_evlist__gtk_browse_hists (struct perf_evlist *evlist__maybe_unused ,const char *help__maybe_unused , -struct hist_browser_timer *hbt__maybe_unused ) +struct hist_browser_timer *hbt__maybe_unused , +float min_pcnt__maybe_unused ) {return 0 ; }
Signature · 1 line
1.7.11.7
Namhyung Kim
maintainerPATCH 2/2 perf top: Add --percent-limit option
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output.
--- tools/perf/Documentation/perf-top.txt | 4 ++++ tools/perf/builtin-top.c | 17 +++++++++++++++-- tools/perf/ui/browsers/hists.c | 16 ++++++++++++++-- tools/perf/util/top.h | 1 + 4 files changed, 34 insertions(+), 4 deletions(-)
tools/perf/Documentation/perf-top.txt +4 -0
@@ -155,6 +155,10 @@ Default is to monitor all CPUS. Default: fractal,0.5,callee. +--percent-limit:: + Do not show entries which have an overhead under that percent. + (Default: 0). + INTERACTIVE PROMPTING KEYS --------------------------
tools/perf/builtin-top.c +15 -2
@@ -296,7 +296,8 @@ static void perf_top__print_sym_table(struct perf_top *top) top->print_entries - printed);putchar ('\n' );hists__fprintf (&top->sym_evsel->hists, false, - top->print_entries - printed, win_width,0 , stdout); + top->print_entries - printed, win_width, + top->min_percent, stdout); }static void prompt_integer (int *target,const char *msg)
@@ -580,7 +581,7 @@ static void *display_thread_tui(void *arg)list_for_each_entry (pos, &top->evlist->entries, node) pos->hists.uid_filter_str = top->record_opts.target.uid_str; -perf_evlist__tui_browse_hists (top->evlist, help, &hbt,0 , +perf_evlist__tui_browse_hists (top->evlist, help, &hbt, top->min_percent, &top->session->header.env); done =1 ;
@@ -1021,6 +1022,16 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset)return record_parse_callchain_opt (opt, arg, unset); } +static int +parse_percent_limit (const struct option *opt,const char *arg, +int unset__maybe_unused ) +{ +struct perf_top *top = opt->value; + + top->min_percent =strtof (arg,NULL ); +return 0 ; +} +int cmd_top (int argc,const char **argv,const char *prefix__maybe_unused ) {int status;
@@ -1106,6 +1117,8 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)OPT_STRING ('M' ,"disassembler-style" , &disassembler_style,"disassembler style" ,"Specify disassembler style (e.g. -M intel for intel syntax)" ),OPT_STRING ('u' ,"uid" , &target->uid_str,"user" ,"user to profile" ), +OPT_CALLBACK (0 ,"percent-limit" , &top,"percent" , +"Don't show entries under that percent" , parse_percent_limit),OPT_END () }; const char * const top_usage[] = {
tools/perf/ui/browsers/hists.c +14 -2
@@ -310,6 +310,8 @@ static void ui_browser__warn_lost_events(struct ui_browser *browser) "Or reduce the sampling frequency."); } +static void hist_browser__update_pcnt_entries (struct hist_browser *hb); +static int hist_browser__run (struct hist_browser *browser,const char *ev_name,struct hist_browser_timer *hbt) {
@@ -333,9 +335,18 @@ static int hist_browser__run(struct hist_browser *browser, const char *ev_name, key =ui_browser__run (&browser->b, delay_secs);switch (key) { -case K_TIMER : +case K_TIMER : { +u64 nr_entries; hbt->timer (hbt->arg); -ui_browser__update_nr_entries (&browser->b, browser->hists->nr_entries); + +if (browser->min_pcnt) { +hist_browser__update_pcnt_entries (browser); + nr_entries = browser->nr_pcnt_entries; + }else { + nr_entries = browser->hists->nr_entries; + } + +ui_browser__update_nr_entries (&browser->b, nr_entries);if (browser->hists->stats.nr_lost_warned != browser->hists->stats.nr_events[PERF_RECORD_LOST ]) {
@@ -347,6 +358,7 @@ static int hist_browser__run(struct hist_browser *browser, const char *ev_name,hists__browser_title (browser->hists, title,sizeof (title), ev_name);ui_browser__show_title (&browser->b, title);continue ; + }case 'D' : {/* Debug */ static int seq; struct hist_entry *h = rb_entry(browser->b.top,
tools/perf/util/top.h +1 -0
@@ -36,6 +36,7 @@ struct perf_top {int realtime_prio;int sym_pcnt_filter;const char *sym_filter; +float min_percent; };size_t perf_top__header_snprintf (struct perf_top *top,char *bf,size_t size);
Signature · 1 line
1.7.11.7
Re: [PATCH 2/2] perf top: Add --percent-limit option
Quoted 7 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output.
Cc Andi Kleen <[email protected]>Signed-off-by Namhyung Kim <[email protected]>
Quoted 7 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
Cc Andi Kleen <[email protected]>Signed-off-by Namhyung Kim <[email protected]>
Namhyung Kim
maintainerHi Pekka,
Quoted 10 lines · Pekka Enberg
Quoted 7 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
Cc Andi Kleen <[email protected]>Signed-off-by Namhyung Kim <[email protected]>Acked-by Pekka Enberg <[email protected]>
Thanks and sorry for missing you on CC list.
Namhyung
Quoted 4 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
hi,
can't apply this on acme's perf/core nor latest tip What is this based on? Maybe you could push the branch out? ;-)
thanks,
jirka
Namhyung Kim
maintainerHi Jiri,
Quoted 9 lines · Jiri Olsa
Quoted 4 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
hi,
can't apply this on acme's perf/core nor latest tip What is this based on? Maybe you could push the branch out? ;-)
Oops, I wanted to make it independent to other patches, but it seemed I failed. :)
It's on top on acme/perf/core but also depends on my other works. I'll resend the patches in a set and push the branch soon.
Thanks,
Namhyung
Quoted 6 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
Cc Andi Kleen <[email protected]>
I like the option, but 0 is not a good default.
Make it 1 or something.
Perhaps a better heuristic would be
percent < threshold || samples < sample-threshold with sample-threshold being several hundred at least.
A very small number of hits on something is usually quite much useless, unless your original event was extremly rare in the beginning (but then it's unclear if the profile is any useful)
-Andi
Namhyung Kim
maintainerHi Andi,
Quoted 10 lines · Andi Kleen
Quoted 6 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
The --percent-limit option is for not showing small overheaded entries in the output. Maybe we want to set a certain default value like 0.1.
Cc Andi Kleen <[email protected]>I like the option, but 0 is not a good default.
Make it 1 or something.
Thanks. I just wanted to reserve same behavior since I didn't know what's the reasonable default value. We might use a config variable for this to customize the default value.
Quoted 8 lines
Perhaps a better heuristic would be
percent < threshold || samples < sample-threshold with sample-threshold being several hundred at least.A very small number of hits on something is usually quite much useless, unless your original event was extremly rare in the beginning (but then it's unclear if the profile is any useful)
Looks reasonable, but I know there's also some users who use the perf tools lightly. A several hundreds sample-threshold looks too harsh to them IMHO. In addition, it should handle tracepoints.
Thanks,
Namhyung