Skip to contentSkip to conversation

common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

PATCH Superseded ying.zhang at freescale.com 5 participants 5 messages May 10, 2013 – May 13, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

From: Ying Zhang <[email protected]>

Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT.

In common/Makefile, the environment-related files in SPL is difined by CONFIG_SPL_NET_SUPPORT, it is wrong.

---
 common/Makefile              |   12 +++++-------
 include/configs/am335x_evm.h |    1 +
 include/configs/pcm051.h     |    1 +
 3 files changed, 7 insertions(+), 7 deletions(-)
common/Makefile +5 -7
index 0e0fff1..1bd742a 100644
@@ -215,15 +215,13 @@ endif
 
 ifdef CONFIG_SPL_BUILD
 COBJS-y += cmd_nvedit.o
-COBJS-y += env_common.o
 COBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o
 COBJS-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += cmd_nvedit.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_attr.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_callback.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_common.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_flags.o
-COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_nowhere.o
+COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_common.o
+COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_attr.o
+COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_flags.o
+COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_callback.o
+COBJS-$(CONFIG_ENV_IS_NOWHERE) += env_nowhere.o
 COBJS-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o
 endif
 COBJS-$(CONFIG_BOUNCE_BUFFER) += bouncebuf.o
include/configs/am335x_evm.h +1 -0
index ef00306..f47d3d1 100644
@@ -325,6 +325,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"AM335x U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT
include/configs/pcm051.h +1 -0
index d0ea74e..926842f 100644
@@ -224,6 +224,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"pcm051 U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

Dear ying.zhang at freescale.com,

Quoted 3 lines · In message <[email protected]> you wrote:

From: Ying Zhang <[email protected]>

Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT.

Any CONFIG_* stuff must be documented in the README. Please add this documentation.

Quoted 2 lines

In common/Makefile, the environment-related files in SPL is difined by CONFIG_SPL_NET_SUPPORT, it is wrong.

s/difined/defined/

Could you please also explain, what exactly is wrong, and how your new code fixes this?

Quoted 15 lines
include/configs/am335x_evm.h +1 -0
@@ -325,6 +325,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"AM335x U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT
include/configs/pcm051.h +0 -0
index d0ea74e..926842f 100644

include/configs/pcm051.h line 230

Quoted 7 lines
include/configs/pcm051.h +1 -0
@@ -224,6 +224,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"pcm051 U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT

Are you sure these are the only locations that need this?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Speed of a tortoise breaking the sound barrier         = 1 Machturtle
#2 lore raw

PATCH 1/1 common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

Quoted 12 lines · Wolfgang Denk

Dear ying.zhang at freescale.com,

In message <[email protected]>

Quoted 3 lines · you

From: Ying Zhang <[email protected]>

Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace

CONFIG_SPL_NET_SUPPORT.

Any CONFIG_* stuff must be documented in the README. Please add this documentation.

Quoted 8 lines
Quoted 1 line

In common/Makefile, the environment-related files in SPL is difined

by

Quoted 1 line

CONFIG_SPL_NET_SUPPORT, it is wrong.

s/difined/defined/

Could you please also explain, what exactly is wrong, and how your new code fixes this?

We will need the environment in SPL for reasons other than network support (in particular, hwconfig contains info for how to set up DDR). Yes, this information should go in the changelog.

-Scott

#3 lore raw

PATCH 1/1 common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

-----Original Message-----
From: Wood Scott-B07421
Sent: Saturday, May 11, 2013 8:29 AM
To: Wolfgang Denk
Cc: Zhang Ying-B40530; u-boot at lists.denx.de; Xie Xiaobo-R63061; Zhang Ying-B40530
Subject: Re: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

Quoted 12 lines · Wolfgang Denk

Dear ying.zhang at freescale.com,

In message <[email protected]>

Quoted 3 lines · you

From: Ying Zhang <[email protected]>

Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace

CONFIG_SPL_NET_SUPPORT.

Any CONFIG_* stuff must be documented in the README. Please add this documentation.

Quoted 8 lines
Quoted 1 line

In common/Makefile, the environment-related files in SPL is difined

by

Quoted 1 line

CONFIG_SPL_NET_SUPPORT, it is wrong.

s/difined/defined/

Could you please also explain, what exactly is wrong, and how your new code fixes this?

We will need the environment in SPL for reasons other than network support (in particular, hwconfig contains info for how to set up DDR). Yes, this information should go in the changelog.
[Zhang Ying]
OK, I will update this patch and CONFIG_SPL_ENV_SUPPORT will be added in README.

Quoted 15 lines
include/configs/am335x_evm.h +1 -0
@@ -325,6 +325,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"AM335x U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT
include/configs/pcm051.h index renamed from include/configs/pcm051.h +0 -0

d0ea74e..926842f 100644

include/configs/pcm051.h line 230

Quoted 7 lines
include/configs/pcm051.h +1 -0
@@ -224,6 +224,7 @@
 #define CONFIG_SPL_GPIO_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 #define CONFIG_SPL_NET_SUPPORT
+#define CONFIG_SPL_ENV_SUPPORT
 #define CONFIG_SPL_NET_VCI_STRING	"pcm051 U-Boot SPL"
 #define CONFIG_SPL_ETH_SUPPORT
 #define CONFIG_SPL_SPI_SUPPORT

Are you sure these are the only locations that need this?
[Zhang Ying]
I've searched for the symbol "CONFIG_SPL_NET_SUPPORT" all of the code, there is only the two files to define.

#4 lore raw

PATCH 1/1 common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT

In reply to Scott Wood
Quoted 18 lines · Scott Wood
Quoted 17 lines · Wolfgang Denk

Dear ying.zhang at freescale.com,

In message <[email protected]> you

Quoted 3 lines · wrote:

From: Ying Zhang <[email protected]>

Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace

CONFIG_SPL_NET_SUPPORT.

Any CONFIG_* stuff must be documented in the README. Please add this documentation.

Quoted 1 line

In common/Makefile, the environment-related files in SPL is

difined by

Quoted 1 line

CONFIG_SPL_NET_SUPPORT, it is wrong.

Quoted 8 lines
Quoted 4 lines

s/difined/defined/

Could you please also explain, what exactly is wrong, and how your new code fixes this?

We will need the environment in SPL for reasons other than network support (in particular, hwconfig contains info for how to set up DDR). Yes, this information should go in the changelog.

Note that a3m071 already does SPL + Environment and should be updated, CONFIG-symbol wise here. It currently gets away with env_common/cmd_nvedit being pulled in always on LIBCOMMON and then discarded when not needed.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130513/751d90c3/attachment.pgp>