Skip to contentSkip to conversation

MFD: Fixes due for the v3.10 -rc:s

GIT PULL Lee Jones 4 participants 9 messages May 14, 2013 – May 21, 2013

lore
Share & tools
lore

Lee Jones

author
#0 lore raw

The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:

Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)

are available in the git repository at:

git://git.linaro.org/people/ljones/mfd.git for-mfd-fixes

for you to fetch changes up to bc475aeb21c85f956c98014cae887f311c68b192:

mfd: db8500-prcmu: Supply the pdata_size attribute for db8500-thermal (2013-05-14 09:58:15 +0100)

----------------------------------------------------------------
Arnd Bergmann (1):
mfd: ab8500: Debugfs code depends on gpadc

Fabio Baltieri (4):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Lee Jones (3):
mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning
mfd: ab8500-core: Use the correct driver name when enabling gpio/pinctrl
mfd: db8500-prcmu: Supply the pdata_size attribute for db8500-thermal

Linus Walleij (1):
mfd: ab8500: Pass AB8500 IRQ to debugfs code by resource

 drivers/mfd/Kconfig          |    2 +-
 drivers/mfd/ab8500-core.c    |   21 ++++++++++++++++++---
 drivers/mfd/ab8500-debugfs.c |   16 ++++++++++++----
 drivers/mfd/ab8500-gpadc.c   |    7 +++++--
 drivers/mfd/ab8500-sysctrl.c |    9 +++++----
 drivers/mfd/abx500-core.c    |    2 +-
 drivers/mfd/db8500-prcmu.c   |    1 +
 7 files changed, 43 insertions(+), 15 deletions(-)
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#1 lore raw

Hi Sam,

Since v1 of my MFD -fixes pull-request, I have applied a few more patches which really should be entered into the -rc:s. As it appears that you have not yet pulled v1, I figured sending a v2 in its place would be appropriate, so here it is.

-----

The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:

Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)

are available in the git repository at:

git://git.linaro.org/people/ljones/mfd.git for-mfd-fixes

for you to fetch changes up to 27df65e061f51f6bd2c8e9ad6b505c8dbab6460c:

mfd: db8500-prcmu: Update stored DSI PLL divider value (2013-05-14 15:58:04 +0100)

----------------------------------------------------------------
Arnd Bergmann (1):
mfd: ab8500: Debugfs code depends on gpadc

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata
mfd: ab8500-sysctrl: Always enable pm_power_off handler

Lee Jones (4):
mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning
mfd: ab8500-core: Use the correct driver name when enabling gpio/pinctrl
mfd: db8500-prcmu: Supply the pdata_size attribute for db8500-thermal
mfd: ab8500-core: Pass GPADC compatible string to MFD core

Linus Walleij (1):
mfd: ab8500: Pass AB8500 IRQ to debugfs code by resource

Ulf Hansson (1):
mfd: db8500-prcmu: Update stored DSI PLL divider value

 drivers/mfd/Kconfig               |    2 +-
 drivers/mfd/ab8500-core.c         |   24 +++++++++++++++++++++---
 drivers/mfd/ab8500-debugfs.c      |   16 ++++++++++++----
 drivers/mfd/ab8500-gpadc.c        |    7 +++++--
 drivers/mfd/ab8500-sysctrl.c      |   15 ++++++++++-----
 drivers/mfd/abx500-core.c         |    2 +-
 drivers/mfd/db8500-prcmu.c        |    3 +++
 include/linux/mfd/abx500/ab8500.h |    2 --
 8 files changed, 53 insertions(+), 18 deletions(-)
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw

Hi Lee,

Quoted 6 lines · Lee Jones

Hi Sam,

Since v1 of my MFD -fixes pull-request, I have applied a few more patches which really should be entered into the -rc:s. As it appears that you have not yet pulled v1, I figured sending a v2 in its place would be appropriate, so here it is.

This almost looks good, I just have one comment:

Quoted 5 lines

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Unless I'm missing something here, this one is not really rcN material, so I'd appreciate if you could queue it to your for-mfd branch instead.

The rest is pulled and applied, thanks again.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#3 lore raw

Hello Samuel,

Quoted 7 lines · Samuel Ortiz
Quoted 5 lines

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Unless I'm missing something here, this one is not really rcN material, so I'd appreciate if you could queue it to your for-mfd branch instead.

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

are actually fixes for bugs introduced in this merge window that inhibited the ab8500-sysctl driver as a consequence. Would you reconsider pulling just those?

Thanks,
Fabio

Signature · 1 line
Fabio Baltieri
#4 lore raw
Quoted 1 line · Fabio Baltieri

Hello Samuel,

(...)

Quoted 8 lines

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

are actually fixes for bugs introduced in this merge window that inhibited the ab8500-sysctl driver as a consequence. Would you reconsider pulling just those?

A good way to make sure that patches fixing regressions are applied to the -rc series is to indicate in the commit message or even the heading that it fixes a regression.

I usually try to begin such commits with the text:

this patch fixes a regression caused by change 018745435 "foo: fix bar"...

Then copying in some crash dump text never hurts :-)

It makes it very easy for us as subsystem maintainers to pick regression fixes.

Yours,
Linus Walleij

#5 lore raw
Quoted 19 lines · Linus Walleij
Quoted 1 line · Fabio Baltieri

Hello Samuel,

(...)

Quoted 8 lines

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

are actually fixes for bugs introduced in this merge window that inhibited the ab8500-sysctl driver as a consequence. Would you reconsider pulling just those?

A good way to make sure that patches fixing regressions are applied to the -rc series is to indicate in the commit message or even the heading that it fixes a regression.

I usually try to begin such commits with the text:

Quoted 7 lines

this patch fixes a regression caused by change 018745435 "foo: fix bar"...

Then copying in some crash dump text never hurts :-)

It makes it very easy for us as subsystem maintainers to pick regression fixes.

Right, I actually pointed to the culprit commit (applied during the merge window) in the message, but I'll try to be more direct next time. I also agree on the crash dump, but unfortunately this one was failing silently. :-)

Thanks for the tip!
Fabio

Signature · 1 line
Fabio Baltieri
#6 lore raw
In reply to Fabio Baltieri

Hi Fabio,

Quoted 8 lines · Fabio Baltieri

Hello Samuel,

Quoted 5 lines · Samuel Ortiz
Quoted 5 lines

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Quoted 6 lines
Quoted 2 lines

Unless I'm missing something here, this one is not really rcN material, so I'd appreciate if you could queue it to your for-mfd branch instead.

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe

This one is already in mfd-fixes, the commit log was clear enough.

Quoted 1 line

mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

This one is not, as the commit log is not showing it actually fixes something but only makes the code cleaner. If it really fixes something, could you please provide me with a commit log that describes what exactly it fixes ?

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#7 lore raw

Hi Samuel,

Quoted 11 lines · Samuel Ortiz

Hi Fabio,

Quoted 8 lines · Fabio Baltieri

Hello Samuel,

Quoted 5 lines · Samuel Ortiz
Quoted 5 lines

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

Unless I'm missing something here, this one is not really rcN material, so I'd appreciate if you could queue it to your for-mfd branch instead.

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe

This one is already in mfd-fixes, the commit log was clear enough.

Great!

Quoted 4 lines
Quoted 1 line

mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

This one is not, as the commit log is not showing it actually fixes something but only makes the code cleaner. If it really fixes something, could you please provide me with a commit log that describes what exactly it fixes ?

Ok, the fix here is that right now that driver is initialized without a specific pdata (that is plat->sysctrl), so enforcing it breaks existing platforms for no reason. To make the commit more clear I would just point that out as in (just last two sentences):

--- >8 ---
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

A check for a valid plat->sysctrl was introduced in:

2377e52 mfd: ab8500-sysctrl: Error check clean up

but the driver works just fine even without that initialization data, and enforcing it breaks existing platforms for no reason.

This patch removes the check and let the driver go ahead with probe. --- >8 ---

Is it better?

Thanks,
Fabio

Signature · 1 line
Fabio Baltieri
#8 lore raw

Hi Fabio,

Quoted 37 lines · Fabio Baltieri
Quoted 9 lines · Samuel Ortiz
Quoted 8 lines · Fabio Baltieri

Hello Samuel,

Quoted 5 lines · Samuel Ortiz
Quoted 5 lines

Fabio Baltieri (5):
mfd: abx500-core: Fix sparse warning
mfd: ab8500-sysctrl: Fix sparse warning
mfd: ab8500-sysctrl: Set sysctrl_dev during probe
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

Unless I'm missing something here, this one is not really rcN material, so I'd appreciate if you could queue it to your for-mfd branch instead.

The last two:

mfd: ab8500-sysctrl: Set sysctrl_dev during probe

This one is already in mfd-fixes, the commit log was clear enough.

Great!

Quoted 4 lines
Quoted 1 line

mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

This one is not, as the commit log is not showing it actually fixes something but only makes the code cleaner. If it really fixes something, could you please provide me with a commit log that describes what exactly it fixes ?

Ok, the fix here is that right now that driver is initialized without a specific pdata (that is plat->sysctrl), so enforcing it breaks existing platforms for no reason. To make the commit more clear I would just point that out as in (just last two sentences):

--- >8 ---
mfd: ab8500-sysctrl: Let sysctrl driver work without pdata

A check for a valid plat->sysctrl was introduced in:

2377e52 mfd: ab8500-sysctrl: Error check clean up

Quoted 7 lines

but the driver works just fine even without that initialization data, and enforcing it breaks existing platforms for no reason.

This patch removes the check and let the driver go ahead with probe. --- >8 ---

Is it better?

Slightly. Next time please describe how it breaks.
I applied and pushed this patch now, I'll send a pull request to Linus tomorrow morning.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/