ARM:dts:omap4-panda:Update the LED support for the panda DTS
PATCH v3 1/1 ARM:dts:omap4-panda:Update the LED support for the panda DTS
The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different.
A1-A3 = gpio_wk7
ES = gpio_110
There is no change to LED D2
Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files.
--- arch/arm/boot/dts/omap4-panda-common.dtsi | 16 +++++++++++- arch/arm/boot/dts/omap4-panda-es.dts | 40 +++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 1 deletion(-)
arch/arm/boot/dts/omap4-panda-common.dtsi +15 -1
@@ -16,7 +16,7 @@ reg = <0x80000000 0x40000000>; /* 1 GB */ }; - leds { + leds: leds { compatible = "gpio-leds"; heartbeat { label = "pandaboard::status1";
@@ -137,6 +137,20 @@ }; }; +&omap4_pmx_wkup { + pinctrl-names = "default"; + pinctrl-0 = < + &led_wkgpio_pins + >; + + led_wkgpio_pins: pinmux_leds_wkpins { + pinctrl-single,pins = < + 0x1a 0x3 /* gpio_wk7 OUTPUT | MODE 3 */ + 0x1c 0x3 /* gpio_wk8 OUTPUT | MODE 3 */ + >; + }; +}; + &i2c1 { pinctrl-names = "default"; pinctrl-0 = <&i2c1_pins>;
arch/arm/boot/dts/omap4-panda-es.dts +40 -0
@@ -34,3 +34,43 @@ 0x5e 0x100 /* hdmi_sda.hdmi_sda INPUT | MODE 0 */ >; }; + +&leds { + compatible = "gpio-leds"; + heartbeat { + label = "pandaboard::status1"; + gpios = <&gpio4 14 0>; + linux,default-trigger = "heartbeat"; + }; + mmc { + label = "pandaboard::status2"; + gpios = <&gpio1 8 0>; + linux,default-trigger = "gpio"; + }; +}; + +&omap4_pmx_core { + pinctrl-names = "default"; + pinctrl-0 = < + &led_gpio_pins + >; + + led_gpio_pins: gpio_led_pmx { + pinctrl-single,pins = < + 0xb6 0x3 /* gpio_110 OUTPUT | MODE 3 */ + >; + }; +}; + +&omap4_pmx_wkup { + pinctrl-names = "default"; + pinctrl-0 = < + &led_wkgpio_pins + >; + + led_wkgpio_pins: pinmux_leds_wkpins { + pinctrl-single,pins = < + 0x1c 0x3 /* gpio_wk8 OUTPUT | MODE 3 */ + >; + }; +};
Signature · 1 line
1.7.9.5
$subject - add a space? s/ARM:dts:omap4-panda:Update/ARM: dts: omap4-panda: Update/ ?
Quoted 4 lines · Dan Murphy
The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different.
A1-A3 =
gpio_wk7
Thanks for fixing this - this is a key fix else, GPIO_7 which controls VSEL for VDD_MPU on PandaBoard-ES will create all kind of ruckus (change voltage on heartbeat)!
Quoted 9 lines
ES =
gpio_110There is no change to LED D2
Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files.
Signed-off-by Dan Murphy <[email protected]>---
[...]
Quoted 10 lines
arch/arm/boot/dts/omap4-panda-es.dts +2
-0@@ -34,3 +34,43 @@ 0x5e 0x100 /* hdmi_sda.hdmi_sda INPUT | MODE 0 */ >; }; + +&leds {
arch/arm/boot/dts/omap4-panda-es.dts line 48
Quoted 10 lines
arch/arm/boot/dts/omap4-panda-es.dts +10
-0+ compatible = "gpio-leds"; + heartbeat { + label = "pandaboard::status1"; + gpios = <&gpio4 14 0>; + linux,default-trigger = "heartbeat"; + }; + mmc { + label = "pandaboard::status2"; + gpios = <&gpio1 8 0>; + linux,default-trigger = "gpio";
mmc0?
arch/arm/boot/dts/omap4-panda-es.dts line 51
Quoted 3 lines
arch/arm/boot/dts/omap4-panda-es.dts +3
-0+ }; +}; +
Other that that,
Signature · 2 lines
Regards, Nishanth Menon
NM
Quoted 2 lines · Nishanth Menon
$subject - add a space? s/ARM:dts:omap4-panda:Update/ARM: dts: omap4-panda: Update/ ?
Will fix.
Quoted 31 lines · Dan Murphy
Quoted 4 lines
The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different.
A1-A3 =
gpio_wk7Thanks for fixing this - this is a key fix else,
GPIO_7which controls VSEL forVDD_MPUon PandaBoard-ES will create all kind of ruckus (change voltage on heartbeat)!Quoted 9 lines
ES =
gpio_110There is no change to LED D2
Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files.
Signed-off-by Dan Murphy <[email protected]>---
[...]
Quoted 13 lines
arch/arm/boot/dts/omap4-panda-es.dts +5
-0@@ -34,3 +34,43 @@ 0x5e 0x100 /* hdmi_sda.hdmi_sda INPUT | MODE 0 */ >; }; + +&leds { + compatible = "gpio-leds"; + heartbeat { + label = "pandaboard::status1";
Quoted 8 lines
arch/arm/boot/dts/omap4-panda-es.dts line 48
Quoted 7 lines
arch/arm/boot/dts/omap4-panda-es.dts +7
-0+ gpios = <&gpio4 14 0>; + linux,default-trigger = "heartbeat"; + }; + mmc { + label = "pandaboard::status2"; + gpios = <&gpio1 8 0>; + linux,default-trigger = "gpio";mmc0?
Good point why would I call it mmc and then set the trigger to gpio.
Will fix it.
Quoted 5 lines
arch/arm/boot/dts/omap4-panda-es.dts line 51
Quoted 3 lines
arch/arm/boot/dts/omap4-panda-es.dts +3
-0+ }; +}; +Other that that,
Tested-by Nishanth Menon <[email protected]>
Signature · 2 lines
------------------ Dan Murphy