Skip to contentSkip to conversation

ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

PATCH New Axel Lin 5 participants 10 messages May 15, 2013 – May 21, 2013 Arm (32-bit)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

---
 arch/arm/cpu/arm720t/start.S | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/cpu/arm720t/start.S +2 -0
index 9facc7e..9f0e3f9 100644
@@ -244,6 +244,7 @@ c_runtime_cpu_setup:
  *************************************************************************
  */
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
 	mov	pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
 
 #ifndef CONFIG_SPL_BUILD
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Dear Axel Lin,

Quoted 4 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-)

Quoted 17 lines
---
 arch/arm/cpu/arm720t/start.S | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/cpu/arm720t/start.S +1 -0
index 9facc7e..9f0e3f9 100644
@@ -244,6 +244,7 @@ c_runtime_cpu_setup:
  *************************************************************************
  */
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 265

Quoted 7 lines
arch/arm/cpu/arm720t/start.S +1 -0
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
 	mov	pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
 
 #ifndef CONFIG_SPL_BUILD

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Hi Marek,

Quoted 8 lines · Marek Vasut

Dear Axel Lin,

Quoted 4 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-)

Thanks Marek. :)

Quoted 19 lines
Quoted 19 lines
---
 arch/arm/cpu/arm720t/start.S | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/cpu/arm720t/start.S +1 -0
index 9facc7e..9f0e3f9 100644
@@ -244,6 +244,7 @@ c_runtime_cpu_setup:
  *************************************************************************
  */
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
Quoted 5 lines

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 265

Quoted 5 lines
arch/arm/cpu/arm720t/start.S +1 -0
 	mov	pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
 
 #ifndef CONFIG_SPL_BUILD

I am tempted to ask: what actual issue does this guarding aim at solving? Just in case, beware that AFAIR Wolfgang does not consider 'because debugging' a valid answer.

Quoted 2 lines

Best regards,
Marek Vasut

Amicalement,

Signature · 1 line
Albert.
author
#3 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

2013/5/15 Albert ARIBAUD <[email protected]>:

Quoted 38 lines

Hi Marek,

Quoted 8 lines · Marek Vasut

Dear Axel Lin,

Quoted 4 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-)

Thanks Marek. :)

Quoted 23 lines
Quoted 23 lines
---
 arch/arm/cpu/arm720t/start.S | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/cpu/arm720t/start.S +2 -0
index 9facc7e..9f0e3f9 100644
@@ -244,6 +244,7 @@ c_runtime_cpu_setup:
  *************************************************************************
  */
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
    mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
 
Quoted 5 lines
Quoted 1 line

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 265

Quoted 1 line
arch/arm/cpu/arm720t/start.S +0 -0
 #ifndef CONFIG_SPL_BUILD

I am tempted to ask: what actual issue does this guarding aim at solving? Just in case, beware that AFAIR Wolfgang does not consider 'because debugging' a valid answer.

This fixes below build error if a platform has set CONFIG_SKIP_LOWLEVEL_INIT but does not implement lowlevel_init.

arch/arm/cpu/arm720t/start.o: In function `cpu_init_crit':
arch/arm/cpu/arm720t/start.S:256: undefined reference to `lowlevel_init'

I have no idea if current supported boards in u-boot has this issue or not. I hit this build error because I'm porting u-boot to a SoC that is not supported by u-boot at this moment.

Regards,
Axel

#4 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

In reply to Axel Lin
Quoted 10 lines · Axel Lin

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 4 lines
arch/arm/cpu/arm720t/start.S +1 -0
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
 	mov	pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects.

author
#5 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

2013/5/15 Stephen Warren <[email protected]>:

Quoted 13 lines · Axel Lin
Quoted 12 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
Quoted 7 lines

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 2 lines
arch/arm/cpu/arm720t/start.S +1 -0
      mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects.

Tegra exists in both arm720t and armv7:

./arch/arm/cpu/arm720t/tegra-common
./arch/arm/cpu/arm720t/tegra30
./arch/arm/cpu/arm720t/tegra20
./arch/arm/cpu/arm720t/tegra114

./arch/arm/cpu/armv7/tegra-common
./arch/arm/cpu/armv7/tegra30
./arch/arm/cpu/armv7/tegra20
./arch/arm/cpu/armv7/tegra114

I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ?

Regards,
Axel

#6 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Quoted 29 lines · Axel Lin

2013/5/15 Stephen Warren <[email protected]>:

Quoted 13 lines · Axel Lin
Quoted 12 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
Quoted 7 lines

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 2 lines
arch/arm/cpu/arm720t/start.S +1 -0
      mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects.

Tegra exists in both arm720t and armv7:

./arch/arm/cpu/arm720t/tegra-common
./arch/arm/cpu/arm720t/tegra30
./arch/arm/cpu/arm720t/tegra20
./arch/arm/cpu/arm720t/tegra114

Quoted 7 lines

./arch/arm/cpu/armv7/tegra-common
./arch/arm/cpu/armv7/tegra30
./arch/arm/cpu/armv7/tegra20
./arch/arm/cpu/armv7/tegra114

I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ?

Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL build. There's a whole section of include/configs/tegra-common-post.h which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define CONFIG_SKIP_LOWLEVEL_INIT there.

#7 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Axel (& Albert)

Quoted 45 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Wednesday, May 15, 2013 9:29 PM
To: Axel Lin
Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Quoted 22 lines · Axel Lin

2013/5/15 Stephen Warren <[email protected]>:

Quoted 21 lines · Axel Lin
Quoted 11 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 4 lines
arch/arm/cpu/arm720t/start.S +1 -0
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
      mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-

effects.

Quoted 13 lines

Tegra exists in both arm720t and armv7:

./arch/arm/cpu/arm720t/tegra-common
./arch/arm/cpu/arm720t/tegra30
./arch/arm/cpu/arm720t/tegra20
./arch/arm/cpu/arm720t/tegra114

./arch/arm/cpu/armv7/tegra-common
./arch/arm/cpu/armv7/tegra30
./arch/arm/cpu/armv7/tegra20
./arch/arm/cpu/armv7/tegra114

Quoted 7 lines
Quoted 2 lines

I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ?

Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL build. There's a whole section of include/configs/tegra-common-post.h which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define CONFIG_SKIP_LOWLEVEL_INIT there.

I've applied your two patches (this one and the RFT for Tegra) to u-boot-tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu and Dalmore.

Both of these are assigned to me in PatchWork - Albert - do you want me to take them both in via the Tegra tree, or do you want to take the ARM patch and I'll take the Tegra patch? Let me know.

Axel - I'll let you know how testing goes, and then you can resubmit the RFT patch as a real patch against Tegra.

Thanks,

Tom
--
nvpublic

#8 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Hi Tom,

Quoted 50 lines · Tom Warren

Axel (& Albert)

Quoted 48 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Wednesday, May 15, 2013 9:29 PM
To: Axel Lin
Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Quoted 22 lines · Axel Lin

2013/5/15 Stephen Warren <[email protected]>:

Quoted 21 lines · Axel Lin
Quoted 11 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 4 lines
arch/arm/cpu/arm720t/start.S +1 -0
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
      mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-

effects.

Quoted 15 lines

Tegra exists in both arm720t and armv7:

./arch/arm/cpu/arm720t/tegra-common
./arch/arm/cpu/arm720t/tegra30
./arch/arm/cpu/arm720t/tegra20
./arch/arm/cpu/arm720t/tegra114

./arch/arm/cpu/armv7/tegra-common
./arch/arm/cpu/armv7/tegra30
./arch/arm/cpu/armv7/tegra20
./arch/arm/cpu/armv7/tegra114

I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ?

Quoted 7 lines
Quoted 4 lines

Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL build. There's a whole section of include/configs/tegra-common-post.h which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define CONFIG_SKIP_LOWLEVEL_INIT there.

I've applied your two patches (this one and the RFT for Tegra) to u-boot-tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu and Dalmore.

Both of these are assigned to me in PatchWork - Albert - do you want me to take them both in via the Tegra tree, or do you want to take the ARM patch and I'll take the Tegra patch? Let me know.

Please take both in Tegra tree.

Quoted 7 lines

Axel - I'll let you know how testing goes, and then you can resubmit the RFT patch as a real patch against Tegra.

Thanks,

Tom
--
nvpublic

Amicalement,

Signature · 1 line
Albert.
#9 lore raw

PATCH 1/1 ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Albert (& Axel),

Quoted 71 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Saturday, May 18, 2013 11:58 AM
To: Tom Warren
Cc: Stephen Warren; Axel Lin; Wolfgang Denk; Heiko Schocher; u- boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Hi Tom,

Quoted 51 lines · Tom Warren

Axel (& Albert)

Quoted 49 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Wednesday, May 15, 2013 9:29 PM
To: Axel Lin
Cc: Wolfgang Denk; Heiko Schocher; Tom Warren; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] ARM: arm720t: Add missing CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit

Quoted 23 lines · Axel Lin

2013/5/15 Stephen Warren <[email protected]>:

Quoted 22 lines · Axel Lin
Quoted 11 lines

cpu_init_crit() can be skipped, but the code is still enabled requiring a platform to supply lowlevel_init().

arch/arm/cpu/arm720t/start.S +1 -0
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 cpu_init_crit:
 
 #if !defined(CONFIG_TEGRA)

arch/arm/cpu/arm720t/start.S cpu_init_crit: · line 262

Quoted 4 lines
arch/arm/cpu/arm720t/start.S +1 -0
@@ -258,6 +259,7 @@ cpu_init_crit:
 #endif
 
      mov     pc, lr
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the Tegra-specific ifdef from the body of that function. That's assuming that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-

effects.

Quoted 15 lines

Tegra exists in both arm720t and armv7:

./arch/arm/cpu/arm720t/tegra-common
./arch/arm/cpu/arm720t/tegra30
./arch/arm/cpu/arm720t/tegra20
./arch/arm/cpu/arm720t/tegra114

./arch/arm/cpu/armv7/tegra-common
./arch/arm/cpu/armv7/tegra30
./arch/arm/cpu/armv7/tegra20
./arch/arm/cpu/armv7/tegra114

I'm wondering if we set CONFIG_SKIP_LOWLEVEL_INIT for tegra will also impact the code path in arch/arm/cpu/armv7/start.S ?

Quoted 6 lines
Quoted 5 lines

Yes, you certainly only want to set CONFIG_SKIP_LOWLEVEL_INIT for the SPL build. There's a whole section of include/configs/tegra-common-post.h
which is ifdef CONFIG_SPL_BUILD, so it might make sense to #define CONFIG_SKIP_LOWLEVEL_INIT there.

I've applied your two patches (this one and the RFT for Tegra) to u-boot-

Quoted 8 lines

tegra/next and I'm running a MAKEALL right now, then I'll do a test on Cardhu and Dalmore.

Quoted 2 lines

Both of these are assigned to me in PatchWork - Albert - do you want me

to take them both in via the Tegra tree, or do you want to take the ARM patch and I'll take the Tegra patch? Let me know.

Please take both in Tegra tree.

Will do. Axel - please resend these 2 patches w/o the RFT tag as a v2 and I'll take them in to the Tegra repo.

Tom

Quoted 6 lines
Quoted 2 lines

Axel - I'll let you know how testing goes, and then you can resubmit the RFT

patch as a real patch against Tegra.

Quoted 3 lines

Thanks,

Quoted 7 lines
Quoted 3 lines

Tom
--
nvpublic

Amicalement,
--
Albert.

--
nvpublic