xen/privcmd: fix condition in privcmd_close()
Subsystems (3)
PATCH 1/1 xen/privcmd: fix condition in privcmd_close()
The parenthesis are in the wrong place so the original code is equivalent to:
if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
Which obviously was not intended.
drivers/xen/privcmd.c +1 -1
@@ -495,7 +495,7 @@ static void privcmd_close(struct vm_area_struct *vma)struct page **pages = vma->vm_private_data;int numpgs = (vma->vm_end - vma->vm_start) >>PAGE_SHIFT ; -if (!xen_feature (XENFEAT_auto_translated_physmap || !numpgs || !pages)) +if (!xen_feature (XENFEAT_auto_translated_physmap) || !numpgs || !pages)return ;xen_unmap_domain_mfn_range (vma, numpgs, pages);
PATCH 1/1 xen/privcmd: fix condition in privcmd_close()
The parenthesis are in the wrong place so the original code is equivalent to:
if (!xen_feature(0x1)) { ...Or:
if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
Which obviously was not intended.
---
I sent this last November but it was never merged.
drivers/xen/privcmd.c +1 -1
@@ -504,7 +504,7 @@ static void privcmd_close(struct vm_area_struct *vma)struct page **pages = vma->vm_private_data;int numpgs = (vma->vm_end - vma->vm_start) >>PAGE_SHIFT ; -if (!xen_feature (XENFEAT_auto_translated_physmap || !numpgs || !pages)) +if (!xen_feature (XENFEAT_auto_translated_physmap) || !numpgs || !pages)return ;xen_unmap_domain_mfn_range (vma, numpgs, pages);
Quoted 4 lines · Dan Carpenter
The parenthesis are in the wrong place so the original code is equivalent to:
if (!xen_feature(0x1)) { ...
Quoted 8 lines
Or:
if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...Which obviously was not intended.
Signed-off-by Dan Carpenter <[email protected]>---
I sent this last November but it was never merged.
Ah, it was, but in a different branch (stable/pvh.v8). Let me stick it on branch for Linus.