mmc and fat bug fixes
PATCH 1/1 mmc and fat bug fixes
This patch fixes a number of mmc and fat-related bugs:
Quoted 5 lines
Added a check for blkcnt > 0 in
mmc_write_blocks(drivers/mmc.c) to prevent a hangup for further mmc commands.Solved a checksum issue in
fs/fat/fat.c. The mkcksum has const char arguments with a size specifier, like "const char name[8]". In the function, it is assumed that sizeof(name) will have the value 8, but this is not the case (at least not for the Sourcery CodeBench compiler and probably not according to ANSI C). This causes "long filename checksum errors" for each fat file listed or written.Made some changes to
fs/fat/fat_write.c. Fixed testingfat_valfor 0xffff/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding fatsize in the test (as read in earlier posts) and some changes in debug output.
mmc/mmc.c +2 -1
@@ -282,8 +282,9 @@if (blkcnt >1 ) cmd.cmdidx =MMC_CMD_WRITE_MULTIPLE_BLOCK ; -else +else if (blkcnt >0 ) cmd.cmdidx =MMC_CMD_WRITE_SINGLE_BLOCK ; +else return 0 ;//Called with blkcnt = 0 if (mmc->high_capacity) cmd.cmdarg = start;
fat/fat.c +4 -2
@@ -569,10 +569,12 @@__u8 ret =0 ; -for (i =0 ; i <sizeof (name); i++) +for (i =0 ; i <8 ; i++) { ret = (((ret &1 ) <<7 ) | ((ret &0xfe ) >>1 )) + name[i]; -for (i =0 ; i <sizeof (ext); i++) + } +for (i =0 ; i <3 ; i++) { ret = (((ret &1 ) <<7 ) | ((ret &0xfe ) >>1 )) + ext[i]; + }return ret; }
fat/fat_write.c +10 -8
@@ -41,6 +41,7 @@ }static int total_sector; +static int disk_write (__u32 block,__u32 nr_blocks,void *buf) {if (!cur_dev || !cur_dev->block_write)
@@ -104,8 +105,7 @@ }else memcpy (dirent->ext, s_name + period_location +1 ,3 ); -debug ("name : %s\n" , dirent->name); -debug ("ext : %s\n" , dirent->ext); +debug ("name.ext : %.8s.%.3s\n" , dirent->name, dirent->ext); }static __u8 num_of_fats;
@@ -264,6 +264,7 @@ goto name0_4; } slotptr->name0_4[j] = name[*idx]; + slotptr->name0_4[j +1 ] =0x00 ; (*idx)++; end_idx++; }
@@ -275,6 +276,7 @@ goto name5_10; } slotptr->name5_10[j] = name[*idx]; + slotptr->name5_10[j +1 ] =0x00 ; (*idx)++; end_idx++; }
@@ -286,6 +288,7 @@ goto name11_12; } slotptr->name11_12[j] = name[*idx]; + slotptr->name11_12[j +1 ] =0x00 ; (*idx)++; end_idx++; }
@@ -569,7 +572,7 @@else startsect = mydata->rootdir_sect; -debug ("clustnum: %d, startsect: %d\n" , clustnum, startsect); +debug ("clustnum: %d, startsect: %d, size %lu\n" , clustnum, startsect, size);if (disk_write (startsect, size / mydata->sect_size, buffer) <0 ) {debug ("Error writing data\n" );
@@ -587,10 +590,7 @@debug ("Error writing data\n" );return -1 ; } - -return 0 ; } -return 0 ; }
@@ -656,7 +656,8 @@else break ; -if (fat_val ==0xfffffff || fat_val ==0xffff ) +if (((fat_val ==0xfffffff ) && (mydata->fatsize ==32 )) || + ((fat_val ==0xffff ) && (mydata->fatsize ==16 )))break ; entry = fat_val;
@@ -901,7 +902,8 @@ } curclust =get_fatent_value (mydata, dir_curclust); -if ((curclust >=0xffffff8 ) || (curclust >=0xfff8 )) { +if (((curclust >=0xffffff8 ) && (mydata->fatsize ==32 )) || + ((curclust >=0xfff8 ) && (mydata->fatsize ==16 ))) { empty_dentptr = dentptr;return NULL ; }
PATCH 1/1 mmc and fat bug fixes
Hi Ruud,
Quoted 1 line · Ruud Commandeur
This patch fixes a number of mmc and fat-related bugs:
There should be only one logical change per patch.
Quoted 3 lines
Quoted 3 lines
Added a check for blkcnt > 0 in
mmc_write_blocks(drivers/mmc.c) to prevent a hangup for further mmc commands.
Adding Andy, the MMC custodian, to Cc.
Quoted 11 lines
Quoted 11 lines
Solved a checksum issue in
fs/fat/fat.c. The mkcksum has const char arguments with a size specifier, like "const char name[8]". In the function, it is assumed that sizeof(name) will have the value 8, but this is not the case (at least not for the Sourcery CodeBench compiler and probably not according to ANSI C). This causes "long filename checksum errors" for each fat file listed or written.Made some changes to
fs/fat/fat_write.c. Fixed testingfat_valfor 0xffff/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding fatsize in the test (as read in earlier posts) and some changes in debug output.
Expressions like "as read in earlier posts" should not be present in a patch description since it is unclear what it refers to once the patch has been applied.
Line lengths should be at most 80 characters, including in the patch description.
Quoted 11 lines
Signed-off-by Ruud Commandeur <[email protected]>Cc Tom Rini <[email protected]>Cc Beno?t Th?baudeau <[email protected]>Cc Mats Karrman <[email protected]>Index:
drivers/mmc/mmc.c
===================================================================
mmc/mmc.c line 287
Quoted 7 lines
mmc/mmc.c +2
-1@@ -282,8 +282,9 @@if (blkcnt >1 ) cmd.cmdidx =MMC_CMD_WRITE_MULTIPLE_BLOCK ; -else +else if (blkcnt >0 ) cmd.cmdidx =MMC_CMD_WRITE_SINGLE_BLOCK ; +else return 0 ;//Called with blkcnt = 0
The comment above is useless. Also, the comment style in U-Boot is /**/, not //.
Quoted 12 lines
mmc/mmc.c +0
-0if (mmc->high_capacity) cmd.cmdarg = start;Index:
fs/fat/fat.c
===================================================================fat/fat.c +0
-1@@ -569,10 +569,12 @@__u8 ret =0 ; -for (i =0 ; i <sizeof (name); i++)
fat/fat.c line 580
Quoted 10 lines
fat/fat.c +4
-1+for (i =0 ; i <8 ; i++) { ret = (((ret &1 ) <<7 ) | ((ret &0xfe ) >>1 )) + name[i]; -for (i =0 ; i <sizeof (ext); i++) + } +for (i =0 ; i <3 ; i++) { ret = (((ret &1 ) <<7 ) | ((ret &0xfe ) >>1 )) + ext[i]; + }return ret; }
There should not be curly braces for single-line blocks.
Anyway, this has already been done by Marek in commit 6ad77d8, so this hunk should be dropped.
fat/fat_write.c line 47
Quoted 12 lines
Index:
fs/fat/fat_write.c
===================================================================fat/fat_write.c +1
-0@@ -41,6 +41,7 @@ }static int total_sector; +static int disk_write (__u32 block,__u32 nr_blocks,void *buf) {if (!cur_dev || !cur_dev->block_write)
This hunk is not very useful.
fat/fat_write.c line 108
Quoted 7 lines
fat/fat_write.c +1
-2@@ -104,8 +105,7 @@ }else memcpy (dirent->ext, s_name + period_location +1 ,3 ); -debug ("name : %s\n" , dirent->name); -debug ("ext : %s\n" , dirent->ext); +debug ("name.ext : %.8s.%.3s\n" , dirent->name, dirent->ext);
Correct. You could just remove the space before the colon since this is the standard English formatting.
Quoted 20 lines
fat/fat_write.c +2
-0}static __u8 num_of_fats;@@ -264,6 +264,7 @@ goto name0_4; } slotptr->name0_4[j] = name[*idx]; + slotptr->name0_4[j +1 ] =0x00 ; (*idx)++; end_idx++; }@@ -275,6 +276,7 @@ goto name5_10; } slotptr->name5_10[j] = name[*idx]; + slotptr->name5_10[j +1 ] =0x00 ; (*idx)++; end_idx++; }
fat/fat_write.c line 294
Quoted 7 lines
fat/fat_write.c +1
-0@@ -286,6 +288,7 @@ goto name11_12; } slotptr->name11_12[j] = name[*idx]; + slotptr->name11_12[j +1 ] =0x00 ; (*idx)++; end_idx++; }
These 3 hunks are correct, but they should be mentioned in the patch description.
fat/fat_write.c line 576
Quoted 7 lines
fat/fat_write.c +1
-1@@ -569,7 +572,7 @@else startsect = mydata->rootdir_sect; -debug ("clustnum: %d, startsect: %d\n" , clustnum, startsect); +debug ("clustnum: %d, startsect: %d, size %lu\n" , clustnum, startsect, size);
Line too long: max 80 chars.
fat/fat_write.c line 591
Quoted 9 lines
fat/fat_write.c +0
-2if (disk_write (startsect, size / mydata->sect_size, buffer) <0 ) {debug ("Error writing data\n" );@@ -587,10 +590,7 @@debug ("Error writing data\n" );return -1 ; } - -return 0 ;
OK.
fat/fat_write.c line 593
Quoted 2 lines
fat/fat_write.c +0
-1} -
This empty line would be better kept for code legibility.
Quoted 15 lines
fat/fat_write.c +2
-1return 0 ; }@@ -656,7 +656,8 @@else break ; -if (fat_val ==0xfffffff || fat_val ==0xffff ) +if (((fat_val ==0xfffffff ) && (mydata->fatsize ==32 )) || + ((fat_val ==0xffff ) && (mydata->fatsize ==16 )))break ; entry = fat_val;
fat/fat_write.c line 909
Quoted 9 lines
fat/fat_write.c +2
-1@@ -901,7 +902,8 @@ } curclust =get_fatent_value (mydata, dir_curclust); -if ((curclust >=0xffffff8 ) || (curclust >=0xfff8 )) { +if (((curclust >=0xffffff8 ) && (mydata->fatsize ==32 )) || + ((curclust >=0xfff8 ) && (mydata->fatsize ==16 ))) { empty_dentptr = dentptr;return NULL ; }
These 2 hunks are correct, but please remove the parentheses around the "=="
expressions: They make the code less readable. And add another tab to indent the 2nd line of the if-s so that it is more indented than the if block contents.
Best regards,
Beno?t
PATCH 1/1 mmc and fat bug fixes
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 4 lines · Beno?t Th?baudeau
Hi Ruud,
Quoted 1 line · Ruud Commandeur
This patch fixes a number of mmc and fat-related bugs:
[snip]
Quoted 13 lines
Quoted 8 lines
(quoted diff) +0
-0@@ -901,7 +902,8 @@ }curclust =
get_fatent_value(mydata, dir_curclust); - if
((curclust >=0xffffff8) || (curclust >=0xfff8)) { + if
(((curclust >=0xffffff8) && (mydata->fatsize== 32)) || + ((curclust >=0xfff8) && (mydata->fatsize== 16))) {empty_dentptr= dentptr; return NULL; }These 2 hunks are correct, but please remove the parentheses around the "==" expressions: They make the code less readable. And add another tab to indent the 2nd line of the if-s so that it is more indented than the if block contents.
With regards to style, checkpatch.pl wins (so please use it on your patch, git format-patch -n1 ; ./tools/checkpatch.pl ./0001-what-git-said-it-called-it) and it should be:
if ((one big test) ||
(second test)) {<tab>... code ...
}
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRlBUZAAoJENk4IS6UOR1WGLUQAK1zwb+enZWBQ0j1HXeQUiMx mnErR6WKBqg7Tt5ya72abdE5tGmulS6QThrT1uXP98u/qUfiEBEDHb5MRy8cRdL8 LKvplOFVkl9iZXbHqD9/u5FUT9A2t/L0nMEYBG8akCIaxqOPLSgB5U7NbkJohrGE 2jhFN1cLXKFkRujstEjefDw720sIBesWXeLLKIzHG8YujxdRkYGr5bi3iHMNSG90 nOIkf7+umd72QqFVs7Sq2xCmNLzntsx1m76DkX0fJ0ReAlkoBfWEvkTKjmr+ANPz ksualH7u2PWz53h021iVA+b2SZtWhHj5GgqhShFKoqKyyjUyktn/4J9qan0rDp88 6+p3H5bpYfBhOWGzb9lkX+krc1F7ViJO4CABWNZO/ux4Sg+cdpKsFwyVJfSzh1wd jViZg0oq+qMT5u+XEFY1QAivP0rcL3wiVQ+YUXOfAqjx1zik3EMl0f6FO/71AGnm SlYGm39dhTyU5kEruCJBVWk97eEh8ETVLIZ/giaEi6HVsw/uv8yElLq4KtdxC7P0 pnNmR+wGnzifJiCYFDgIRKvpFaUCgqfxb6ac717PL7XDb5d3TMfWdfgR4FKMDK7b GWTiEnA3hLUWUGCdwYflH1JqzJxzXRQBP3Gc7QOqKtHSEcQ1Hc3tlm4kAKvAfF0k ys0ayHOizfdTTjE2JlPS
=QJxA
-----END PGP SIGNATURE-----
PATCH 1/1 mmc and fat bug fixes
In reply to Ruud CommandeurQuoted 5 lines · Ruud Commandeur
This patch fixes a number of mmc and fat-related bugs:
Quoted 1 line
Added a check for blkcnt > 0 in
mmc_write_blocks(drivers/mmc.c) toprevent a hangup for further mmc commands.
You need more information than that. Why is some code requesting 0-byte data commands?
As others mentioned, you need to break up patches so each change is one patch.
mmc/mmc.c (working copy) line 288
Quoted 13 lines
Index:
drivers/mmc/mmc.c
===================================================================mmc/mmc.c (working copy) renamed from mmc/mmc.c (revision 9) +2
-1@@ -282,8 +282,9 @@ if (blkcnt > 1) cmd.cmdidx = MMC_CMD_WRITE_MULTIPLE_BLOCK; - else + else if (blkcnt > 0) cmd.cmdidx = MMC_CMD_WRITE_SINGLE_BLOCK; + else return 0; //Called with blkcnt = 0
Assuming this is necessary, I think it then might be time to reorder this:
if (!blkcnt) <-- possibly@the very start of the function.
return 0;
if (blkcnt == 1)
cmd.cmdidx = MMC_CMD_WRITE_SINGLE_BLOCK;
else
cmd.cmdidx = MMC_CMD_WRITE_MULTIPLE_BLOCK;
While technically correct, checking >1, then >0 creates an odd dissonance in my mind, and makes me have to think about when that if clause will evaluate to true, and I hate having to think. :)
Andy
PATCH 1/1 mmc and fat bug fixes
Quoted 18 lines
-----Oorspronkelijk bericht-----
Van: Andy Fleming [mailto:afleming at gmail.com]
Verzonden: donderdag 16 mei 2013 0:15
Aan: Ruud Commandeur
CC: U-Boot list; Tom Rini; Mats K?rrman
Onderwerp: Re: [U-Boot] [PATCH] mmc and fat bug fixesOn Wed, May 15, 2013 at 9:23 AM, Ruud Commandeur <[email protected]> wrote:
This patch fixes a number of mmc and fat-related bugs:
Quoted 9 lines
> Added a check for blkcnt > 0 in
mmc_write_blocks
(drivers/mmc.c) to prevent a hangup for further mmc commands.You need more information than that. Why is some code requesting 0-byte data commands?
I have discussed this issue in an earlier thread. But I agree that it would make
sense to add some of this earlier comments here.
Quoted 3 lines
As others mentioned, you need to break up patches so each change is one patch.
Yep :-)
Quoted 31 lines
Index:
drivers/mmc/mmc.c===================================================================
---drivers/mmc/mmc.c(revision 9)
+++drivers/mmc/mmc.c(working copy)
@@ -282,8 +282,9 @@if (blkcnt > 1)
cmd.cmdidx =MMC_CMD_WRITE_MULTIPLE_BLOCK;
- else
+ else if (blkcnt > 0)
cmd.cmdidx =MMC_CMD_WRITE_SINGLE_BLOCK;
+ else return 0; //Called with blkcnt = 0Assuming this is necessary, I think it then might be time to reorder this:
if (!blkcnt) <-- possibly@the very start of the function.
return 0;if (blkcnt == 1)
cmd.cmdidx =MMC_CMD_WRITE_SINGLE_BLOCK;
else
cmd.cmdidx =MMC_CMD_WRITE_MULTIPLE_BLOCK;
Quoted 5 lines
While technically correct, checking >1, then >0 creates an odd dissonance in my mind, and makes me have to think about when that if clause will evaluate to true, and I hate having to think. :)
You're right. That was the reason for adding my (wrong styled) comments. So I can either reorder his to:
if (blkcnt == 0) return 0; else if (blkcnt == 1) cmd.cmdidx = MMC_CMD_WRITE_SINGLE_BLOCK; else cmd.cmdidx = MMC_CMD_WRITE_MULTIPLE_BLOCK;
Or add the test for 0 at the very beginning as you suggested. Any preference?
Quoted 2 lines
Andy
PATCH 1/1 mmc and fat bug fixes
Quoted 28 lines · Ruud Commandeur
Quoted 12 lines
Assuming this is necessary, I think it then might be time to reorder this:
if (!blkcnt) <-- possibly@the very start of the function.
return 0;if (blkcnt == 1)
cmd.cmdidx =MMC_CMD_WRITE_SINGLE_BLOCK;
else
cmd.cmdidx =MMC_CMD_WRITE_MULTIPLE_BLOCK;Quoted 5 lines
While technically correct, checking >1, then >0 creates an odd dissonance in my mind, and makes me have to think about when that if clause will evaluate to true, and I hate having to think. :)
You're right. That was the reason for adding my (wrong styled) comments. So I can either reorder his to:
if (blkcnt == 0) return 0; else if (blkcnt == 1) cmd.cmdidx = MMC_CMD_WRITE_SINGLE_BLOCK; else cmd.cmdidx = MMC_CMD_WRITE_MULTIPLE_BLOCK;
Quoted 4 lines
Or add the test for 0 at the very beginning as you suggested. Any preference?
This looks fine to me.
PATCH 1/1 mmc and fat bug fixes
In reply to Ruud CommandeurDear Ruud Commandeur,
Quoted 11 lines · In message <15AE5A936F5E3A42A9144E66875A0A89308F2E@server1-derijp.CLB-Benelux.l…
This patch fixes a number of mmc and fat-related bugs:
Quoted 1 line
Added a check for blkcnt > 0 in
mmc_write_blocks(drivers/mmc.c) to preve=nt a hangup for further mmc commands.
Quoted 1 line
Solved a checksum issue in
fs/fat/fat.c. The mkcksum has const char argum=ents with a size specifier, like "const char name[8]". In the function, it = is assumed that sizeof(name) will have the value 8, but this is not the cas= e (at least not for the Sourcery CodeBench compiler and probably not accord= ing to ANSI C). This causes "long filename checksum errors" for each fat fi= le listed or written.
Please explain. Under which exact conditions would sizeof(name) not be 8, and where is such assumption supported in ANSI C?
I am tempted to NAK the FAT changes, as they make the code much harder to read and to maintain.
Using this simple test program:
----- snip ----
#include <stdio.h>
int main(void)
{
const char name[8];
const char ext[3];
printf("sizeof(name)=%d, expected 8\n", sizeof(name));
printf("sizeof(ext) =%d, expected 3\n", sizeof(name));
return 0;
}----- snip ----
I get the expected values on all systems and with all compilers I
tested. For which exact configuration do you get different results?
Quoted 3 lines
Quoted 1 line
Made some changes to
fs/fat/fat_write.c. Fixed testingfat_valfor 0xffff=/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding fatsize in the = test (as read in earlier posts) and some changes in debug output.
Please restrict your line length in commit messages to some 70 characters or so.
Quoted 4 lines
Signed-off-by Ruud Commandeur <[email protected]>Cc Tom Rini <[email protected]>Cc Beno=EEt Th=E9baudeau <[email protected]>Cc Mats Karrman <[email protected]>
Please split into three separate patches, one for MMX, and two for FAT, one for each problem. And make sure to add the MMC custodian on Cc:
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The existence of god implies a violation of causality.
PATCH 1/1 mmc and fat bug fixes
Dear Wolfgang Denk,
Thanks for your comments, please see mine below.
Quoted 52 lines
-----Oorspronkelijk bericht-----
Van: Wolfgang Denk [mailto:wd at denx.de]
Verzonden: donderdag 16 mei 2013 7:55
Aan: Ruud Commandeur
CC: u-boot at lists.denx.de; Tom Rini; Mats K?rrman
Onderwerp: Re: [U-Boot] [PATCH] mmc and fat bug fixesDear Ruud Commandeur,
In message <[email protected]
Quoted 3 lines · elux.lokaal> you wrote:
This patch fixes a number of mmc and fat-related bugs:
Quoted 1 line
Added a check for blkcnt > 0 in
mmc_write_blocks(
drivers/mmc.c) to preve=Quoted 3 lines
nt a hangup for further mmc commands.
Quoted 1 line
Solved a checksum issue in
fs/fat/fat.c. The mkcksum hasconst char argum=
Quoted 1 line
ents with a size specifier, like "const char name[8]". In
the function, it =
Quoted 1 line
is assumed that sizeof(name) will have the value 8, but
this is not the cas=
Quoted 1 line
e (at least not for the Sourcery CodeBench compiler and
probably not accord=
Quoted 1 line
ing to ANSI C). This causes "long filename checksum errors"
for each fat fi=
Quoted 1 line
le listed or written.
Please explain. Under which exact conditions would sizeof(name) not be 8, and where is such assumption supported in ANSI C?
I am tempted to NAK the FAT changes, as they make the code much harder to read and to maintain.
Using this simple test program:
----- snip ----
#include <stdio.h>int main(void)
{ const char name[8]; const char ext[3]; printf("sizeof(name)=%d, expected 8\n", sizeof(name)); printf("sizeof(ext) =%d, expected 3\n", sizeof(name)); return 0; }
Quoted 5 lines
----- snip ----
I get the expected values on all systems and with all compilers I
tested. For which exact configuration do you get different results?
The difference is, that in the original code, the sizeof( ) is used on function arguments. And in that case the result will be the size of the pointer, regardless the addition of size indicators of the arguments.
----- snip ----
#include <stdio.h>
const char g_name[8];
const char g_ext[3];
static void mkcksum(const char name[8], const char ext[3])
{
printf("sizeof(name)=%d\n", sizeof(name));
printf("sizeof(ext) =%d\n", sizeof(ext));
}int main(void)
{
printf("sizeof(g_name)=%d\n", sizeof(g_name));
printf("sizeof(g_ext) =%d\n", sizeof(g_ext));
mkcksum(g_name, g_ext);
return 0;
}----- snip ----
In this case, the results will be:
sizeof(g_name)=8sizeof(g_ext) =3
sizeof(name)=4 /* will be machine dependant */
sizeof(ext) =4 /* will be machine dependant */
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Made some changes to
fs/fat/fat_write.c. Fixed testing
fat_valfor 0xffff=Quoted 1 line
/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding
fatsize in the =
Quoted 1 line
test (as read in earlier posts) and some changes in debug output.
Please restrict your line length in commit messages to some 70 characters or so.
I will try...
Quoted 10 lines
Quoted 5 lines
Signed-off-by Ruud Commandeur <[email protected]>Cc Tom Rini <[email protected]>Cc Beno=EEt Th=E9baudeau <[email protected]>Cc Mats Karrman <[email protected]>Please split into three separate patches, one for MMX, and two for FAT, one for each problem. And make sure to add the MMC custodian on Cc:
I will, and I will take notice of all other comments (will not answer them all
individually). And I guess that I could best post these as new patches (and forget about for this one)?
And just in case you haven't noticed: This was my first patch posted... :-)
Quoted 10 lines
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The existence of god implies a violation of causality.