Skip to contentSkip to conversation

poco: not available for all architectures

PATCH New Gustavo Zacarias 4 participants 9 messages May 16, 2013 – May 23, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 poco: not available for all architectures

Missing defines for:
aarch64, arc, blackfin, microblaze & xtensa.
Not properly supported: mips - only defines generic mips as BE, doesn't know about mipsel (LE) thus assuming it's BE.
Fixes:
http://autobuild.buildroot.net/results/9847702b046bed59b07f0e075a58b1f31e9236ce/

This should be pretty straightforward to fix in Foundation/include/Poco/Platform.h for interested parties since it only cares about endianness.

---
 package/poco/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/poco/Config.in +2 -0
index b823071..402f96d 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_POCO
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_PCRE
 	help
@@ -61,3 +62,4 @@ endif # BR2_PACKAGE_POCO
 comment "poco requires a toolchain with WCHAR, threads, and C++ support"
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 poco: not available for all architectures

Hi Gustavo,

Quoted 29 lines · Gustavo Zacarias

Missing defines for:
aarch64, arc, blackfin, microblaze & xtensa.
Not properly supported: mips - only defines generic mips as BE, doesn't know about mipsel (LE) thus assuming it's BE.
Fixes:
http://autobuild.buildroot.net/results/9847702b046bed59b07f0e075a58b1f31e9236ce/

This should be pretty straightforward to fix in Foundation/include/Poco/Platform.h for interested parties since it only cares about endianness.

---
 package/poco/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/poco/Config.in +1 -0
index b823071..402f96d 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_POCO
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_PCRE
 	help

package/poco/Config.in endif # BR2_PACKAGE_POCO · line 65

Quoted 4 lines
package/poco/Config.in +1 -0
@@ -61,3 +62,4 @@ endif # BR2_PACKAGE_POCO
 comment "poco requires a toolchain with WCHAR, threads, and C++ support"
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might confuse the user. Maybe we should add another comment? How is this handled in other packages?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 poco: not available for all architectures

Quoted 8 lines · Baruch Siach

package/poco/Config.in endif # BR2_PACKAGE_POCO · line 65

Quoted 4 lines

comment "poco requires a toolchain with WCHAR, threads, and C++ support"

package/poco/Config.in +1 -0
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might confuse the user. Maybe we should add another comment? How is this handled in other packages?

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).
Regards.

#3 lore raw

PATCH 1/1 poco: not available for all architectures

Hi Gustavo,

Quoted 10 lines · Gustavo Zacarias
Quoted 8 lines · Baruch Siach

package/poco/Config.in endif # BR2_PACKAGE_POCO · line 65

Quoted 4 lines

comment "poco requires a toolchain with WCHAR, threads, and C++ support"

package/poco/Config.in +1 -0
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might confuse the user. Maybe we should add another comment? How is this handled in other packages?

Quoted 2 lines

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).

Ah, right. I always get confused by reverse logic.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 poco: not available for all architectures

Quoted 8 lines · Baruch Siach
Quoted 6 lines
Quoted 3 lines

Enabling this comment when it is the architecture that is not supported might confuse the user. Maybe we should add another comment? How is this handled in other packages?

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).

Ah, right. I always get confused by reverse logic.

Normally we don't mention "your architecture isn't supported" because there's not much the user can do about it ("hey, change your hardware!" wouldn't be nice hehe).
Regards.

#5 lore raw

PATCH 1/1 poco: not available for all architectures

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 10 lines · Gustavo Zacarias
Quoted 8 lines · Baruch Siach

package/poco/Config.in endif # BR2_PACKAGE_POCO · line 65

Quoted 4 lines

comment "poco requires a toolchain with WCHAR, threads, and C++ support"

package/poco/Config.in +1 -0
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might confuse the user. Maybe we should add another comment? How is this handled in other packages?

Quoted 2 lines

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).

I believe that what Baruch says is that the comment is useless when you're on an architecture that poco doesn't support.

So it should actually be:

	depends on (BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

No?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 poco: not available for all architectures

Quoted 11 lines · Thomas Petazzoni
Quoted 2 lines

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).

I believe that what Baruch says is that the comment is useless when you're on an architecture that poco doesn't support.

So it should actually be:

	depends on (BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

No?

Maybe it's because i'm out of coffee, but i don't see that holding. So comment "hey you lack toolchain X" when ARCH = aarch64 || arc .. ? So it shows up if any of those arches == true ?
Regards.

#7 lore raw

PATCH 1/1 poco: not available for all architectures

Dear Gustavo Zacarias,

Quoted 10 lines · Gustavo Zacarias
Quoted 8 lines · Thomas Petazzoni
Quoted 2 lines

I'm actually disabling the comment if it's not a supported architecture with that line (same as the option itself).

I believe that what Baruch says is that the comment is useless when you're on an architecture that poco doesn't support.

So it should actually be:

Quoted 7 lines
Quoted 3 lines
	depends on (BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

No?

Maybe it's because i'm out of coffee, but i don't see that holding. So comment "hey you lack toolchain X" when ARCH = aarch64 || arc .. ? So it shows up if any of those arches == true ?

Doh, I must be the one needing more coffee it seems. Yeah, if the package is not available on some arches, we need to do "depends on !(some arches)" on both the package itself and the comment, which is what you did.

Got confused, sorry.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#8 lore raw

PATCH 1/1 poco: not available for all architectures

In reply to Gustavo Zacarias
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Missing defines for:
Gustavo> aarch64, arc, blackfin, microblaze & xtensa.
Gustavo> Not properly supported: mips - only defines generic mips as BE, doesn't Gustavo> know about mipsel (LE) thus assuming it's BE.
Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/9847702b046bed59b07f0e075a58b1f31e9236ce/

Gustavo> This should be pretty straightforward to fix in Gustavo> Foundation/include/Poco/Platform.h for interested parties Gustavo> since it only cares about endianness.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard