Skip to contentSkip to conversation

ARM: OMAP: fix error return code in omap1_system_dma_init()

PATCH New Wei Yongjun 2 participants 2 messages May 13, 2013 – May 16, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: fix error return code in omap1_system_dma_init()

From: Wei Yongjun <[email protected]>

Fix to return -ENOMEM in the d->chan alloc error handling case instead of 0, as done elsewhere in this function.

---
 arch/arm/mach-omap1/dma.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap1/dma.c +1 -0
index 68ab858..a94b3a7 100644
@@ -345,6 +345,7 @@ static int __init omap1_system_dma_init(void)
 		dev_err(&pdev->dev,
 			"%s: Memory allocation failed for d->chan!\n",
 			__func__);
+		ret = -ENOMEM;
 		goto exit_release_d;
 	}
 
reviewer
#1 lore raw

PATCH 1/1 ARM: OMAP: fix error return code in omap1_system_dma_init()

Quoted 6 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return -ENOMEM in the d->chan alloc error handling case instead of 0, as done elsewhere in this function.

Thanks, applying into omap-for-v3.10/fixes.

Regards,

Tony

Quoted 17 lines
---
 arch/arm/mach-omap1/dma.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap1/dma.c +1 -0
index 68ab858..a94b3a7 100644
@@ -345,6 +345,7 @@ static int __init omap1_system_dma_init(void)
 		dev_err(&pdev->dev,
 			"%s: Memory allocation failed for d->chan!\n",
 			__func__);
+		ret = -ENOMEM;
 		goto exit_release_d;
 	}