Skip to contentSkip to conversation

Staging: hv: Fix a bug in get_vp_index()

PATCH In review K. Y. Srinivasan 2 participants 3 messages May 10, 2013 – May 17, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: hv: Fix a bug in get_vp_index()

Linux' notion of cpuid is different from the Host's notion of CPUID. In the call to bind the channel interrupts, we should use the host's notion of CPU Ids. Fix this bug.

---
 drivers/hv/channel_mgmt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hv/channel_mgmt.c +1 -1
index bad8128..21ef689 100644
@@ -329,7 +329,7 @@ static u32 get_vp_index(uuid_le *type_guid)
 		return 0;
 	}
 	cur_cpu = (++next_vp % max_cpus);
-	return cur_cpu;
+	return hv_context.vp_index[cur_cpu];
 }
 
 /*
Signature · 1 line
1.7.4.1
maintainer
#1 lore raw
Quoted 9 lines · K. Y. Srinivasan

Linux' notion of cpuid is different from the Host's notion of CPUID. In the call to bind the channel interrupts, we should use the host's notion of CPU Ids. Fix this bug.

---
 drivers/hv/channel_mgmt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Why do you have "Staging" in the Subject:? This isn't a staging driver anymore, right?

greg k-h

#2 lore raw
Quoted 15 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, May 16, 2013 7:00 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Stable
Subject: Re: [PATCH 1/1] Staging: hv: Fix a bug in get_vp_index()

Quoted 4 lines · K. Y. Srinivasan

Linux' notion of cpuid is different from the Host's notion of CPUID. In the call to bind the channel interrupts, we should use the host's notion of CPU Ids. Fix this bug.

Quoted 8 lines
Quoted 5 lines
---
 drivers/hv/channel_mgmt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Why do you have "Staging" in the Subject:? This isn't a staging driver anymore, right?

Sorry, my mistake; do you want me to resend this.

Regards,

K. Y

Quoted 3 lines

greg k-h