ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
Subsystems (4)
PATCH 1/1 ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information.
--- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap_hwmod_33xx_data.c +2 -1
@@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = { };static struct omap_hwmod_rst_info am33xx_gfx_resets[] = { - { .name ="gfx" , .rst_shift =0 }, + { .name ="gfx" , .rst_shift =0 , .st_shift =0 }, };static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = {
@@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = { .omap4 = { .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET, .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET, + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, },
Signature · 1 line
1.7.0.4
PATCH 1/1 ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
Quoted 36 lines
-----Original Message-----
From: Hiremath, Vaibhav
Sent: Sunday, May 05, 2013 12:18 AM
To: linux-omap at vger.kernel.org
Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org; Hiremath, Vaibhav; Paul Walmsley
Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmodGFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information.
Signed-off-by Vaibhav Hiremath <[email protected]>Cc Paul Walmsley <[email protected]>--- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = { };static struct omap_hwmod_rst_info am33xx_gfx_resets[] = { - { .name ="gfx" , .rst_shift =0 }, + { .name ="gfx" , .rst_shift =0 , .st_shift =0 }, };static struct
omap_hwmod_irq_infoam33xx_gfx_irqs[] = {
arch/arm/mach-omap2/omap_hwmod_33xx_data.c static struct omap_hwmod am33xx_gfx_hwmod = {
Quoted 8 lines
arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = { .omap4 = { .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET, .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET, + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, }, --
Tony and Paul,
Any Update on this one as well?
Thanks,
Vaibhav
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
Quoted 47 lines · Hiremath, Vaibhav
Quoted 36 lines
-----Original Message-----
From: Hiremath, Vaibhav
Sent: Sunday, May 05, 2013 12:18 AM
To: linux-omap at vger.kernel.org
Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org; Hiremath, Vaibhav; Paul Walmsley
Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmodGFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information.
Signed-off-by Vaibhav Hiremath <[email protected]>Cc Paul Walmsley <[email protected]>--- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = { };static struct omap_hwmod_rst_info am33xx_gfx_resets[] = { - { .name ="gfx" , .rst_shift =0 }, + { .name ="gfx" , .rst_shift =0 , .st_shift =0 }, };static struct
omap_hwmod_irq_infoam33xx_gfx_irqs[] = {arch/arm/mach-omap2/omap_hwmod_33xx_data.c static struct omap_hwmod am33xx_gfx_hwmod = {
Quoted 8 lines
arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = { .omap4 = { .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET, .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET, + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, }, --Tony and Paul,
Quoted 1 line
Any Update on this one as well?
Is this needed for v3.10 as a fix? If so, it should describe the regression or error.
Regards,
Tony
PATCH 1/1 ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
Quoted 59 lines
-----Original Message-----
From: Tony Lindgren [mailto:tony at atomide.com]
Sent: Friday, May 17, 2013 10:55 PM
To: Hiremath, Vaibhav
Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Paul Walmsley
Subject: Re: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmodQuoted 6 lines · Hiremath, Vaibhav
Quoted 6 lines
-----Original Message-----
From: Hiremath, Vaibhav
Sent: Sunday, May 05, 2013 12:18 AM
To: linux-omap at vger.kernel.org
Cc: tony at atomide.com; linux-arm-kernel at lists.infradead.org;Hiremath,
Quoted 2 lines
Quoted 2 lines
Vaibhav; Paul Walmsley
Subject: [PATCH] ARM: OMAP2+: AM33xx: Add missing reset status infoto
Quoted 39 lines
Quoted 28 lines
GFX hwmod
GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information.
Signed-off-by Vaibhav Hiremath <[email protected]>Cc Paul Walmsley <[email protected]>--- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = { };static struct omap_hwmod_rst_info am33xx_gfx_resets[] = { - { .name ="gfx" , .rst_shift =0 }, + { .name ="gfx" , .rst_shift =0 , .st_shift =0 }, };static struct
omap_hwmod_irq_infoam33xx_gfx_irqs[] = {arch/arm/mach-omap2/omap_hwmod_33xx_data.c static struct omap_hwmod am33xx_gfx_hwmod = {
Quoted 8 lines
arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1
-1@@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = { .omap4 = { .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET, .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET, + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, }, --Tony and Paul,
Quoted 5 lines
Quoted 1 line
Any Update on this one as well?
Is this needed for v3.10 as a fix? If so, it should describe the regression or error.
Certainly this is fix, but no impact on kernel boot.
I will describe it more in the description and send next version shortly.
Thanks,
Vaibhav
Paul Walmsley
maintainerPATCH 1/1 ARM: OMAP2+: AM33xx: Add missing reset status info to GFX hwmod
In reply to Vaibhav HiremathQuoted 6 lines · Vaibhav Hiremath
GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information.
Signed-off-by Vaibhav Hiremath <[email protected]>Cc Paul Walmsley <[email protected]>
Thanks, queued.
- Paul