Skip to contentSkip to conversation

directfb: Fix imlib2-config detection and dependencies

PATCH New Markos Chandras 2 participants 4 messages May 20, 2013 – May 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 directfb: Fix imlib2-config detection and dependencies

From: Markos Chandras <[email protected]>

The configure script will detect the host /usr/bin/imlib2-config if there is one instead of the one in the staging directory. Moreover, directfb uses --enable-imlib2 by default so it needs to depend on the BR2_PACKAGE_IMLIB2.

---
Another option would be to make the imlib2 support optional (similar to png support)

---
 package/directfb/Config.in   | 1 +
 package/directfb/directfb.mk | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
package/directfb/Config.in +1 -0
index b9ff5f9..dc7ba21 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_DIRECTFB
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_FREETYPE
+	select BR2_PACKAGE_IMLIB2
 	select BR2_PACKAGE_ZLIB
 	help
 	  http://www.directfb.org/
package/directfb/directfb.mk +3 -1
index 5ead084..034d388 100644
@@ -10,6 +10,8 @@ DIRECTFB_SOURCE = DirectFB-$(DIRECTFB_VERSION).tar.gz
 DIRECTFB_LICENSE = LGPLv2.1+
 DIRECTFB_LICENSE_FILES = COPYING
 DIRECTFB_INSTALL_STAGING = YES
+
+DIRECTFB_CONF_ENV = ac_cv_path_IMLIB2_CONFIG=$(STAGING_DIR)/usr/bin/imlib2-config
 DIRECTFB_CONF_OPT = \
 	--localstatedir=/var \
 	--disable-explicit-deps \
@@ -25,7 +27,7 @@ DIRECTFB_CONF_OPT = \
 	--without-tools
 DIRECTFB_CONFIG_SCRIPTS = directfb-config
 
-DIRECTFB_DEPENDENCIES = freetype zlib
+DIRECTFB_DEPENDENCIES = freetype imlib2 zlib
 
 ifeq ($(BR2_PACKAGE_DIRECTFB_MULTI),y)
 DIRECTFB_CONF_OPT += --enable-multi --enable-fusion
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 directfb: Fix imlib2-config detection and dependencies

Dear Markos Chandras,

Quoted 2 lines · Markos Chandras

Another option would be to make the imlib2 support optional (similar to png support)

I guess this would make sense, no?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 directfb: Fix imlib2-config detection and dependencies

Quoted 7 lines · Thomas Petazzoni

Dear Markos Chandras,

Quoted 2 lines · Markos Chandras

Another option would be to make the imlib2 support optional (similar to png support)

Quoted 8 lines

I guess this would make sense, no?

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Hi Thomas,

Your call :)

I am happy to send a new patch to make imlib2 optional.

--
Regards,
Markos Chandras

#3 lore raw

PATCH 1/1 directfb: Fix imlib2-config detection and dependencies

In reply to Thomas Petazzoni
Quoted 7 lines · Thomas Petazzoni

Dear Markos Chandras,

Quoted 2 lines · Markos Chandras

Another option would be to make the imlib2 support optional (similar to png support)

Quoted 8 lines

I guess this would make sense, no?

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Hi Thomas,

I sent a new patch to make the imlib2 support optional.

--
Regards,
Markos Chandras