Skip to contentSkip to conversation

ed: Convert to generic package infrastructure

PATCH New Markos Chandras 2 participants 3 messages May 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ed: Convert to generic package infrastructure

From: Markos Chandras <[email protected]>

The package uses custom configure and Makefile files.

---
 package/ed/ed.mk | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)
package/ed/ed.mk +20 -1
index 2bb8e0e..2207f09 100644
@@ -11,4 +11,23 @@ ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
 ED_LICENSE = GPLv3+
 ED_LICENSE_FILES = COPYING
 
-$(eval $(autotools-package))
+define ED_CONFIGURE_CMDS
+	( cd $(@D); \
+		./configure \
+		--prefix=/usr \
+		CPPFLAGS="$(TARGET_CPPFLAGS)" \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		CC="$(TARGET_CC)" \
+	)
+endef
+
+define ED_BUILD_CMDS
+	$(MAKE)	-C $(@D)
+endef
+
+define ED_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 ed: Convert to generic package infrastructure

Dear Markos Chandras,

package/ed/ed.mk ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ · line 15

Quoted 3 lines · Markos Chandras

-$(eval $(autotools-package))

package/ed/ed.mk +2 -0
+define ED_CONFIGURE_CMDS
+	( cd $(@D); \

Nitpick: we typically don't put a space here.

package/ed/ed.mk ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ · line 21

Quoted 6 lines
package/ed/ed.mk +6 -0
+		./configure \
+		--prefix=/usr \
+		CPPFLAGS="$(TARGET_CPPFLAGS)" \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		CC="$(TARGET_CC)" \

Maybe you could use $(TARGET_CONFIGURE_OPTS) here instead?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 ed: Convert to generic package infrastructure

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni

Dear Markos Chandras,

package/ed/ed.mk ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ · line 15

Quoted 3 lines · Markos Chandras

-$(eval $(autotools-package))

package/ed/ed.mk +2 -0
+define ED_CONFIGURE_CMDS
+     ( cd $(@D); \

Nitpick: we typically don't put a space here.

Do you mean after '(' or before '\' ?

Quoted 8 lines

package/ed/ed.mk ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \ · line 21

Quoted 7 lines
package/ed/ed.mk +6 -0
+             ./configure \
+             --prefix=/usr \
+             CPPFLAGS="$(TARGET_CPPFLAGS)" \
+             CFLAGS="$(TARGET_CFLAGS)" \
+             LDFLAGS="$(TARGET_LDFLAGS)" \
+             CC="$(TARGET_CC)" \
Quoted 4 lines

Maybe you could use $(TARGET_CONFIGURE_OPTS) here instead?

Thanks!

Yeah sure I will do that.

--
Regards,
Markos Chandras