Skip to contentSkip to conversation

ARM: nomadik: fix IRQ assignment for SMC ethernet

PATCH New Linus Walleij 2 participants 2 messages May 18, 2013 – May 21, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: nomadik: fix IRQ assignment for SMC ethernet

The assignment of IRQ for the SMC91x ethernet adapter had two problems making it non-working:

- It was not put into the ethernet device node. Let's do this by using the board-specific overlay, so we can make other overlays on other Nomadik boards.

- The IRQ number was actually completely wrong, this was the number for NHK8815, not S8815.

After this ethernet starts working on the USB S8815.

---
ARM SoC folks: I would appreciate if you apply this patch directly for v3.10 fixes.

---
 arch/arm/boot/dts/ste-nomadik-s8815.dts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
arch/arm/boot/dts/ste-nomadik-s8815.dts +9 -3
index b28fbf3..6f82d93 100644
@@ -14,13 +14,19 @@
 		bootargs = "root=/dev/ram0 console=ttyAMA1,115200n8 earlyprintk";
 	};
 
+	/* This is where the interrupt is routed on the S8815 board */
+	external-bus at 34000000 {
+		ethernet at 300 {
+			interrupt-parent = <&gpio3>;
+			interrupts = <8 0x1>;
+		};
+	};
+
 	/* Custom board node with GPIO pins to active etc */
 	usb-s8815 {
 		/* The S8815 is using this very GPIO pin for the SMSC91x IRQs */
 		ethernet-gpio {
-			gpios = <&gpio3 19 0x1>;
-			interrupts = <19 0x1>;
-			interrupt-parent = <&gpio3>;
+			gpios = <&gpio3 8 0x1>;
 		};
 		/* This will bias the MMC/SD card detect line */
 		mmcsd-gpio {
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 ARM: nomadik: fix IRQ assignment for SMC ethernet

Quoted 10 lines · Linus Walleij

The assignment of IRQ for the SMC91x ethernet adapter had two problems making it non-working:

- It was not put into the ethernet device node. Let's do this by using the board-specific overlay, so we can make other overlays on other Nomadik boards.

- The IRQ number was actually completely wrong, this was the number for NHK8815, not S8815.

Quoted 6 lines

After this ethernet starts working on the USB S8815.

---
ARM SoC folks: I would appreciate if you apply this patch directly for v3.10 fixes.

Done.

-Olof