[3.10] mei: bus: Reset event_cb when disabling a device
Subsystems (2)
PATCH 1/1 [3.10] mei: bus: Reset event_cb when disabling a device
After cancelling all reads from the disable hook, we need to reset the event_cb pointer as well or else we won't be able to set a new one up when re-enabling the device.
--- drivers/misc/mei/bus.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/misc/mei/bus.c +2 -0
@@ -496,6 +496,8 @@ int mei_cl_disable_device(struct mei_cl_device *device) } } + device->event_cb =NULL ; +mutex_unlock (&dev->device_lock);if (!device->ops || !device->ops->disable)
Signature · 5 lines
1.7.10.4 -- Intel Open Source Technology Centre http://oss.intel.com/
Quoted 9 lines
-----Original Message-----
From: Samuel Ortiz [mailto:[email protected]]
Sent: Tuesday, May 21, 2013 16:58
To: Winkler, Tomas
Cc: linux-kernel
Subject: [PATCH] [3.10] mei: bus: Resetevent_cbwhen disabling a device
Quoted 5 lines
After cancelling all reads from the disable hook, we need to reset the
event_cbpointer as well or else we won't be able to set a new one up when re-enabling the device.Signed-off-by Samuel Ortiz <[email protected]>
Acked.
Quoted 9 lines · Tomas
Quoted 9 lines
-----Original Message-----
From: Samuel Ortiz [mailto:[email protected]]
Sent: Tuesday, May 21, 2013 16:58
To: Winkler, Tomas
Cc: linux-kernel
Subject: [PATCH] [3.10] mei: bus: Resetevent_cbwhen disabling a device
Quoted 6 lines
Quoted 5 lines
After cancelling all reads from the disable hook, we need to reset the
event_cbpointer as well or else we won't be able to set a new one up when re-enabling the device.Signed-off-by Samuel Ortiz <[email protected]>Acked.
Greg, I did not initially Cc you and now you don't actually have the patch, sorry.
Let me re-send the patch with Tomas ACK added.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/
Greg KH ([email protected])
maintainerQuoted 9 lines · Tomas
Quoted 9 lines
-----Original Message-----
From: Samuel Ortiz [mailto:[email protected]]
Sent: Tuesday, May 21, 2013 16:58
To: Winkler, Tomas
Cc: linux-kernel
Subject: [PATCH] [3.10] mei: bus: Resetevent_cbwhen disabling a device
Quoted 6 lines
Quoted 5 lines
After cancelling all reads from the disable hook, we need to reset the
event_cbpointer as well or else we won't be able to set a new one up when re-enabling the device.Signed-off-by Samuel Ortiz <[email protected]>Acked.
Nice, but can someone actually send me the patch to apply?
thanks,
greg k-h