blktrace: document -k option

PATCH In review Eric Sandeen 3 participants 4 messages May 9, 2013 – May 22, 2013

Share & tools

Eric Sandeen

author

2013-05-09 02:00 UTC #0 lore raw

PATCH 1/1 blktrace: document -k option

The -k option was missing from the usage() output and was present only in the man page synopsis. Say a few more words about it.

Signed-off-by Eric Sandeen <[email protected]>

---

blktrace.c +2 -0

index 89aaaac..4e96573 100644
@@ -450,6 +450,7 @@ static char usage_str[] = "\n\n" \
         "[ -p <port number>   | --port=<port number>]\n" \
         "[ -s                 | --no-sendfile]\n" \
         "[ -I <devs file>     | --input-devs=<devs file>]\n" \
+        "[ -k                 | --kill]\n" \
         "[ -v <version>       | --version]\n" \
         "[ -V <version>       | --version]\n" \

@@ -467,6 +468,7 @@ static char usage_str[] = "\n\n" \
 	"\t-p Network port to use (default 8462)\n" \
 	"\t-s Make the network client NOT use sendfile() to transfer data\n" \
 	"\t-I Add devices found in <devs file>\n" \
+	"\t-k Kill a running trace\n" \
 	"\t-v Print program version info\n" \
 	"\t-V Print program version info\n\n";

doc/blktrace.8 +7 -0

index b5e69b7..7f13231 100644
@@ -163,6 +163,13 @@ This only works when supplying a single device, or when piping the output
 via "-o -" with multiple devices.
 .RE
 
+\-k
+.br
+\-\-kill
+.RS
+Kill a running trace if blktrace dies
+.RE
+
 \-r \fIrel-path\fR
 .br
 \-\-relay=\fIrel-path\fR

Jeff Moyer

2013-05-09 14:00 UTC #1 lore raw

Quoted 3 lines · Eric Sandeen

The -k option was missing from the usage() output and was present only in the man page synopsis. Say a few more words about it.

Hmm. See:

commit fb7f86674a516ddff0d60bfab3bd284a4812075f

Author: Edward Shishkin <[email protected]>
Date:   Tue Apr 20 15:41:14 2010 +0200

blktrace: disable kill option - take 2

Eric Sandeen

author

2013-05-09 18:38 UTC #2 lore raw

In reply to Eric Sandeen

Quoted 6 lines · Jeff Moyer

Quoted 3 lines · Eric Sandeen
The -k option was missing from the usage() output and was present only in the man page synopsis. Say a few more words about it.

Quoted 8 lines

Hmm. See:
commit fb7f86674a516ddff0d60bfab3bd284a4812075f
Author: Edward Shishkin <[email protected]>
Date:   Tue Apr 20 15:41:14 2010 +0200
blktrace: disable kill option - take 2

Gah. That's clever.

Then I guess it should be removed from the synopsis too.

Shouldn't it have been removed from the actual code as well?

Thanks though :)

-Eric

Jens Axboe

2013-05-22 07:51 UTC #3 lore raw

In reply to Eric Sandeen

Quoted 16 lines · Eric Sandeen

Quoted 6 lines · Jeff Moyer
Quoted 3 lines · Eric Sandeen
The -k option was missing from the usage() output and was present only in the man page synopsis. Say a few more words about it.
Quoted 8 lines
Hmm. See:
commit fb7f86674a516ddff0d60bfab3bd284a4812075f
Author: Edward Shishkin <[email protected]>
Date:   Tue Apr 20 15:41:14 2010 +0200
blktrace: disable kill option - take 2

Quoted 7 lines

Gah. That's clever.
Then I guess it should be removed from the synopsis too.
Shouldn't it have been removed from the actual code as well?
Thanks though :)

Kill away :-)

Signature · 1 line

Jens Axboe