Skip to contentSkip to conversation

mm: Fix warning

PATCH New Ralf Baechle 1 participant 1 message May 22, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Fix warning

virt_to_page() is typically implemented as a macro containing a cast so it'll accept both pointers and unsigned long without causing a warning. MIPS virt_to_page() uses virt_to_phys which is a function so passing an unsigned long will cause a warning:

CC mm/page_alloc.o
/home/ralf/src/linux/linux-mips/mm/page_alloc.c: In function a??free_reserved_areaa??:
/home/ralf/src/linux/linux-mips/mm/page_alloc.c:5161:3: warning: passing argument 1 of a??virt_to_physa?? makes pointer from integer without a cast [enabled by default] In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/page.h:153:0,
from /home/ralf/src/linux/linux-mips/include/linux/mmzone.h:20,
from /home/ralf/src/linux/linux-mips/include/linux/gfp.h:4,
from /home/ralf/src/linux/linux-mips/include/linux/mm.h:8,
from /home/ralf/src/linux/linux-mips/mm/page_alloc.c:18:
/home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:119:100: note: expected a??const volatile void *a?? but argument is of type a??long unsigned inta??

All others users of virt_to_page() in mm/ are passing a void *.

---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
index 98cbdf6..378a15b 100644
@@ -5158,7 +5158,7 @@ unsigned long free_reserved_area(unsigned long start, unsigned long end,
 	for (pages = 0; pos < end; pos += PAGE_SIZE, pages++) {
 		if (poison)
 			memset((void *)pos, poison, PAGE_SIZE);
-		free_reserved_page(virt_to_page(pos));
+		free_reserved_page(virt_to_page((void *)pos));
 	}
 
 	if (pages && s)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>