Skip to contentSkip to conversation

queued patches for 3.10

DISCUSSION Jeff Layton 2 participants 4 messages May 24, 2013 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I just noticed that this patch is still not in mainline:

cifs: only set ops for inodes in I_NEW state

...is there a problem with it? It really needs to go in soon if not.

Also, I posted a few other patches on Tuesday that need to go into 3.10 as well:

cifs: fix error handling when calling cifs_parse_devname
cifs: allow sec=none mounts to work against servers that don't support extended security
cifs: stop printing the unc= option in /proc/mounts

...this one also needs to go to stable:

cifs: fix potential buffer overrun when composing a new options string

...and the last version of this patch that I posted should have had a [PATCH v3] in the subject, but I forgot to add that:

cifs: fix composing of mount options for DFS referrals

...that patch is based on top of the previous patch that's slated for stable. All of these patches are in my cifs-3.10 branch if you want to just cherry-pick them from there:

    http://git.samba.org/?p=jlayton/linux.git;a=shortlog;h=refs/heads/cifs-3.10
Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20130524074937.0f225d12-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

#2 lore raw

I sent a merge request for the setops fix, the other five in your for-3.10 are queued in the for-3.10 branch (and for-3.11 branch there are five more in for-3.11 from your longer series that I have already reviewed and put in - note that this for-3.11 branch is soon to be called "for-next" so linux-next will be building it)

In the series of patches for-3.10 I did fix up two formatting errors that checkpatch noticed:

ERROR: space required before the open parenthesis '(' #34: FILE: fs/cifs/connect.c:1261:
+ switch(cifs_parse_devname(devname, vol)) {

total: 1 errors, 0 warnings, 34 lines checked

/home/stevef/Downloads/patch3 has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 9 lines checked

/home/stevef/Downloads/patch4 has no obvious style problems and is ready for submission.
ERROR: space required before the open parenthesis '(' #98: FILE: fs/cifs/cifs_dfs_ref.c:81:
+ while(*pos == '\\') {

total: 1 errors, 0 warnings, 197 lines checked

I have reviewed 3 of the 5 of your most recent patches in for-3.10, but would appreciate more review especially on the two larger ones ("fix error handling ..." and "fix composing ...") in that series.

Quoted 30 lines · Jeff Layton

I just noticed that this patch is still not in mainline:

cifs: only set ops for inodes in I_NEW state

...is there a problem with it? It really needs to go in soon if not.

Also, I posted a few other patches on Tuesday that need to go into 3.10 as well:

cifs: fix error handling when calling cifs_parse_devname
cifs: allow sec=none mounts to work against servers that don't support extended security
cifs: stop printing the unc= option in /proc/mounts

...this one also needs to go to stable:

cifs: fix potential buffer overrun when composing a new options string

...and the last version of this patch that I posted should have had a [PATCH v3] in the subject, but I forgot to add that:

cifs: fix composing of mount options for DFS referrals

...that patch is based on top of the previous patch that's slated for stable. All of these patches are in my cifs-3.10 branch if you want to just cherry-pick them from there:

    http://git.samba.org/?p=jlayton/linux.git;a=shortlog;h=refs/heads/cifs-3.10

--
Jeff Layton <[email protected]>

Signature · 3 lines
Thanks,

Steve

A message that is not in the archive (sent off-list or not yet received): CAH2r5msJ1zza9KzOHeFYShjVm98S+wWF_e-bufkiUct+QhF77Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 9 lines · On Fri, 24 May 2013 13:21:06 -0500 Steve French…

I sent a merge request for the setops fix, the other five in your for-3.10 are queued in the for-3.10 branch (and for-3.11 branch there are five more in for-3.11 from your longer series that I have already reviewed and put in - note that this for-3.11 branch is soon to be called "for-next" so linux-next will be building it)

In the series of patches for-3.10 I did fix up two formatting errors that checkpatch noticed:

Thanks for fixing those.

Quoted 4 lines

I have reviewed 3 of the 5 of your most recent patches in for-3.10, but would appreciate more review especially on the two larger ones ("fix error handling ..." and "fix composing ...") in that series.

Ok...

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20130524142351.3d4d0319-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

#6 lore raw
Quoted 13 lines · Jeff Layton
Quoted 9 lines · On Fri, 24 May 2013 13:21:06 -0500 Steve French…

I sent a merge request for the setops fix, the other five in your for-3.10 are queued in the for-3.10 branch (and for-3.11 branch there are five more in for-3.11 from your longer series that I have already reviewed and put in - note that this for-3.11 branch is soon to be called "for-next" so linux-next will be building it)

In the series of patches for-3.10 I did fix up two formatting errors that checkpatch noticed:

Quoted 8 lines

Thanks for fixing those.

Quoted 4 lines

I have reviewed 3 of the 5 of your most recent patches in for-3.10, but would appreciate more review especially on the two larger ones ("fix error handling ..." and "fix composing ...") in that series.

Ok...

cifs-2.6.git for-next is fixed up to look like a "for-3.11" branch. There also is still a for-3.10 with the five patches I know about for-3.10 still - if you know of any others that should go in for-3.10 let me know. Perhaps the removexattr patch might be one for example.

Signature · 3 lines
Thanks,

Steve